X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=flat_input.cpp;h=6e3db34cfceb1e772566f10f5e3ab82cbe675a68;hp=1795902bcc23448741427e190772f371fe720a55;hb=eff011224abc5dc81f801f3ea44572287a55bcac;hpb=9c12e38b7cd88a77ef297d080b7c41e6bd6326fb

diff --git a/flat_input.cpp b/flat_input.cpp
index 1795902..6e3db34 100644
--- a/flat_input.cpp
+++ b/flat_input.cpp
@@ -21,7 +21,8 @@ FlatInput::FlatInput(ImageFormat image_format, MovitPixelFormat pixel_format_in,
 	  width(width),
 	  height(height),
 	  pitch(width),
-	  pixel_data(NULL),
+	  owns_texture(false),
+	  pixel_data(nullptr),
 	  fixup_swap_rb(false),
 	  fixup_red_to_grayscale(false)
 {
@@ -57,9 +58,7 @@ FlatInput::FlatInput(ImageFormat image_format, MovitPixelFormat pixel_format_in,
 
 FlatInput::~FlatInput()
 {
-	if (texture_num != 0) {
-		resource_pool->release_2d_texture(texture_num);
-	}
+	possibly_release_texture();
 }
 
 void FlatInput::set_gl_state(GLuint glsl_program_num, const string& prefix, unsigned *sampler_num)
@@ -67,7 +66,7 @@ void FlatInput::set_gl_state(GLuint glsl_program_num, const string& prefix, unsi
 	glActiveTexture(GL_TEXTURE0 + *sampler_num);
 	check_error();
 
-	if (texture_num == 0) {
+	if (texture_num == 0 && (pbo != 0 || pixel_data != nullptr)) {
 		// Translate the input format to OpenGL's enums.
 		GLint internal_format;
 		GLenum format;
@@ -163,9 +162,12 @@ void FlatInput::set_gl_state(GLuint glsl_program_num, const string& prefix, unsi
 		check_error();
 		glBindBuffer(GL_PIXEL_UNPACK_BUFFER_ARB, 0);
 		check_error();
+		owns_texture = true;
 	} else {
 		glBindTexture(GL_TEXTURE_2D, texture_num);
 		check_error();
+		glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, needs_mipmaps ? GL_LINEAR_MIPMAP_NEAREST : GL_LINEAR);
+		check_error();
 	}
 
 	// Bind it to a sampler.
@@ -183,9 +185,15 @@ string FlatInput::output_fragment_shader()
 
 void FlatInput::invalidate_pixel_data()
 {
-	if (texture_num != 0) {
+	possibly_release_texture();
+}
+
+void FlatInput::possibly_release_texture()
+{
+	if (texture_num != 0 && owns_texture) {
 		resource_pool->release_2d_texture(texture_num);
 		texture_num = 0;
+		owns_texture = false;
 	}
 }