X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=lift_gamma_gain_effect_test.cpp;h=f9163a8b32ea53188c831386512d78172828c58d;hp=9850ba28064ede83071c2fb8f292bc88ec359c27;hb=e72d9577b3af42805d84a640c698853b11060476;hpb=58e7b9a8164bdaad7b0c698b2d0d80db53d79a5c

diff --git a/lift_gamma_gain_effect_test.cpp b/lift_gamma_gain_effect_test.cpp
index 9850ba2..f9163a8 100644
--- a/lift_gamma_gain_effect_test.cpp
+++ b/lift_gamma_gain_effect_test.cpp
@@ -1,11 +1,15 @@
 // Unit tests for LiftGammaGainEffect.
 
+#include <epoxy/gl.h>
+
 #include "effect_chain.h"
 #include "gtest/gtest.h"
 #include "image_format.h"
 #include "lift_gamma_gain_effect.h"
 #include "test_util.h"
 
+namespace movit {
+
 TEST(LiftGammaGainEffectTest, DefaultIsNoop) {
 	float data[] = {
 		0.0f, 0.0f, 0.0f, 1.0f,
@@ -114,3 +118,32 @@ TEST(LiftGammaGainEffectTest, OutOfGamutColorsAreClipped) {
 
 	expect_equal(expected_data, out_data, 4, 3);
 }
+
+TEST(LiftGammaGainEffectTest, NegativeLiftIsClamped) {
+	float data[] = {
+		0.0f, 0.0f, 0.0f, 1.0f,
+		0.5f, 0.5f, 0.5f, 0.3f,
+		1.0f, 0.0f, 0.0f, 1.0f,
+		0.0f, 1.0f, 0.0f, 0.7f,
+		0.0f, 0.0f, 1.0f, 1.0f,
+	};
+	float lift[3] = { 0.0f, -0.1f, -0.2f };
+	float expected_data[] = {
+		0.0f, 0.0f , 0.0f, 1.0f,  // Note: Clamped below zero.
+		0.5f, 0.45f, 0.4f, 0.3f,
+		1.0f, 0.0f,  0.0f, 1.0f,  // Unaffected.
+		0.0f, 1.0f,  0.0f, 0.7f,
+		0.0f, 0.0f,  1.0f, 1.0f,
+	};
+
+	float out_data[5 * 4];
+	EffectChainTester tester(data, 1, 5, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_sRGB);
+	Effect *lgg_effect = tester.get_chain()->add_effect(new LiftGammaGainEffect());
+	ASSERT_TRUE(lgg_effect->set_vec3("lift", lift));
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	// sRGB is only approximately gamma-2.2, so loosen up the limits a bit.
+	expect_equal(expected_data, out_data, 4, 5, 0.03, 0.003);
+}
+
+}  // namespace movit