X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=test_util.cpp;h=ab10f7b82be0fd3a4528d54eb406cdd6ce09f733;hp=8fa67149d3ba19e86d0b34b194fc035792ad49f0;hb=1727b0714398fc4f318048d457a35ca58bc30b59;hpb=f52ae2984b179e8d91e3d78ecc72888644fce406

diff --git a/test_util.cpp b/test_util.cpp
index 8fa6714..ab10f7b 100644
--- a/test_util.cpp
+++ b/test_util.cpp
@@ -7,36 +7,63 @@
 
 #include <algorithm>
 
-EffectChainTester::EffectChainTester(const float *data, unsigned width, unsigned height, ColorSpace color_space, GammaCurve gamma_curve)
+EffectChainTester::EffectChainTester(const float *data, unsigned width, unsigned height, MovitPixelFormat pixel_format, ColorSpace color_space, GammaCurve gamma_curve)
 	: chain(width, height), width(width), height(height)
 {
-	add_input(data, color_space, gamma_curve);
+	add_input(data, pixel_format, color_space, gamma_curve);
+
+	glGenTextures(1, &texnum);
+	check_error();
+	glBindTexture(GL_TEXTURE_2D, texnum);
+	check_error();
+	glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA16F_ARB, width, height, 0, GL_RGBA, GL_UNSIGNED_BYTE, NULL);
+	check_error();
+
+	glGenFramebuffers(1, &fbo);
+	check_error();
+	glBindFramebuffer(GL_FRAMEBUFFER, fbo);
+	check_error();
+	glFramebufferTexture2D(
+		GL_FRAMEBUFFER,
+		GL_COLOR_ATTACHMENT0,
+		GL_TEXTURE_2D,
+		texnum,
+		0);
+	check_error();
+	glBindFramebuffer(GL_FRAMEBUFFER, 0);
+	check_error();
 }
 
-Input *EffectChainTester::add_input(const float *data, ColorSpace color_space, GammaCurve gamma_curve)
+EffectChainTester::~EffectChainTester()
+{
+	glDeleteFramebuffers(1, &fbo);
+	glDeleteTextures(1, &texnum);
+}
+
+Input *EffectChainTester::add_input(const float *data, MovitPixelFormat pixel_format, ColorSpace color_space, GammaCurve gamma_curve)
 {
 	ImageFormat format;
 	format.color_space = color_space;
 	format.gamma_curve = gamma_curve;
 
-	FlatInput *input = new FlatInput(format, FORMAT_GRAYSCALE, GL_FLOAT, width, height);
+	FlatInput *input = new FlatInput(format, pixel_format, GL_FLOAT, width, height);
 	input->set_pixel_data(data);
 	chain.add_input(input);
 	return input;
 }
 
-void EffectChainTester::run(float *out_data, ColorSpace color_space, GammaCurve gamma_curve)
+void EffectChainTester::run(float *out_data, GLenum format, ColorSpace color_space, GammaCurve gamma_curve)
 {
-	ImageFormat format;
-	format.color_space = color_space;
-	format.gamma_curve = gamma_curve;
-	chain.add_output(format);
+	ImageFormat image_format;
+	image_format.color_space = color_space;
+	image_format.gamma_curve = gamma_curve;
+	chain.add_output(image_format);
 	chain.finalize();
 
-	glViewport(0, 0, width, height);
-	chain.render_to_screen();
+	chain.render_to_fbo(fbo, width, height);
 
-	glReadPixels(0, 0, width, height, GL_RED, GL_FLOAT, out_data);
+	glBindFramebuffer(GL_FRAMEBUFFER, fbo);
+	glReadPixels(0, 0, width, height, format, GL_FLOAT, out_data);
 
 	// Flip upside-down to compensate for different origin.
 	for (unsigned y = 0; y < height / 2; ++y) {
@@ -47,23 +74,28 @@ void EffectChainTester::run(float *out_data, ColorSpace color_space, GammaCurve
 	}
 }
 
-void expect_equal(const float *ref, const float *result, unsigned width, unsigned height)
+void expect_equal(const float *ref, const float *result, unsigned width, unsigned height, float largest_difference_limit, float rms_limit)
 {
 	float largest_difference = -1.0f;
 	float squared_difference = 0.0f;
+	int largest_diff_x = -1, largest_diff_y = -1;
 
 	for (unsigned y = 0; y < height; ++y) {
 		for (unsigned x = 0; x < width; ++x) {
 			float diff = ref[y * width + x] - result[y * width + x];
-			largest_difference = std::max(largest_difference, fabsf(diff));
+			if (fabs(diff) > largest_difference) {
+				largest_difference = fabs(diff);
+				largest_diff_x = x;
+				largest_diff_y = y;
+			}
 			squared_difference += diff * diff;
 		}
 	}
 
-	const float largest_difference_limit = 1.5 / 255.0;
-	const float rms_limit = 0.5 / 255.0;
-
-	EXPECT_LT(largest_difference, largest_difference_limit);
+	EXPECT_LT(largest_difference, largest_difference_limit)
+		<< "Largest difference is in x=" << largest_diff_x << ", y=" << largest_diff_y << ":\n"
+		<< "Reference: " << ref[largest_diff_y * width + largest_diff_x] << "\n"
+		<< "Result:    " << result[largest_diff_y * width + largest_diff_x];
 
 	float rms = sqrt(squared_difference) / (width * height);
 	EXPECT_LT(rms, rms_limit);