X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=util.h;h=f62618c404325ef7ef44f2b5b02326e208fc32c7;hp=432171ac015d3fd5921b5eb9fe9c0ccffd92b9b3;hb=ca4d87878bb32c7d672ac00f41ca0292f19acfcb;hpb=b09a4cb8dec09bcd1e42026d5b229b57e620e47c

diff --git a/util.h b/util.h
index 432171a..f62618c 100644
--- a/util.h
+++ b/util.h
@@ -1,18 +1,18 @@
-#ifndef _UTIL_H
-#define _UTIL_H 1
+#ifndef _MOVIT_UTIL_H
+#define _MOVIT_UTIL_H 1
 
 // Various utilities.
 
+#include <GL/glew.h>
 #include <stdio.h>
 #include <stdlib.h>
-
-#include <string>
 #include <Eigen/Core>
-
-#include "opengl.h"
+#include <string>
 
 #define BUFFER_OFFSET(i) ((char *)NULL + (i))
 
+namespace movit {
+
 // Converts a HSV color to RGB. Assumes h in [0, 2pi> or [-pi, pi>
 void hsv2rgb(float h, float s, float v, float *r, float *g, float *b);
 
@@ -36,24 +36,26 @@ std::string output_glsl_mat3(const std::string &name, const Eigen::Matrix3d &m);
 
 // Calculate where to sample, and with what weight, if one wants to use
 // the GPU's bilinear hardware to sample w1 * x[0] + w2 * x[1].
-static inline void combine_two_samples(float w1, float w2, float *offset, float *total_weight)
-{
-	assert(w1 * w2 >= 0.0f);  // Should not have differing signs.
-	if (fabs(w1 + w2) < 1e-6) {
-		*offset = 0.5f;
-		*total_weight = 0.0f;
-	} else {
-		*offset = w2 / (w1 + w2);
-		*total_weight = w1 + w2;
-	}
-	assert(*offset >= 0.0f);
-	assert(*offset <= 1.0f);
-}
+//
+// Note that since the GPU might have limited precision in its linear
+// interpolation, the effective weights might be different from the ones you
+// asked for. sum_sq_error, if not NULL, will contain the sum of the
+// (estimated) squared errors of the two weights.
+void combine_two_samples(float w1, float w2, float *offset, float *total_weight, float *sum_sq_error);
+
+}  // namespace movit
 
 #ifdef NDEBUG
 #define check_error()
 #else
-#define check_error() { int err = glGetError(); if (err != GL_NO_ERROR) { printf("GL error 0x%x at %s:%d\n", err, __FILE__, __LINE__); exit(1); } }
+#define check_error() { int err = glGetError(); if (err != GL_NO_ERROR) { printf("GL error 0x%x at %s:%d\n", err, __FILE__, __LINE__); abort(); } }
+#endif
+
+// CHECK() is like assert(), but retains any side effects no matter the compilation mode.
+#ifdef NDEBUG
+#define CHECK(x) (void)(x)
+#else
+#define CHECK(x) do { bool ok = x; if (!ok) { fprintf(stderr, "%s:%d: %s: Assertion `%s' failed.\n", __FILE__, __LINE__, __PRETTY_FUNCTION__, #x); abort(); } } while (false)
 #endif
 
-#endif // !defined(_UTIL_H)
+#endif // !defined(_MOVIT_UTIL_H)