X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=ycbcr_conversion_effect_test.cpp;h=a35b9f1ef0307c26522123068f9d8c0fa2e36daa;hp=e532ad3e44da0037f3d1756aed2d1f993a422d32;hb=aa1fce6c5356faa368758b15b3ad257c0f7bda0b;hpb=af438a8d5331bb1435494eaf377256deac74f408

diff --git a/ycbcr_conversion_effect_test.cpp b/ycbcr_conversion_effect_test.cpp
index e532ad3..a35b9f1 100644
--- a/ycbcr_conversion_effect_test.cpp
+++ b/ycbcr_conversion_effect_test.cpp
@@ -381,6 +381,89 @@ TEST(YCbCrConversionEffectTest, OutputChunkyAndRGBA) {
 	expect_equal(expected_rgba, out_rgba, 4 * width, height, 7, 255 * 0.002);
 }
 
+TEST(YCbCrConversionEffectTest, MultipleOutputsAndRGBA) {
+	const int width = 1;
+	const int height = 5;
+
+	// Pure-color test inputs, calculated with the formulas in Rec. 601
+	// section 2.5.4.
+	unsigned char y[width * height] = {
+		16, 235, 81, 145, 41,
+	};
+	unsigned char cb[width * height] = {
+		128, 128, 90, 54, 240,
+	};
+	unsigned char cr[width * height] = {
+		128, 128, 240, 34, 110,
+	};
+	unsigned char expected_ycbcr[width * height * 4] = {
+		// The same data, just rearranged.
+		 16, 128, 128, 255,
+		235, 128, 128, 255,
+		 81,  90, 240, 255,
+		145,  54,  34, 255,
+		 41, 240, 110, 255
+	};
+	unsigned char expected_rgba[width * height * 4] = {
+		  0,   0,   0, 255,
+		255, 255, 255, 255,
+		255,   0,   0, 255,
+		  0, 255,   0, 255,
+		  0,   0, 255, 255,
+	};
+
+	unsigned char out_ycbcr[width * height * 4];
+	unsigned char out_y[width * height * 4];
+	unsigned char out_cbcr[width * height * 4];
+	unsigned char out_rgba[width * height * 4];
+
+	EffectChainTester tester(NULL, width, height, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_LINEAR, GL_RGBA8);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	tester.add_output(format, OUTPUT_ALPHA_FORMAT_POSTMULTIPLIED);
+	tester.add_ycbcr_output(format, OUTPUT_ALPHA_FORMAT_POSTMULTIPLIED, ycbcr_format);
+	tester.add_ycbcr_output(format, OUTPUT_ALPHA_FORMAT_POSTMULTIPLIED, ycbcr_format, YCBCR_OUTPUT_SPLIT_Y_AND_CBCR);
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
+	input->set_pixel_data(0, y);
+	input->set_pixel_data(1, cb);
+	input->set_pixel_data(2, cr);
+	tester.get_chain()->add_input(input);
+
+	// Note: We don't test that the values actually get dithered,
+	// just that the shader compiles and doesn't mess up badly.
+	tester.get_chain()->set_dither_bits(8);
+
+	tester.run(out_ycbcr, out_y, out_cbcr, out_rgba, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+	expect_equal(expected_ycbcr, out_ycbcr, width * 4, height);
+
+	// Check that the extra Y' and CbCr outputs also are fine.
+	for (unsigned i = 0; i < width * height; ++i) {
+		out_ycbcr[i * 4] = out_y[i * 4];
+		out_ycbcr[i * 4 + 1] = out_cbcr[i * 4 + 0];
+		out_ycbcr[i * 4 + 2] = out_cbcr[i * 4 + 1];
+	}
+	expect_equal(expected_ycbcr, out_ycbcr, width * 4, height);
+
+	// Y'CbCr isn't 100% accurate (the input values are rounded),
+	// so we need some leeway.
+	expect_equal(expected_rgba, out_rgba, 4 * width, height, 7, 255 * 0.002);
+}
+
 // Very similar to PlanarOutput.
 TEST(YCbCrConversionEffectTest, ChangeOutputFormat) {
 	const int width = 1;