X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=ycbcr_input_test.cpp;h=7792b289ef6c1e43e8fd06cdc12dab700e412a46;hp=7b2a6fd51f0140bc2023411a5bc7b30afab1e848;hb=98f458e22ce732e6c50a9856d7fd636dca49b4c3;hpb=c19875219539e598eb364050ddbb12ae3c64ec31

diff --git a/ycbcr_input_test.cpp b/ycbcr_input_test.cpp
index 7b2a6fd..7792b28 100644
--- a/ycbcr_input_test.cpp
+++ b/ycbcr_input_test.cpp
@@ -1,11 +1,21 @@
-// Unit tests for YCbCrInput.
-// FIXME: This class really ought to support mipmaps.
+// Unit tests for YCbCrInput. Also tests the matrix functions in ycbcr.cpp directly.
 
-#include "test_util.h"
+#include <epoxy/gl.h>
+#include <stddef.h>
+
+#include <Eigen/Core>
+#include <Eigen/LU>
+
+#include "effect_chain.h"
 #include "gtest/gtest.h"
+#include "test_util.h"
+#include "util.h"
+#include "resource_pool.h"
 #include "ycbcr_input.h"
 
-TEST(YCbCrInput, Simple444) {
+namespace movit {
+
+TEST(YCbCrInputTest, Simple444) {
 	const int width = 1;
 	const int height = 5;
 
@@ -38,10 +48,13 @@ TEST(YCbCrInput, Simple444) {
 	YCbCrFormat ycbcr_format;
 	ycbcr_format.luma_coefficients = YCBCR_REC_601;
 	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
 	ycbcr_format.chroma_subsampling_x = 1;
 	ycbcr_format.chroma_subsampling_y = 1;
-	ycbcr_format.chroma_x_position = 0.5f;
-	ycbcr_format.chroma_y_position = 0.5f;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
 
 	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
 	input->set_pixel_data(0, y);
@@ -56,7 +69,56 @@ TEST(YCbCrInput, Simple444) {
 	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
 }
 
-TEST(YCbCrInput, FullRangeRec601) {
+TEST(YCbCrInputTest, Interleaved444) {
+	const int width = 1;
+	const int height = 5;
+
+	// Same data as Simple444, just rearranged.
+	unsigned char data[width * height * 3] = {
+		 16, 128, 128,
+		235, 128, 128,
+		 81,  90, 240,
+		145,  54,  34,
+		 41, 240, 110,
+	};
+	float expected_data[4 * width * height] = {
+		0.0, 0.0, 0.0, 1.0,
+		1.0, 1.0, 1.0, 1.0,
+		1.0, 0.0, 0.0, 1.0,
+		0.0, 1.0, 0.0, 1.0,
+		0.0, 0.0, 1.0, 1.0,
+	};
+	float out_data[4 * width * height];
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height, YCBCR_INPUT_INTERLEAVED);
+	input->set_pixel_data(0, data);
+	tester.get_chain()->add_input(input);
+
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	// Y'CbCr isn't 100% accurate (the input values are rounded),
+	// so we need some leeway.
+	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
+}
+
+TEST(YCbCrInputTest, FullRangeRec601) {
 	const int width = 1;
 	const int height = 5;
 
@@ -90,10 +152,13 @@ TEST(YCbCrInput, FullRangeRec601) {
 	YCbCrFormat ycbcr_format;
 	ycbcr_format.luma_coefficients = YCBCR_REC_601;
 	ycbcr_format.full_range = true;
+	ycbcr_format.num_levels = 256;
 	ycbcr_format.chroma_subsampling_x = 1;
 	ycbcr_format.chroma_subsampling_y = 1;
-	ycbcr_format.chroma_x_position = 0.5f;
-	ycbcr_format.chroma_y_position = 0.5f;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
 
 	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
 	input->set_pixel_data(0, y);
@@ -108,7 +173,7 @@ TEST(YCbCrInput, FullRangeRec601) {
 	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
 }
 
-TEST(YCbCrInput, Rec709) {
+TEST(YCbCrInputTest, Rec709) {
 	const int width = 1;
 	const int height = 5;
 
@@ -141,10 +206,13 @@ TEST(YCbCrInput, Rec709) {
 	YCbCrFormat ycbcr_format;
 	ycbcr_format.luma_coefficients = YCBCR_REC_709;
 	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
 	ycbcr_format.chroma_subsampling_x = 1;
 	ycbcr_format.chroma_subsampling_y = 1;
-	ycbcr_format.chroma_x_position = 0.5f;
-	ycbcr_format.chroma_y_position = 0.5f;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
 
 	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
 	input->set_pixel_data(0, y);
@@ -159,7 +227,63 @@ TEST(YCbCrInput, Rec709) {
 	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
 }
 
-TEST(YCbCrInput, Subsampling420) {
+TEST(YCbCrInputTest, Rec2020) {
+	const int width = 1;
+	const int height = 5;
+
+	// Pure-color test inputs, calculated with the formulas in Rec. 2020
+	// page 4, tables 4 and 5 (for conventional non-constant luminance).
+	// Note that we still use 8-bit inputs, even though Rec. 2020 is only
+	// defined for 10- and 12-bit.
+	unsigned char y[width * height] = {
+		16, 235, 74, 164, 29,
+	};
+	unsigned char cb[width * height] = {
+		128, 128, 97, 47, 240,
+	};
+	unsigned char cr[width * height] = {
+		128, 128, 240, 25, 119,
+	};
+	float expected_data[4 * width * height] = {
+		0.0, 0.0, 0.0, 1.0,
+		1.0, 1.0, 1.0, 1.0,
+		1.0, 0.0, 0.0, 1.0,
+		0.0, 1.0, 0.0, 1.0,
+		0.0, 0.0, 1.0, 1.0,
+	};
+	float out_data[4 * width * height];
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_2020;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
+	input->set_pixel_data(0, y);
+	input->set_pixel_data(1, cb);
+	input->set_pixel_data(2, cr);
+	tester.get_chain()->add_input(input);
+
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	// Y'CbCr isn't 100% accurate (the input values are rounded),
+	// so we need some leeway.
+	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
+}
+
+TEST(YCbCrInputTest, Subsampling420) {
 	const int width = 4;
 	const int height = 4;
 
@@ -200,10 +324,13 @@ TEST(YCbCrInput, Subsampling420) {
 	YCbCrFormat ycbcr_format;
 	ycbcr_format.luma_coefficients = YCBCR_REC_601;
 	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
 	ycbcr_format.chroma_subsampling_x = 2;
 	ycbcr_format.chroma_subsampling_y = 2;
-	ycbcr_format.chroma_x_position = 0.5f;
-	ycbcr_format.chroma_y_position = 0.5f;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
 
 	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
 	input->set_pixel_data(0, y);
@@ -218,7 +345,7 @@ TEST(YCbCrInput, Subsampling420) {
 	expect_equal(expected_data, out_data, width, height, 0.01, 0.001);
 }
 
-TEST(YCbCrInput, Subsampling420WithNonCenteredSamples) {
+TEST(YCbCrInputTest, Subsampling420WithNonCenteredSamples) {
 	const int width = 4;
 	const int height = 4;
 
@@ -259,10 +386,13 @@ TEST(YCbCrInput, Subsampling420WithNonCenteredSamples) {
 	YCbCrFormat ycbcr_format;
 	ycbcr_format.luma_coefficients = YCBCR_REC_601;
 	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
 	ycbcr_format.chroma_subsampling_x = 2;
 	ycbcr_format.chroma_subsampling_y = 2;
-	ycbcr_format.chroma_x_position = 0.0f;
-	ycbcr_format.chroma_y_position = 0.5f;
+	ycbcr_format.cb_x_position = 0.0f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.0f;
+	ycbcr_format.cr_y_position = 0.5f;
 
 	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
 	input->set_pixel_data(0, y);
@@ -274,5 +404,458 @@ TEST(YCbCrInput, Subsampling420WithNonCenteredSamples) {
 
 	// Y'CbCr isn't 100% accurate (the input values are rounded),
 	// so we need some leeway.
-	expect_equal(expected_data, out_data, width, height, 0.01, 0.001);
+	expect_equal(expected_data, out_data, width, height, 0.01, 0.0012);
 }
+
+// Yes, some 4:2:2 formats actually have this craziness.
+TEST(YCbCrInputTest, DifferentCbAndCrPositioning) {
+	const int width = 4;
+	const int height = 4;
+
+	unsigned char y[width * height] = {
+		126, 126, 126, 126,
+		126, 126, 126, 126,
+		126, 126, 126, 126,
+		126, 126, 126, 126,
+	};
+	unsigned char cb[(width/2) * height] = {
+		64, 128,
+		128, 192,
+		128, 128,
+		128, 128,
+	};
+	unsigned char cr[(width/2) * height] = {
+		48, 128,
+		128, 208,
+		128, 128,
+		128, 128,
+	};
+
+	// Chroma samples in this csae are always co-sited with a luma sample;
+	// their associated color values and position are marked off in comments.
+	float expected_data_blue[width * height] = {
+		   0.000 /* 0.0 */, 0.250,           0.500 /* 0.5 */, 0.500, 
+		   0.500 /* 0.5 */, 0.750,           1.000 /* 1.0 */, 1.000, 
+		   0.500 /* 0.5 */, 0.500,           0.500 /* 0.5 */, 0.500, 
+		   0.500 /* 0.5 */, 0.500,           0.500 /* 0.5 */, 0.500, 
+	};
+	float expected_data_red[width * height] = {
+		   0.000,           0.000 /* 0.0 */, 0.250,           0.500 /* 0.5 */, 
+		   0.500,           0.500 /* 0.5 */, 0.750,           1.000 /* 1.0 */, 
+		   0.500,           0.500 /* 0.5 */, 0.500,           0.500 /* 0.5 */, 
+		   0.500,           0.500 /* 0.5 */, 0.500,           0.500 /* 0.5 */, 
+	};
+	float out_data[width * height];
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 2;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.0f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 1.0f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
+	input->set_pixel_data(0, y);
+	input->set_pixel_data(1, cb);
+	input->set_pixel_data(2, cr);
+	tester.get_chain()->add_input(input);
+
+	// Y'CbCr isn't 100% accurate (the input values are rounded),
+	// so we need some leeway.
+	tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_sRGB);
+	expect_equal(expected_data_red, out_data, width, height, 0.02, 0.002);
+
+	tester.run(out_data, GL_BLUE, COLORSPACE_sRGB, GAMMA_sRGB);
+	expect_equal(expected_data_blue, out_data, width, height, 0.01, 0.001);
+}
+
+TEST(YCbCrInputTest, PBO) {
+	const int width = 1;
+	const int height = 5;
+
+	// Pure-color test inputs, calculated with the formulas in Rec. 601
+	// section 2.5.4.
+	unsigned char data[width * height * 3] = {
+		16, 235, 81, 145, 41,
+		128, 128, 90, 54, 240,
+		128, 128, 240, 34, 110,
+	};
+	float expected_data[4 * width * height] = {
+		0.0, 0.0, 0.0, 1.0,
+		1.0, 1.0, 1.0, 1.0,
+		1.0, 0.0, 0.0, 1.0,
+		0.0, 1.0, 0.0, 1.0,
+		0.0, 0.0, 1.0, 1.0,
+	};
+	float out_data[4 * width * height];
+
+	GLuint pbo;
+	glGenBuffers(1, &pbo);
+	glBindBuffer(GL_PIXEL_UNPACK_BUFFER_ARB, pbo);
+	glBufferData(GL_PIXEL_UNPACK_BUFFER_ARB, width * height * 3, data, GL_STREAM_DRAW);
+	glBindBuffer(GL_PIXEL_UNPACK_BUFFER_ARB, 0);
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
+	input->set_pixel_data(0, (unsigned char *)BUFFER_OFFSET(0), pbo);
+	input->set_pixel_data(1, (unsigned char *)BUFFER_OFFSET(width * height), pbo);
+	input->set_pixel_data(2, (unsigned char *)BUFFER_OFFSET(width * height * 2), pbo);
+	tester.get_chain()->add_input(input);
+
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	// Y'CbCr isn't 100% accurate (the input values are rounded),
+	// so we need some leeway.
+	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
+
+	glDeleteBuffers(1, &pbo);
+}
+
+TEST(YCbCrInputTest, CombinedCbAndCr) {
+	const int width = 1;
+	const int height = 5;
+
+	// Pure-color test inputs, calculated with the formulas in Rec. 601
+	// section 2.5.4.
+	unsigned char y[width * height] = {
+		16, 235, 81, 145, 41,
+	};
+	unsigned char cb_cr[width * height * 2] = {
+		128, 128,
+		128, 128,
+		 90, 240,
+		 54,  34,
+		240, 110,
+	};
+	float expected_data[4 * width * height] = {
+		0.0, 0.0, 0.0, 1.0,
+		1.0, 1.0, 1.0, 1.0,
+		1.0, 0.0, 0.0, 1.0,
+		0.0, 1.0, 0.0, 1.0,
+		0.0, 0.0, 1.0, 1.0,
+	};
+	float out_data[4 * width * height];
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height, YCBCR_INPUT_SPLIT_Y_AND_CBCR);
+	input->set_pixel_data(0, y);
+	input->set_pixel_data(1, cb_cr);
+	tester.get_chain()->add_input(input);
+
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	// Y'CbCr isn't 100% accurate (the input values are rounded),
+	// so we need some leeway.
+	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
+}
+
+TEST(YCbCrInputTest, ExternalTexture) {
+	const int width = 1;
+	const int height = 5;
+
+	// Pure-color test inputs, calculated with the formulas in Rec. 601
+	// section 2.5.4.
+	unsigned char y[width * height] = {
+		16, 235, 81, 145, 41,
+	};
+	unsigned char cb[width * height] = {
+		128, 128, 90, 54, 240,
+	};
+	unsigned char cr[width * height] = {
+		128, 128, 240, 34, 110,
+	};
+	float expected_data[4 * width * height] = {
+		0.0, 0.0, 0.0, 1.0,
+		1.0, 1.0, 1.0, 1.0,
+		1.0, 0.0, 0.0, 1.0,
+		0.0, 1.0, 0.0, 1.0,
+		0.0, 0.0, 1.0, 1.0,
+	};
+	float out_data[4 * width * height];
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	// Make a texture for the Cb data; keep the others as regular uploads.
+	ResourcePool pool;
+	GLuint cb_tex = pool.create_2d_texture(GL_R8, width, height);
+	check_error();
+	glBindTexture(GL_TEXTURE_2D, cb_tex);
+	check_error();
+	glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
+	check_error();
+	glPixelStorei(GL_UNPACK_ALIGNMENT, 1);
+	check_error();
+	glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, width, height, GL_RED, GL_UNSIGNED_BYTE, cb);
+	check_error();
+	glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
+	check_error();
+	glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
+	check_error();
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
+	input->set_pixel_data(0, y);
+	input->set_texture_num(1, cb_tex);
+	input->set_pixel_data(2, cr);
+	tester.get_chain()->add_input(input);
+
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	pool.release_2d_texture(cb_tex);
+
+	// Y'CbCr isn't 100% accurate (the input values are rounded),
+	// so we need some leeway.
+	expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
+}
+
+TEST(YCbCrTest, WikipediaRec601ForwardMatrix) {
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+
+	float offset[3];
+	Eigen::Matrix3d ycbcr_to_rgb;
+	compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb);
+
+	Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse() * 255.0;
+
+	// Values from https://en.wikipedia.org/wiki/YCbCr#ITU-R_BT.601_conversion.
+	EXPECT_NEAR(  65.481, rgb_to_ycbcr(0,0), 1e-3);
+	EXPECT_NEAR( 128.553, rgb_to_ycbcr(0,1), 1e-3);
+	EXPECT_NEAR(  24.966, rgb_to_ycbcr(0,2), 1e-3);
+
+	EXPECT_NEAR( -37.797, rgb_to_ycbcr(1,0), 1e-3);
+	EXPECT_NEAR( -74.203, rgb_to_ycbcr(1,1), 1e-3);
+	EXPECT_NEAR( 112.000, rgb_to_ycbcr(1,2), 1e-3);
+
+	EXPECT_NEAR( 112.000, rgb_to_ycbcr(2,0), 1e-3);
+	EXPECT_NEAR( -93.786, rgb_to_ycbcr(2,1), 1e-3);
+	EXPECT_NEAR( -18.214, rgb_to_ycbcr(2,2), 1e-3);
+
+	EXPECT_NEAR( 16.0, offset[0] * 255.0, 1e-3);
+	EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3);
+	EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3);
+}
+
+TEST(YCbCrTest, WikipediaJPEGMatrices) {
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = true;
+	ycbcr_format.num_levels = 256;
+
+	float offset[3];
+	Eigen::Matrix3d ycbcr_to_rgb;
+	compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb);
+
+	// Values from https://en.wikipedia.org/wiki/YCbCr#JPEG_conversion.
+	EXPECT_NEAR( 1.00000, ycbcr_to_rgb(0,0), 1e-5);
+	EXPECT_NEAR( 0.00000, ycbcr_to_rgb(0,1), 1e-5);
+	EXPECT_NEAR( 1.40200, ycbcr_to_rgb(0,2), 1e-5);
+
+	EXPECT_NEAR( 1.00000, ycbcr_to_rgb(1,0), 1e-5);
+	EXPECT_NEAR(-0.34414, ycbcr_to_rgb(1,1), 1e-5);
+	EXPECT_NEAR(-0.71414, ycbcr_to_rgb(1,2), 1e-5);
+
+	EXPECT_NEAR( 1.00000, ycbcr_to_rgb(2,0), 1e-5);
+	EXPECT_NEAR( 1.77200, ycbcr_to_rgb(2,1), 1e-5);
+	EXPECT_NEAR( 0.00000, ycbcr_to_rgb(2,2), 1e-5);
+
+	Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse();
+
+	// Same.
+	EXPECT_NEAR( 0.299000, rgb_to_ycbcr(0,0), 1e-6);
+	EXPECT_NEAR( 0.587000, rgb_to_ycbcr(0,1), 1e-6);
+	EXPECT_NEAR( 0.114000, rgb_to_ycbcr(0,2), 1e-6);
+
+	EXPECT_NEAR(-0.168736, rgb_to_ycbcr(1,0), 1e-6);
+	EXPECT_NEAR(-0.331264, rgb_to_ycbcr(1,1), 1e-6);
+	EXPECT_NEAR( 0.500000, rgb_to_ycbcr(1,2), 1e-6);
+
+	EXPECT_NEAR( 0.500000, rgb_to_ycbcr(2,0), 1e-6);
+	EXPECT_NEAR(-0.418688, rgb_to_ycbcr(2,1), 1e-6);
+	EXPECT_NEAR(-0.081312, rgb_to_ycbcr(2,2), 1e-6);
+
+	EXPECT_NEAR(  0.0, offset[0] * 255.0, 1e-3);
+	EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3);
+	EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3);
+}
+
+TEST(YCbCrTest, BlackmagicForwardMatrix) {
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_709;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+
+	float offset[3];
+	Eigen::Matrix3d ycbcr_to_rgb;
+	compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb);
+
+	Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse();
+
+	// Values from DeckLink SDK documentation.
+	EXPECT_NEAR( 0.183, rgb_to_ycbcr(0,0), 1e-3);
+	EXPECT_NEAR( 0.614, rgb_to_ycbcr(0,1), 1e-3);
+	EXPECT_NEAR( 0.062, rgb_to_ycbcr(0,2), 1e-3);
+
+	EXPECT_NEAR(-0.101, rgb_to_ycbcr(1,0), 1e-3);
+	EXPECT_NEAR(-0.338, rgb_to_ycbcr(1,1), 1e-3);
+	EXPECT_NEAR( 0.439, rgb_to_ycbcr(1,2), 1e-3);
+
+	EXPECT_NEAR( 0.439, rgb_to_ycbcr(2,0), 1e-3);
+	EXPECT_NEAR(-0.399, rgb_to_ycbcr(2,1), 1e-3);
+	EXPECT_NEAR(-0.040, rgb_to_ycbcr(2,2), 1e-3);
+
+	EXPECT_NEAR( 16.0, offset[0] * 255.0, 1e-3);
+	EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3);
+	EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3);
+}
+
+TEST(YCbCrInputTest, NoData) {
+	const int width = 1;
+	const int height = 5;
+
+	float out_data[4 * width * height];
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_601;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 256;
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
+	tester.get_chain()->add_input(input);
+
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	// Don't care what the output was, just that it does not crash.
+}
+
+TEST(YCbCrInputTest, TenBitInterleaved) {
+	const int width = 1;
+	const int height = 5;
+
+	// Pure-color inputs, calculated using formulas 3.2, 3.3 and 3.4 from
+	// Rec. 709. (Except the first two, which are obvious given the 64–940
+	// range of luminance.)
+	unsigned expanded_data[width * height * 3] = {
+                 64, 512, 512,
+                940, 512, 512,
+                250, 409, 960,
+                691, 167, 105,
+                127, 960, 471,
+	};
+	float expected_data[4 * width * height] = {
+		0.0, 0.0, 0.0, 1.0,
+		1.0, 1.0, 1.0, 1.0,
+		1.0, 0.0, 0.0, 1.0,
+		0.0, 1.0, 0.0, 1.0,
+		0.0, 0.0, 1.0, 1.0,
+	};
+	float out_data[4 * width * height];
+
+	// Pack 32:32:32 to 10:10:10:2.
+	uint32_t data[width * height];
+	for (unsigned i = 0; i < width * height; ++i) {
+		data[i] =
+			 expanded_data[i * 3 + 0]        |
+			(expanded_data[i * 3 + 1] << 10) |
+			(expanded_data[i * 3 + 2] << 20);
+	}
+
+	EffectChainTester tester(NULL, width, height);
+
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_sRGB;
+
+	YCbCrFormat ycbcr_format;
+	ycbcr_format.luma_coefficients = YCBCR_REC_709;
+	ycbcr_format.full_range = false;
+	ycbcr_format.num_levels = 1024;  // 10-bit.
+	ycbcr_format.chroma_subsampling_x = 1;
+	ycbcr_format.chroma_subsampling_y = 1;
+	ycbcr_format.cb_x_position = 0.5f;
+	ycbcr_format.cb_y_position = 0.5f;
+	ycbcr_format.cr_x_position = 0.5f;
+	ycbcr_format.cr_y_position = 0.5f;
+
+	YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height, YCBCR_INPUT_INTERLEAVED, GL_UNSIGNED_INT_2_10_10_10_REV);
+	input->set_pixel_data(0, data);
+	tester.get_chain()->add_input(input);
+
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	// We can set much tighter limits on this than 8-bit Y'CbCr;
+	// even tighter than the default limits.
+	expect_equal(expected_data, out_data, 4 * width, height, 0.002, 0.0003);
+}
+
+}  // namespace movit