X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=ycbcr_input_test.cpp;h=a5032af657de73935aabaef79983b3d7603a28c7;hp=4beaaa33cb53d013f4319ed57698d1257be4ee6c;hb=f216b7bef5a968c89f6fc78e83cc26a91e504a8a;hpb=9651a4eaae012cdc49c1aa38197861e04f62e91e diff --git a/ycbcr_input_test.cpp b/ycbcr_input_test.cpp index 4beaaa3..a5032af 100644 --- a/ycbcr_input_test.cpp +++ b/ycbcr_input_test.cpp @@ -1,16 +1,21 @@ -// Unit tests for YCbCrInput. -// FIXME: This class really ought to support mipmaps. +// Unit tests for YCbCrInput. Also tests the matrix functions in ycbcr.cpp directly. -#include +#include #include +#include +#include + #include "effect_chain.h" #include "gtest/gtest.h" #include "test_util.h" #include "util.h" +#include "resource_pool.h" #include "ycbcr_input.h" -TEST(YCbCrInput, Simple444) { +namespace movit { + +TEST(YCbCrInputTest, Simple444) { const int width = 1; const int height = 5; @@ -43,6 +48,7 @@ TEST(YCbCrInput, Simple444) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_601; ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 1; ycbcr_format.chroma_subsampling_y = 1; ycbcr_format.cb_x_position = 0.5f; @@ -63,7 +69,7 @@ TEST(YCbCrInput, Simple444) { expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002); } -TEST(YCbCrInput, FullRangeRec601) { +TEST(YCbCrInputTest, FullRangeRec601) { const int width = 1; const int height = 5; @@ -97,6 +103,7 @@ TEST(YCbCrInput, FullRangeRec601) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_601; ycbcr_format.full_range = true; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 1; ycbcr_format.chroma_subsampling_y = 1; ycbcr_format.cb_x_position = 0.5f; @@ -117,7 +124,7 @@ TEST(YCbCrInput, FullRangeRec601) { expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002); } -TEST(YCbCrInput, Rec709) { +TEST(YCbCrInputTest, Rec709) { const int width = 1; const int height = 5; @@ -150,6 +157,7 @@ TEST(YCbCrInput, Rec709) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_709; ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 1; ycbcr_format.chroma_subsampling_y = 1; ycbcr_format.cb_x_position = 0.5f; @@ -170,7 +178,7 @@ TEST(YCbCrInput, Rec709) { expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002); } -TEST(YCbCrInput, Rec2020) { +TEST(YCbCrInputTest, Rec2020) { const int width = 1; const int height = 5; @@ -205,6 +213,7 @@ TEST(YCbCrInput, Rec2020) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_2020; ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 1; ycbcr_format.chroma_subsampling_y = 1; ycbcr_format.cb_x_position = 0.5f; @@ -225,7 +234,7 @@ TEST(YCbCrInput, Rec2020) { expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002); } -TEST(YCbCrInput, Subsampling420) { +TEST(YCbCrInputTest, Subsampling420) { const int width = 4; const int height = 4; @@ -266,6 +275,7 @@ TEST(YCbCrInput, Subsampling420) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_601; ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 2; ycbcr_format.chroma_subsampling_y = 2; ycbcr_format.cb_x_position = 0.5f; @@ -286,7 +296,7 @@ TEST(YCbCrInput, Subsampling420) { expect_equal(expected_data, out_data, width, height, 0.01, 0.001); } -TEST(YCbCrInput, Subsampling420WithNonCenteredSamples) { +TEST(YCbCrInputTest, Subsampling420WithNonCenteredSamples) { const int width = 4; const int height = 4; @@ -327,6 +337,7 @@ TEST(YCbCrInput, Subsampling420WithNonCenteredSamples) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_601; ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 2; ycbcr_format.chroma_subsampling_y = 2; ycbcr_format.cb_x_position = 0.0f; @@ -344,11 +355,11 @@ TEST(YCbCrInput, Subsampling420WithNonCenteredSamples) { // Y'CbCr isn't 100% accurate (the input values are rounded), // so we need some leeway. - expect_equal(expected_data, out_data, width, height, 0.01, 0.001); + expect_equal(expected_data, out_data, width, height, 0.01, 0.0012); } // Yes, some 4:2:2 formats actually have this craziness. -TEST(YCbCrInput, DifferentCbAndCrPositioning) { +TEST(YCbCrInputTest, DifferentCbAndCrPositioning) { const int width = 4; const int height = 4; @@ -396,6 +407,7 @@ TEST(YCbCrInput, DifferentCbAndCrPositioning) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_601; ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 2; ycbcr_format.chroma_subsampling_y = 1; ycbcr_format.cb_x_position = 0.0f; @@ -418,7 +430,7 @@ TEST(YCbCrInput, DifferentCbAndCrPositioning) { expect_equal(expected_data_blue, out_data, width, height, 0.01, 0.001); } -TEST(YCbCrInput, PBO) { +TEST(YCbCrInputTest, PBO) { const int width = 1; const int height = 5; @@ -453,6 +465,7 @@ TEST(YCbCrInput, PBO) { YCbCrFormat ycbcr_format; ycbcr_format.luma_coefficients = YCBCR_REC_601; ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; ycbcr_format.chroma_subsampling_x = 1; ycbcr_format.chroma_subsampling_y = 1; ycbcr_format.cb_x_position = 0.5f; @@ -474,3 +487,236 @@ TEST(YCbCrInput, PBO) { glDeleteBuffers(1, &pbo); } + +TEST(YCbCrInputTest, CombinedCbAndCr) { + const int width = 1; + const int height = 5; + + // Pure-color test inputs, calculated with the formulas in Rec. 601 + // section 2.5.4. + unsigned char y[width * height] = { + 16, 235, 81, 145, 41, + }; + unsigned char cb_cr[width * height * 2] = { + 128, 128, + 128, 128, + 90, 240, + 54, 34, + 240, 110, + }; + float expected_data[4 * width * height] = { + 0.0, 0.0, 0.0, 1.0, + 1.0, 1.0, 1.0, 1.0, + 1.0, 0.0, 0.0, 1.0, + 0.0, 1.0, 0.0, 1.0, + 0.0, 0.0, 1.0, 1.0, + }; + float out_data[4 * width * height]; + + EffectChainTester tester(NULL, width, height); + + ImageFormat format; + format.color_space = COLORSPACE_sRGB; + format.gamma_curve = GAMMA_sRGB; + + YCbCrFormat ycbcr_format; + ycbcr_format.luma_coefficients = YCBCR_REC_601; + ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; + ycbcr_format.chroma_subsampling_x = 1; + ycbcr_format.chroma_subsampling_y = 1; + ycbcr_format.cb_x_position = 0.5f; + ycbcr_format.cb_y_position = 0.5f; + ycbcr_format.cr_x_position = 0.5f; + ycbcr_format.cr_y_position = 0.5f; + + YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height, YCBCR_INPUT_SPLIT_Y_AND_CBCR); + input->set_pixel_data(0, y); + input->set_pixel_data(1, cb_cr); + tester.get_chain()->add_input(input); + + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB); + + // Y'CbCr isn't 100% accurate (the input values are rounded), + // so we need some leeway. + expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002); +} + +TEST(YCbCrInputTest, ExternalTexture) { + const int width = 1; + const int height = 5; + + // Pure-color test inputs, calculated with the formulas in Rec. 601 + // section 2.5.4. + unsigned char y[width * height] = { + 16, 235, 81, 145, 41, + }; + unsigned char cb[width * height] = { + 128, 128, 90, 54, 240, + }; + unsigned char cr[width * height] = { + 128, 128, 240, 34, 110, + }; + float expected_data[4 * width * height] = { + 0.0, 0.0, 0.0, 1.0, + 1.0, 1.0, 1.0, 1.0, + 1.0, 0.0, 0.0, 1.0, + 0.0, 1.0, 0.0, 1.0, + 0.0, 0.0, 1.0, 1.0, + }; + float out_data[4 * width * height]; + + EffectChainTester tester(NULL, width, height); + + ImageFormat format; + format.color_space = COLORSPACE_sRGB; + format.gamma_curve = GAMMA_sRGB; + + YCbCrFormat ycbcr_format; + ycbcr_format.luma_coefficients = YCBCR_REC_601; + ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; + ycbcr_format.chroma_subsampling_x = 1; + ycbcr_format.chroma_subsampling_y = 1; + ycbcr_format.cb_x_position = 0.5f; + ycbcr_format.cb_y_position = 0.5f; + ycbcr_format.cr_x_position = 0.5f; + ycbcr_format.cr_y_position = 0.5f; + + // Make a texture for the Cb data; keep the others as regular uploads. + ResourcePool pool; + GLuint cb_tex = pool.create_2d_texture(GL_R8, width, height); + check_error(); + glBindTexture(GL_TEXTURE_2D, cb_tex); + check_error(); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); + check_error(); + glPixelStorei(GL_UNPACK_ALIGNMENT, 1); + check_error(); + glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, width, height, GL_RED, GL_UNSIGNED_BYTE, cb); + check_error(); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); + check_error(); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); + check_error(); + + YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height); + input->set_pixel_data(0, y); + input->set_texture_num(1, cb_tex); + input->set_pixel_data(2, cr); + tester.get_chain()->add_input(input); + + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB); + + pool.release_2d_texture(cb_tex); + + // Y'CbCr isn't 100% accurate (the input values are rounded), + // so we need some leeway. + expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002); +} + +TEST(YCbCrTest, WikipediaRec601ForwardMatrix) { + YCbCrFormat ycbcr_format; + ycbcr_format.luma_coefficients = YCBCR_REC_601; + ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; + + float offset[3]; + Eigen::Matrix3d ycbcr_to_rgb; + compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb); + + Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse() * 255.0; + + // Values from https://en.wikipedia.org/wiki/YCbCr#ITU-R_BT.601_conversion. + EXPECT_NEAR( 65.481, rgb_to_ycbcr(0,0), 1e-3); + EXPECT_NEAR( 128.553, rgb_to_ycbcr(0,1), 1e-3); + EXPECT_NEAR( 24.966, rgb_to_ycbcr(0,2), 1e-3); + + EXPECT_NEAR( -37.797, rgb_to_ycbcr(1,0), 1e-3); + EXPECT_NEAR( -74.203, rgb_to_ycbcr(1,1), 1e-3); + EXPECT_NEAR( 112.000, rgb_to_ycbcr(1,2), 1e-3); + + EXPECT_NEAR( 112.000, rgb_to_ycbcr(2,0), 1e-3); + EXPECT_NEAR( -93.786, rgb_to_ycbcr(2,1), 1e-3); + EXPECT_NEAR( -18.214, rgb_to_ycbcr(2,2), 1e-3); + + EXPECT_NEAR( 16.0, offset[0] * 255.0, 1e-3); + EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3); + EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3); +} + +TEST(YCbCrTest, WikipediaJPEGMatrices) { + YCbCrFormat ycbcr_format; + ycbcr_format.luma_coefficients = YCBCR_REC_601; + ycbcr_format.full_range = true; + ycbcr_format.num_levels = 256; + + float offset[3]; + Eigen::Matrix3d ycbcr_to_rgb; + compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb); + + // Values from https://en.wikipedia.org/wiki/YCbCr#JPEG_conversion. + EXPECT_NEAR( 1.00000, ycbcr_to_rgb(0,0), 1e-5); + EXPECT_NEAR( 0.00000, ycbcr_to_rgb(0,1), 1e-5); + EXPECT_NEAR( 1.40200, ycbcr_to_rgb(0,2), 1e-5); + + EXPECT_NEAR( 1.00000, ycbcr_to_rgb(1,0), 1e-5); + EXPECT_NEAR(-0.34414, ycbcr_to_rgb(1,1), 1e-5); + EXPECT_NEAR(-0.71414, ycbcr_to_rgb(1,2), 1e-5); + + EXPECT_NEAR( 1.00000, ycbcr_to_rgb(2,0), 1e-5); + EXPECT_NEAR( 1.77200, ycbcr_to_rgb(2,1), 1e-5); + EXPECT_NEAR( 0.00000, ycbcr_to_rgb(2,2), 1e-5); + + Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse(); + + // Same. + EXPECT_NEAR( 0.299000, rgb_to_ycbcr(0,0), 1e-6); + EXPECT_NEAR( 0.587000, rgb_to_ycbcr(0,1), 1e-6); + EXPECT_NEAR( 0.114000, rgb_to_ycbcr(0,2), 1e-6); + + EXPECT_NEAR(-0.168736, rgb_to_ycbcr(1,0), 1e-6); + EXPECT_NEAR(-0.331264, rgb_to_ycbcr(1,1), 1e-6); + EXPECT_NEAR( 0.500000, rgb_to_ycbcr(1,2), 1e-6); + + EXPECT_NEAR( 0.500000, rgb_to_ycbcr(2,0), 1e-6); + EXPECT_NEAR(-0.418688, rgb_to_ycbcr(2,1), 1e-6); + EXPECT_NEAR(-0.081312, rgb_to_ycbcr(2,2), 1e-6); + + EXPECT_NEAR( 0.0, offset[0] * 255.0, 1e-3); + EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3); + EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3); +} + +TEST(YCbCrInputTest, NoData) { + const int width = 1; + const int height = 5; + + float out_data[4 * width * height]; + + EffectChainTester tester(NULL, width, height); + + ImageFormat format; + format.color_space = COLORSPACE_sRGB; + format.gamma_curve = GAMMA_sRGB; + + YCbCrFormat ycbcr_format; + ycbcr_format.luma_coefficients = YCBCR_REC_601; + ycbcr_format.full_range = false; + ycbcr_format.num_levels = 256; + ycbcr_format.chroma_subsampling_x = 1; + ycbcr_format.chroma_subsampling_y = 1; + ycbcr_format.cb_x_position = 0.5f; + ycbcr_format.cb_y_position = 0.5f; + ycbcr_format.cr_x_position = 0.5f; + ycbcr_format.cr_y_position = 0.5f; + + YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height); + tester.get_chain()->add_input(input); + + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB); + + // Don't care what the output was, just that it does not crash. +} + +} // namespace movit