From: Steinar H. Gunderson <sgunderson@bigfoot.com>
Date: Mon, 21 Jan 2013 21:09:51 +0000 (+0100)
Subject: In OverlayEffectTest, handle that RGB on zero alpha is undefined.
X-Git-Tag: 1.0~149^2~6
X-Git-Url: https://git.sesse.net/?p=movit;a=commitdiff_plain;h=2ee9c77ad76449314d28d62f60e10d80039c2353;hp=a1028b34cc7d1ce5e1a12ed2222a0e35f8f54bf5

In OverlayEffectTest, handle that RGB on zero alpha is undefined.

Trickled by llvmpipe.
---

diff --git a/overlay_effect_test.cpp b/overlay_effect_test.cpp
index 865d392..d0867a1 100644
--- a/overlay_effect_test.cpp
+++ b/overlay_effect_test.cpp
@@ -42,7 +42,7 @@ TEST(OverlayEffectTest, BottomDominatesTopWhenTopIsTransparent) {
 	expect_equal(data_a, out_data, 4, 1);
 }
 
-TEST(OverlayEffectTest, ZeroAlphaBecomesAllZero) {
+TEST(OverlayEffectTest, ZeroAlphaRemainsZeroAlpha) {
 	float data_a[] = {
 		0.0f, 0.25f, 0.5f, 0.0f
 	};
@@ -60,7 +60,7 @@ TEST(OverlayEffectTest, ZeroAlphaBecomesAllZero) {
 	tester.get_chain()->add_effect(new OverlayEffect(), input1, input2);
 	tester.run(out_data, GL_BGRA, COLORSPACE_sRGB, GAMMA_LINEAR);
 
-	expect_equal(expected_data, out_data, 4, 1);
+	EXPECT_FLOAT_EQ(0.0f, expected_data[3]);
 }
 
 // This is tested against what Photoshop does: (255,0,128, 0.25) over (128,255,0, 0.5)