From: Steinar H. Gunderson <sgunderson@bigfoot.com>
Date: Mon, 13 Mar 2017 22:32:36 +0000 (+0100)
Subject: Add an explanatory comment about dither with 16-bit output.
X-Git-Tag: 1.5.0~2
X-Git-Url: https://git.sesse.net/?p=movit;a=commitdiff_plain;h=4f52c8e16cc4d99da79d384f45f5b3a6fab40d87

Add an explanatory comment about dither with 16-bit output.
---

diff --git a/effect_chain.h b/effect_chain.h
index b753ad4..6a65399 100644
--- a/effect_chain.h
+++ b/effect_chain.h
@@ -294,6 +294,11 @@ public:
 
 	// Set number of output bits, to scale the dither.
 	// 8 is the right value for most outputs.
+	//
+	// Special note for 10- and 12-bit Y'CbCr packed into GL_UNSIGNED_SHORT:
+	// This is relative to the actual output, not the logical one, so you should
+	// specify 16 here, not 10 or 12.
+	//
 	// The default, 0, is a special value that means no dither.
 	void set_dither_bits(unsigned num_bits)
 	{