From 2ee9c77ad76449314d28d62f60e10d80039c2353 Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Mon, 21 Jan 2013 22:09:51 +0100 Subject: [PATCH 1/1] In OverlayEffectTest, handle that RGB on zero alpha is undefined. Trickled by llvmpipe. --- overlay_effect_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/overlay_effect_test.cpp b/overlay_effect_test.cpp index 865d392..d0867a1 100644 --- a/overlay_effect_test.cpp +++ b/overlay_effect_test.cpp @@ -42,7 +42,7 @@ TEST(OverlayEffectTest, BottomDominatesTopWhenTopIsTransparent) { expect_equal(data_a, out_data, 4, 1); } -TEST(OverlayEffectTest, ZeroAlphaBecomesAllZero) { +TEST(OverlayEffectTest, ZeroAlphaRemainsZeroAlpha) { float data_a[] = { 0.0f, 0.25f, 0.5f, 0.0f }; @@ -60,7 +60,7 @@ TEST(OverlayEffectTest, ZeroAlphaBecomesAllZero) { tester.get_chain()->add_effect(new OverlayEffect(), input1, input2); tester.run(out_data, GL_BGRA, COLORSPACE_sRGB, GAMMA_LINEAR); - expect_equal(expected_data, out_data, 4, 1); + EXPECT_FLOAT_EQ(0.0f, expected_data[3]); } // This is tested against what Photoshop does: (255,0,128, 0.25) over (128,255,0, 0.5) -- 2.39.2