From cc9e1cb1ba6a09b38b5e59ccab817a97dd49ca98 Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Tue, 6 Nov 2012 01:30:30 +0100 Subject: [PATCH] Make the ResampleEffect minimum tolerated error smaller; I could really see some artifacts when looking hard. --- resample_effect.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/resample_effect.cpp b/resample_effect.cpp index e1e6199..5ab0468 100644 --- a/resample_effect.cpp +++ b/resample_effect.cpp @@ -74,9 +74,12 @@ unsigned combine_samples(float *src, float *dst, unsigned num_src_samples, unsig float offset, total_weight, sum_sq_error; combine_two_samples(w1, w2, &offset, &total_weight, &sum_sq_error); - // If the interpolation error is larger than that of one level - // at 8-bit precision, don't combine. - if (sum_sq_error > 1.0f / (256.0f * 256.0f)) { + // If the interpolation error is larger than that of about sqrt(2) of + // a level at 8-bit precision, don't combine. (You'd think 1.0 was enough, + // but since the artifacts are not really random, they can get quite + // visible. On the other hand, going to 0.25f, I can see no change at + // all with 8-bit output, so it would not seem to be worth it.) + if (sum_sq_error > 0.5f / (256.0f * 256.0f)) { continue; } -- 2.39.2