]> git.sesse.net Git - nageru/commitdiff
Fix a Qt deprecation on pixmap().
authorSteinar H. Gunderson <sgunderson@bigfoot.com>
Mon, 5 Apr 2021 15:51:51 +0000 (17:51 +0200)
committerSteinar H. Gunderson <sgunderson@bigfoot.com>
Mon, 5 Apr 2021 15:51:51 +0000 (17:51 +0200)
nageru/analyzer.cpp

index b08af1926f0165adcb85faebf97f20d001c06fbd..f2d3ae699cf8a0d1e12ca4394f23aac2f95e0197 100644 (file)
@@ -267,25 +267,23 @@ bool Analyzer::eventFilter(QObject *watched, QEvent *event)
 
 void Analyzer::grab_pixel(int x, int y)
 {
-       const QPixmap *pixmap = ui->grabbed_frame_label->pixmap();
-       if (pixmap != nullptr) {
-               x = lrint(x * double(pixmap->width()) / ui->grabbed_frame_label->width());
-               y = lrint(y * double(pixmap->height()) / ui->grabbed_frame_label->height());
-               x = std::min(x, pixmap->width() - 1);
-               y = std::min(y, pixmap->height() - 1);
-
-               char buf[256];
-               snprintf(buf, sizeof(buf), "Selected coordinate (x,y): (%d,%d)", x, y);
-               ui->coord_label->setText(buf);
-
-               QRgb pixel = grabbed_image.pixel(x, y);
-               ui->red_label->setText(QString::fromStdString(to_string(qRed(pixel))));
-               ui->green_label->setText(QString::fromStdString(to_string(qGreen(pixel))));
-               ui->blue_label->setText(QString::fromStdString(to_string(qBlue(pixel))));
-
-               snprintf(buf, sizeof(buf), "#%02x%02x%02x", qRed(pixel), qGreen(pixel), qBlue(pixel));
-               ui->hex_label->setText(buf);
-       }
+       QPixmap pixmap = ui->grabbed_frame_label->pixmap(Qt::ReturnByValue);
+       x = lrint(x * double(pixmap.width()) / ui->grabbed_frame_label->width());
+       y = lrint(y * double(pixmap.height()) / ui->grabbed_frame_label->height());
+       x = std::min(x, pixmap.width() - 1);
+       y = std::min(y, pixmap.height() - 1);
+
+       char buf[256];
+       snprintf(buf, sizeof(buf), "Selected coordinate (x,y): (%d,%d)", x, y);
+       ui->coord_label->setText(buf);
+
+       QRgb pixel = grabbed_image.pixel(x, y);
+       ui->red_label->setText(QString::fromStdString(to_string(qRed(pixel))));
+       ui->green_label->setText(QString::fromStdString(to_string(qGreen(pixel))));
+       ui->blue_label->setText(QString::fromStdString(to_string(qBlue(pixel))));
+
+       snprintf(buf, sizeof(buf), "#%02x%02x%02x", qRed(pixel), qGreen(pixel), qBlue(pixel));
+       ui->hex_label->setText(buf);
 }
 
 void Analyzer::resizeEvent(QResizeEvent* event)