]> git.sesse.net Git - nageru/commitdiff
Add a concurrency TODO on RefCountedFrame.
authorSteinar H. Gunderson <sgunderson@bigfoot.com>
Sat, 21 Apr 2018 09:36:42 +0000 (11:36 +0200)
committerSteinar H. Gunderson <sgunderson@bigfoot.com>
Sat, 21 Apr 2018 09:36:42 +0000 (11:36 +0200)
ref_counted_frame.h

index cb055f9e3a62ea49bf8d8a963d2aa8b07ea87ef5..59a16869c38fa923a639a56eca679b22b3eb871f 100644 (file)
@@ -6,6 +6,13 @@
 //
 // Note that the important point isn't really the pointer to the Frame itself,
 // it's the resources it's representing that need to go back to the allocator.
+//
+// FIXME: There's an issue here in that we could be releasing a frame while
+// we're still uploading textures from it, causing it to be written to in
+// another thread. (Thankfully, it goes to the back of the queue, and there's
+// usually a render in-between, meaning it's fairly unlikely that someone
+// actually managed to get to that race.) We should probably have some mechanism
+// for registering fences.
 
 #include <memory>