From: Steinar H. Gunderson <sgunderson@bigfoot.com>
Date: Tue, 4 Dec 2018 23:40:11 +0000 (+0100)
Subject: Stop setting nobuffer for FFmpeg inputs; it seems it only really affects buffering... 
X-Git-Tag: 1.8.0~54
X-Git-Url: https://git.sesse.net/?p=nageru;a=commitdiff_plain;h=bb709f382e8b7a5a8856c4ff736c6106c9e1f3e7

Stop setting nobuffer for FFmpeg inputs; it seems it only really affects buffering during probing, and messes up probing of some colorspace information permanently.
---

diff --git a/nageru/ffmpeg_capture.cpp b/nageru/ffmpeg_capture.cpp
index 7081da8..e5cb096 100644
--- a/nageru/ffmpeg_capture.cpp
+++ b/nageru/ffmpeg_capture.cpp
@@ -365,10 +365,7 @@ bool FFmpegCapture::play_video(const string &pathname)
 		last_modified = buf.st_mtim;
 	}
 
-	AVDictionary *opts = nullptr;
-	av_dict_set(&opts, "fflags", "nobuffer", 0);
-
-	auto format_ctx = avformat_open_input_unique(pathname.c_str(), nullptr, &opts, AVIOInterruptCB{ &FFmpegCapture::interrupt_cb_thunk, this });
+	auto format_ctx = avformat_open_input_unique(pathname.c_str(), nullptr, nullptr, AVIOInterruptCB{ &FFmpegCapture::interrupt_cb_thunk, this });
 	if (format_ctx == nullptr) {
 		fprintf(stderr, "%s: Error opening file\n", pathname.c_str());
 		return false;