From 1f93a39a1f20eb7481134245f4cdc849976c29db Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Mon, 12 Jun 2017 22:33:29 +0200 Subject: [PATCH] Expose a metric for Nageru being stalled on the Quick Sync encoder. --- quicksync_encoder.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/quicksync_encoder.cpp b/quicksync_encoder.cpp index a0b3876..0c9cf06 100644 --- a/quicksync_encoder.cpp +++ b/quicksync_encoder.cpp @@ -68,10 +68,11 @@ namespace { // These need to survive several QuickSyncEncoderImpl instances, // so they are outside. -bool mux_metrics_inited = false; +bool quick_sync_metrics_inited = false; LatencyHistogram mixer_latency_histogram, qs_latency_histogram; MuxMetrics current_file_mux_metrics, total_mux_metrics; std::atomic metric_current_file_start_time_seconds{0.0 / 0.0}; +std::atomic metric_quick_sync_stalled_frames{0}; } // namespace @@ -1572,13 +1573,14 @@ QuickSyncEncoderImpl::QuickSyncEncoderImpl(const std::string &filename, Resource memset(&slice_param, 0, sizeof(slice_param)); } - if (!mux_metrics_inited) { + if (!quick_sync_metrics_inited) { mixer_latency_histogram.init("mixer"); qs_latency_histogram.init("quick_sync"); current_file_mux_metrics.init({{ "destination", "current_file" }}); total_mux_metrics.init({{ "destination", "files_total" }}); global_metrics.add("current_file_start_time_seconds", &metric_current_file_start_time_seconds, Metrics::TYPE_GAUGE); - mux_metrics_inited = true; + global_metrics.add("quick_sync_stalled_frames", &metric_quick_sync_stalled_frames); + quick_sync_metrics_inited = true; } storage_thread = thread(&QuickSyncEncoderImpl::storage_task_thread, this); @@ -1640,6 +1642,7 @@ bool QuickSyncEncoderImpl::begin_frame(int64_t pts, int64_t duration, YCbCrLumaC if (surf == nullptr) { fprintf(stderr, "Warning: No free slots for frame %d, rendering has to wait for H.264 encoder\n", current_storage_frame); + ++metric_quick_sync_stalled_frames; storage_task_queue_changed.wait(lock, [this, &surf]{ if (storage_thread_should_quit) return true; -- 2.39.2