From c93d7e2565efe3196962b70988fe0d92e3d264fb Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Sat, 21 Apr 2018 11:36:42 +0200 Subject: [PATCH] Add a concurrency TODO on RefCountedFrame. --- ref_counted_frame.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ref_counted_frame.h b/ref_counted_frame.h index cb055f9..59a1686 100644 --- a/ref_counted_frame.h +++ b/ref_counted_frame.h @@ -6,6 +6,13 @@ // // Note that the important point isn't really the pointer to the Frame itself, // it's the resources it's representing that need to go back to the allocator. +// +// FIXME: There's an issue here in that we could be releasing a frame while +// we're still uploading textures from it, causing it to be written to in +// another thread. (Thankfully, it goes to the back of the queue, and there's +// usually a render in-between, meaning it's fairly unlikely that someone +// actually managed to get to that race.) We should probably have some mechanism +// for registering fences. #include -- 2.39.2