# use Image::Info;
use Image::ExifTool;
use HTML::Entities;
+use URI::Escape;
BEGIN {
use Exporter ();
require Sesse::pr0n::Config_local;
};
- $VERSION = "v2.30";
+ $VERSION = "v2.41";
@ISA = qw(Exporter);
@EXPORT = qw(&error &dberror);
%EXPORT_TAGS = qw();
while (my ($key, $value) = each %$param) {
next unless defined($value);
next if (defined($defparam->{$key}) && $value == $defparam->{$key});
+
+ $value = pretty_escape($value);
$str .= ($first) ? "?" : ';';
$str .= "$key=$value";
}
return $str;
}
+
+sub pretty_escape {
+ my $value = shift;
+
+ $value = URI::Escape::uri_escape($value);
+
+ # Unescape a few for prettiness (we'll need something for a real _, though)
+ $value =~ s/%20/_/g;
+ $value =~ s/%2F/\//g;
+
+ return $value;
+}
+
+sub pretty_unescape {
+ my $value = shift;
+
+ # URI unescaping is already done for us
+ $value =~ s/_/ /g;
+
+ return $value;
+}
sub print_link {
my ($r, $title, $baseurl, $param, $defparam, $accesskey) = @_;
my ($r, $id, $width, $height) = @_;
# Also find the date taken if appropriate (from the EXIF tag etc.)
- my $info = Image::ExifTool::ImageInfo(get_disk_location($r, $id));
+ my $exiftool = Image::ExifTool->new;
+ $exiftool->ExtractInfo(get_disk_location($r, $id));
+ my $info = $exiftool->GetInfo();
my $datetime = undef;
if (defined($info->{'DateTimeOriginal'})) {
undef, $width, $height, $datetime, $id)
or die "Couldn't update width/height in SQL: $!";
+ # EXIF information
$dbh->do('DELETE FROM exif_info WHERE image=?',
undef, $id)
or die "Couldn't delete old EXIF information in SQL: $!";
- my $q = $dbh->prepare('INSERT INTO exif_info (image,tag,value) VALUES (?,?,?)')
+ my $q = $dbh->prepare('INSERT INTO exif_info (image,key,value) VALUES (?,?,?)')
or die "Couldn't prepare inserting EXIF information: $!";
for my $key (keys %$info) {
or die "Couldn't insert EXIF information in database: $!";
}
+ # Tags
+ my @tags = $exiftool->GetValue('Keywords', 'ValueConv');
+ $dbh->do('DELETE FROM tags WHERE image=?',
+ undef, $id)
+ or die "Couldn't delete old tag information in SQL: $!";
+
+ my $q = $dbh->prepare('INSERT INTO tags (image,tag) VALUES (?,?)')
+ or die "Couldn't prepare inserting tag information: $!";
+
+ for my $tag (@tags) {
+ $q->execute($id, guess_charset($tag))
+ or die "Couldn't insert tag information in database: $!";
+ }
+
# update the last_picture cache as well (this should of course be done
# via a trigger, but this is less complicated :-) )
- $dbh->do('UPDATE last_picture_cache SET last_picture=GREATEST(last_picture, ?) WHERE event=(SELECT event FROM images WHERE id=?)',
+ $dbh->do('UPDATE last_picture_cache SET last_picture=GREATEST(last_picture, ?) WHERE (vhost,event)=(SELECT vhost,event FROM images WHERE id=?)',
undef, $datetime, $id)
or die "Couldn't update last_picture in SQL: $!";
}
# Need to generate the cache; read in the image
my $magick = new Image::Magick;
my $info = Image::ExifTool::ImageInfo($fname);
-
- # NEF files aren't autodetected
- $fname = "NEF:$fname" if ($filename =~ /\.nef$/i);
+ my $err;
+
+ # ImageMagick can handle NEF files, but it does it by calling dcraw as a delegate.
+ # The delegate support is rather broken and causes very odd stuff to happen when
+ # more than one thread does this at the same time. Thus, we simply do it ourselves.
+ if ($filename =~ /\.nef$/) {
+ # this would suffice if ImageMagick gets to fix their handling
+ # $fname = "NEF:$fname";
+
+ open DCRAW, "-|", "dcraw", "-w", "-c", $fname
+ or error("dcraw: $!");
+ $err = $magick->Read(file => \*DCRAW);
+ close(DCRAW);
+ } else {
+ $err = $magick->Read($fname);
+ }
- my $err = $magick->Read($fname);
if ($err) {
$r->log->warn("$fname: $err");
$err =~ /(\d+)/;
# Use lanczos (sharper) for heavy scaling, mitchell (faster) otherwise
my $filter = 'Mitchell';
my $quality = 90;
+ my $sf = undef;
if ($width / $nwidth > 8.0 || $height / $nheight > 8.0) {
$filter = 'Lanczos';
- $quality = 80;
+ $quality = 85;
+ $sf = "1x1";
}
if ($xres != -1) {
# Strip EXIF tags etc.
$cimg->Strip();
- if (($nwidth >= 640 && $nheight >= 480) ||
- ($nwidth >= 480 && $nheight >= 640)) {
- $err = $cimg->write(filename=>$cachename, quality=>$quality, interlace=>'Plane');
- } else {
- $err = $cimg->write(filename=>$cachename, quality=>$quality);
+ {
+ my %parms = (
+ filename => $cachename,
+ quality => $quality
+ );
+ if (($nwidth >= 640 && $nheight >= 480) ||
+ ($nwidth >= 480 && $nheight >= 640)) {
+ $parms{'interlace'} = 'Plane';
+ }
+ if (defined($sf)) {
+ $parms{'sampling-factor'} = $sf;
+ }
+ $err = $cimg->write(%parms);
}
undef $cimg;
return @errors;
}
- $dbh->do("INSERT INTO events (id,date,name,vhost) VALUES (?,?,?,?)",
+ $dbh->do("INSERT INTO events (event,date,name,vhost) VALUES (?,?,?,?)",
undef, $id, $date, $desc, $vhost)
or return ("Kunne ikke sette inn ny hendelse" . $dbh->errstr);
- $dbh->do("INSERT INTO last_picture_cache (event,last_picture) VALUES (?,NULL)",
- undef, $id)
+ $dbh->do("INSERT INTO last_picture_cache (vhost,event,last_picture) VALUES (?,?,NULL)",
+ undef, $vhost, $id)
or return ("Kunne ikke sette inn ny cache-rad" . $dbh->errstr);
return ();
projects / pr0n / blobdiff