]> git.sesse.net Git - pr0n/blobdiff - perl/Sesse/pr0n/Index.pm
Trim the EXIF values; seems like the Pentax K10D sometimes adds extra spaces
[pr0n] / perl / Sesse / pr0n / Index.pm
index f8f44048ff385a6bdfaa3ed5f506b84fcd8d0f7f..5a635d4c190aac8a5fff7e9fc3a05c1ae4aa25b8 100644 (file)
@@ -155,14 +155,16 @@ sub handler {
                
                # Find the equipment used
                my $eq = $dbh->prepare('
-                       SELECT DISTINCT
-                               model.value AS model,
-                               coalesce(lens_spec.value, lens.value) AS lens
+                       SELECT 
+                               TRIM(model.value) AS model,
+                               coalesce(TRIM(lens_spec.value), TRIM(lens.value)) AS lens,
+                               COUNT(*) AS num
                        FROM images i
                                LEFT JOIN exif_info model ON i.id=model.image
                                LEFT JOIN ( SELECT * FROM exif_info WHERE tag=\'Lens\' ) lens ON i.id=lens.image
                                LEFT JOIN ( SELECT * FROM exif_info WHERE tag=\'LensSpec\') lens_spec ON i.id=lens_spec.image
                        WHERE event=? AND model.tag=\'Model\'
+                       GROUP BY 1,2
                        ORDER BY 1,2')
                        or die "Couldn't prepare to find equipment: $!";
                $eq->execute($event)
@@ -175,8 +177,9 @@ sub handler {
                                #
                                # Some compact cameras seem to add lens info sometimes and not at other
                                # times; if we have seen a camera with at least one specific lens earlier,
-                               # just ignore entries without a lens.
+                               # just combine entries without a lens with the previous one.
                                #
+                               $equipment[$#equipment]->{'num'} += $ref->{'num'};
                                next;
                        }
                        push @equipment, $ref;
@@ -187,11 +190,14 @@ sub handler {
                if (scalar @equipment > 0) {
                        Sesse::pr0n::Templates::print_template($r, "equipment-start");
                        for my $e (@equipment) {
-                               $r->print("  <li>" . $e->{'model'});
-                               if (defined($e->{'lens'})) {
-                                       $r->print(", " . $e->{'lens'} . "</li>\n");
+                               my $eqspec = $e->{'model'};
+                               $eqspec .= ', ' . $e->{'lens'} if (defined($e->{'lens'}));
+
+                               # This isn't correct for all languages. Fix if we ever need to care. :-)
+                               if ($e->{'num'} == 1) {
+                                       Sesse::pr0n::Templates::print_template($r, "equipment-item-singular", { eqspec => $eqspec });
                                } else {
-                                       $r->print("</li>\n");
+                                       Sesse::pr0n::Templates::print_template($r, "equipment-item", { eqspec => $eqspec, num => $e->{'num'} });
                                }
                        }
                        Sesse::pr0n::Templates::print_template($r, "equipment-end");