X-Git-Url: https://git.sesse.net/?p=pr0n;a=blobdiff_plain;f=perl%2FSesse%2Fpr0n%2FCommon.pm;h=0b2fa2488f1df4e7e3e463e015d6db0a13a4663e;hp=c6f1c5b59fb87b89c375cde62b3967178dbe4ed8;hb=97587692088c0aebc302164e335817f5dfedc49f;hpb=477d42570558e6d4f197d80ac345d20fbcaef789

diff --git a/perl/Sesse/pr0n/Common.pm b/perl/Sesse/pr0n/Common.pm
index c6f1c5b..0b2fa24 100644
--- a/perl/Sesse/pr0n/Common.pm
+++ b/perl/Sesse/pr0n/Common.pm
@@ -31,7 +31,7 @@ BEGIN {
 		require Sesse::pr0n::Config_local;
 	};
 
-	$VERSION     = "v2.05";
+	$VERSION     = "v2.10";
 	@ISA         = qw(Exporter);
 	@EXPORT      = qw(&error &dberror);
 	%EXPORT_TAGS = qw();
@@ -117,10 +117,10 @@ sub scale_aspect {
 	return ($width, $height);
 }
 
-sub print_link {
-	my ($r, $title, $baseurl, $param, $defparam) = @_;
-	my $str = "<a href=\"$baseurl";
+sub get_query_string {
+	my ($param, $defparam) = @_;
 	my $first = 1;
+	my $str = "";
 
 	while (my ($key, $value) = each %$param) {
 		next unless defined($value);
@@ -130,8 +130,12 @@ sub print_link {
 		$str .= "$key=$value";
 		$first = 0;
 	}
-	
-	$str .= "\">$title</a>";
+	return $str;
+}
+
+sub print_link {
+	my ($r, $title, $baseurl, $param, $defparam) = @_;
+	my $str = "<a href=\"$baseurl" . get_query_string($param, $defparam) . "\">$title</a>";
 	$r->print($str);
 }
 
@@ -141,7 +145,7 @@ sub get_dbh {
 		# Try to reconnect
 		Apache2::ServerUtil->server->log_error("Lost contact with PostgreSQL server, trying to reconnect...");
 		unless ($dbh = DBI->connect("dbi:Pg:dbname=pr0n;host=" . $Sesse::pr0n::Config::db_host,
-			$Sesse::pr0n::Config::db_user, $Sesse::pr0n::Config::db_password)) {
+			$Sesse::pr0n::Config::db_username, $Sesse::pr0n::Config::db_password)) {
 			$dbh = undef;
 			die "Couldn't connect to PostgreSQL database";
 		}
@@ -192,7 +196,7 @@ sub update_width_height {
 
 	# update the last_picture cache as well (this should of course be done
 	# via a trigger, but this is less complicated :-) )
-	$dbh->do('UPDATE last_picture_cache SET last_picture=GREATEST(last_picture, ?) FROM images WHERE event=events.id) WHERE id=(SELECT event FROM images WHERE id=?)',
+	$dbh->do('UPDATE last_picture_cache SET last_picture=GREATEST(last_picture, ?) WHERE event=(SELECT event FROM images WHERE id=?)',
 		undef, $datetime, $id)
 		or die "Couldn't update last_picture in SQL: $!";
 }
@@ -288,7 +292,6 @@ sub ensure_cached {
 
 		# NEF files aren't autodetected
 		$fname = "NEF:$fname" if ($filename =~ /\.nef$/i);
-		$r->log->warn("Generating $fname for $filename");
 		
 		my $err = $magick->Read($fname);
 		if ($err) {
@@ -394,7 +397,12 @@ sub make_infobox {
 		push @lines, "$1-$2-$3 $4:$5";
 	}
 
-	push @lines, $info->{'Model'} if (defined($info->{'Model'}));
+	if (defined($info->{'Model'})) {
+		my $model = $info->{'Model'}; 
+		$model =~ s/^\s+//;
+		$model =~ s/\s+$//;
+		push @lines, $model;
+	}
 	
 	# classic fields
 	if (defined($info->{'FocalLength'}) && $info->{'FocalLength'} =~ /^(\d+)(?:\.\d+)?(?:mm)?$/) {
@@ -440,9 +448,11 @@ sub make_infobox {
 	if (defined($info->{'Flash'})) {
 		if ($info->{'Flash'} =~ /did not fire/i ||
 		    $info->{'Flash'} =~ /no flash/i ||
-		    $info->{'Flash'} =~ /not fired/i)  {
+		    $info->{'Flash'} =~ /not fired/i ||
+		    $info->{'Flash'} =~ /Off/)  {
 			push @lines, "No flash";
-		} elsif ($info->{'Flash'} =~ /fired/i) {
+		} elsif ($info->{'Flash'} =~ /fired/i ||
+		         $info->{'Flash'} =~ /On/) {
 			push @lines, "Flash";
 		} else {
 			push @lines, $info->{'Flash'};