If the PGN has no clock information, explicitly delete it, so that we do not get...

[remoteglot] / remoteglot.pl

diff --git a/remoteglot.pl b/remoteglot.pl
index 63cdac205d89a57e036e12b59d604212e0cbfbba..aaaed104ea94a2fd73ab316678129b4f66b5bf18 100755 (executable)
--- a/remoteglot.pl
+++ b/remoteglot.pl
@@ -35,6 +35,7 @@ my $stop_pgn_fetch = 0;
 my $tb_retry_timer = undef;
 my %tb_cache = ();
 my $tb_lookup_running = 0;
+my $last_written_json = undef;
 
 # TODO: Persist (parts of) this so that we can restart.
 my %clock_target_for_pos = ();
@@ -268,10 +269,16 @@ sub handle_pgn {
        }
 
        my $pgn = Chess::PGN::Parse->new(undef, $body);
-       if (!defined($pgn) || !$pgn->read_game()) {
+       if (!defined($pgn) || !$pgn->read_game() || $body !~ /^\[/) {
                warn "Error in parsing PGN from $url\n";
        } else {
                eval {
+                       # Skip to the right game.
+                       while (defined($remoteglotconf::pgn_filter) &&
+                              !&$remoteglotconf::pgn_filter($pgn)) {
+                               $pgn->read_game() or die "Out of games during filtering";
+                       }
+
                        $pgn->parse_game({ save_comments => 'yes' });
                        my $pos = Position->start_pos($pgn->white, $pgn->black);
                        my $moves = $pgn->moves;
@@ -308,7 +315,7 @@ sub handle_pgn {
                        }
                };
                if ($@) {
-                       warn "Error in parsing moves from $url\n";
+                       warn "Error in parsing moves from $url: $@\n";
                }
        }
        
@@ -760,8 +767,10 @@ sub output_json {
        $json->{'refutation_lines'} = \%refutation_lines;
 
        my $encoded = JSON::XS::encode_json($json);
-       unless ($historic_json_only) {
+       unless ($historic_json_only || !defined($remoteglotconf::json_output) ||
+               (defined($last_written_json) && $last_written_json eq $encoded)) {
                atomic_set_contents($remoteglotconf::json_output, $encoded);
+               $last_written_json = $encoded;
        }
 
        if (exists($pos_calculating->{'pretty_history'}) &&
@@ -1008,15 +1017,19 @@ sub extract_clock {
                $pos->{'black_clock'} = $1;
                return;
        }
+
+       delete $pos->{'white_clock'};
+       delete $pos->{'black_clock'};
 }
 
 sub find_clock_start {
        my $pos = shift;
 
        # If the game is over, the clock is stopped.
-       if ($pos->{'result'} eq '1-0' ||
-           $pos->{'result'} eq '1/2-1/2' ||
-           $pos->{'result'} eq '0-1') {
+       if (exists($pos->{'result'}) &&
+           ($pos->{'result'} eq '1-0' ||
+            $pos->{'result'} eq '1/2-1/2' ||
+            $pos->{'result'} eq '0-1')) {
                return;
        }
 
@@ -1025,6 +1038,11 @@ sub find_clock_start {
                return;
        }
 
+       # TODO(sesse): Maybe we can get the number of moves somehow else for FICS games.
+       if (!exists($pos->{'pretty_history'})) {
+               return;
+       }
+
        my $id = id_for_pos($pos);
        if (exists($clock_target_for_pos{$id})) {
                if ($pos->{'toplay'} eq 'W') {