X-Git-Url: https://git.sesse.net/?p=remoteglot;a=blobdiff_plain;f=Board.pm;h=a867c74162cefde898c6f25d3fd37442c02bc2c5;hp=1bedd56a23d704f458384a858f69b4120cf652d4;hb=352d2a6829b4144ba1ad156c08f9b3332bc73d0f;hpb=3f2c87e7a476de25d87fd413dba7fef912838bee

diff --git a/Board.pm b/Board.pm
index 1bedd56..a867c74 100644
--- a/Board.pm
+++ b/Board.pm
@@ -226,10 +226,46 @@ sub can_reach {
 	if ($dest_piece ne '-') {
 		return 0 if (($piece eq lc($piece)) == ($dest_piece eq lc($dest_piece)));
 	}
-
-	if (lc($piece) eq 'k') {
-		return (abs($from_row - $to_row) <= 1 && abs($from_col - $to_col) <= 1);
+	
+	if ($piece eq 'p') {
+		# black pawn
+		if ($to_col == $from_col && $to_row == $from_row + 1) {
+			return ($dest_piece eq '-');
+		}
+		if ($to_col == $from_col && $from_row == 1 && $to_row == 3) {
+			my $middle_piece = $board->[2][$to_col];
+			return ($dest_piece eq '-' && $middle_piece eq '-');
+		}
+		if (abs($to_col - $from_col) == 1 && $to_row == $from_row + 1) {
+			if ($dest_piece eq '-') {
+				# En passant. TODO: check that the last move was indeed an EP move
+				return ($to_row == 5 && $board->[4][$to_col] eq 'P');
+			} else {
+				return 1;
+			}
+		}
+		return 0;
 	}
+	if ($piece eq 'P') {
+		# white pawn
+		if ($to_col == $from_col && $to_row == $from_row - 1) {
+			return ($dest_piece eq '-');
+		}
+		if ($to_col == $from_col && $from_row == 6 && $to_row == 4) {
+			my $middle_piece = $board->[5][$to_col];
+			return ($dest_piece eq '-' && $middle_piece eq '-');
+		}
+		if (abs($to_col - $from_col) == 1 && $to_row == $from_row - 1) {
+			if ($dest_piece eq '-') {
+				# En passant. TODO: check that the last move was indeed an EP move
+				return ($to_row == 2 && $board->[3][$to_col] eq 'p');
+			} else {
+				return 1;
+			}
+		}
+		return 0;
+	}
+	
 	if (lc($piece) eq 'r') {
 		return 0 unless ($from_row == $to_row || $from_col == $to_col);
 
@@ -292,57 +328,27 @@ sub can_reach {
 		return (can_reach($board, 'R', $from_row, $from_col, $to_row, $to_col) ||
 		        can_reach($board, 'B', $from_row, $from_col, $to_row, $to_col));
 	}
-
-	if ($piece eq 'p') {
-		# black pawn
-		if ($to_col == $from_col && $to_row == $from_row + 1) {
-			return ($dest_piece eq '-');
-		}
-		if ($to_col == $from_col && $from_row == 1 && $to_row == 3) {
-			my $middle_piece = $board->[2][$to_col];
-			return ($dest_piece eq '-' && $middle_piece eq '-');
-		}
-		if (abs($to_col - $from_col) == 1 && $to_row == $from_row + 1) {
-			if ($dest_piece eq '-') {
-				# En passant. TODO: check that the last move was indeed an EP move
-				return ($to_row == 5 && $board->[4][$to_col] eq 'P');
-			} else {
-				return 1;
-			}
-		}
-		return 0;
-	}
-	if ($piece eq 'P') {
-		# white pawn
-		if ($to_col == $from_col && $to_row == $from_row - 1) {
-			return ($dest_piece eq '-');
-		}
-		if ($to_col == $from_col && $from_row == 6 && $to_row == 4) {
-			my $middle_piece = $board->[5][$to_col];
-			return ($dest_piece eq '-' && $middle_piece eq '-');
-		}
-		if (abs($to_col - $from_col) == 1 && $to_row == $from_row - 1) {
-			if ($dest_piece eq '-') {
-				# En passant. TODO: check that the last move was indeed an EP move
-				return ($to_row == 2 && $board->[3][$to_col] eq 'p');
-			} else {
-				return 1;
-			}
-		}
-		return 0;
+	if (lc($piece) eq 'k') {
+		return (abs($from_row - $to_row) <= 1 && abs($from_col - $to_col) <= 1);
 	}
-	
+
 	# unknown piece
 	return 0;
 }
 
+my %pieces_against_side = (
+	k => { K => 1, Q => 1, R => 1, N => 1, B => 1, P => 1 },
+	K => { k => 1, q => 1, r => 1, n => 1, b => 1, p => 1 },
+);
+
 # Returns whether the given side (given as k or K for black and white) is in check.
 sub in_check {
-	my ($board, $piece) = @_;
-	my ($kr, $kc) = _find_piece($board, $piece);
+	my ($board, $side) = @_;
+	my ($kr, $kc) = _find_piece($board, $side);
 
 	# check all pieces for the possibility of threatening this king
 	for my $row (0..7) {
+		next unless grep { exists($pieces_against_side{$side}{$_}) } @{$board->[$row]};
 		for my $col (0..7) {
 			my $piece = $board->[$row][$col];
 			next if ($piece eq '-');
@@ -461,7 +467,7 @@ sub _prettyprint_move_no_check_or_mate {
 			if (defined($promo) && $promo ne '') {
 				# promotion
 				$pretty .= "=";
-				$pretty .= $promo;
+				$pretty .= uc($promo);
 			}
 		}
 		return $pretty;