Use self-describing constants instead of numbers

[stockfish] / src / notation.cpp

diff --git a/src/notation.cpp b/src/notation.cpp
index c4d1c439be38f0f635fa70a4f4a130352e32246a..db5f58b90d3099e1eae631d33cefca8791227d3d 100644 (file)
--- a/src/notation.cpp
+++ b/src/notation.cpp
@@ -28,7 +28,7 @@
 
 using namespace std;
 
-static const char* PieceToChar = " PNBRQK  pnbrqk";
+static const char* PieceToChar[COLOR_NB] = { "PNBRQK", "pnbrqk" };
 
 
 /// score_to_uci() converts a value to a string suitable for use with the UCI
@@ -75,7 +75,7 @@ const string move_to_uci(Move m, bool chess960) {
   string move = square_to_string(from) + square_to_string(to);
 
   if (type_of(m) == PROMOTION)
-      move += PieceToChar[make_piece(BLACK, promotion_type(m))]; // Lower case
+      move += PieceToChar[BLACK][promotion_type(m)]; // Lower case
 
   return move;
 }
@@ -125,7 +125,7 @@ const string move_to_san(Position& pos, Move m) {
   {
       if (pt != PAWN)
       {
-          san = PieceToChar[pt]; // Upper case
+          san = PieceToChar[WHITE][pt]; // Upper case
 
           // Disambiguation if we have more then one piece with destination 'to'
           // note that for pawns is not needed because starting file is explicit.
@@ -167,7 +167,7 @@ const string move_to_san(Position& pos, Move m) {
       san += square_to_string(to);
 
       if (type_of(m) == PROMOTION)
-          san += string("=") + PieceToChar[promotion_type(m)];
+          san += string("=") + PieceToChar[WHITE][promotion_type(m)];
   }
 
   if (pos.move_gives_check(m, CheckInfo(pos)))
@@ -186,14 +186,14 @@ const string move_to_san(Position& pos, Move m) {
 /// appended to the search log file. It uses the two helpers below to pretty
 /// format time and score respectively.
 
-static string time_to_string(int millisecs) {
+static string time_to_string(int64_t msecs) {
 
   const int MSecMinute = 1000 * 60;
   const int MSecHour   = 1000 * 60 * 60;
 
-  int hours = millisecs / MSecHour;
-  int minutes =  (millisecs % MSecHour) / MSecMinute;
-  int seconds = ((millisecs % MSecHour) % MSecMinute) / 1000;
+  int64_t hours   =   msecs / MSecHour;
+  int64_t minutes =  (msecs % MSecHour) / MSecMinute;
+  int64_t seconds = ((msecs % MSecHour) % MSecMinute) / 1000;
 
   stringstream s;
 
@@ -221,7 +221,7 @@ static string score_to_string(Value v) {
   return s.str();
 }
 
-string pretty_pv(Position& pos, int depth, Value value, int time, Move pv[]) {
+string pretty_pv(Position& pos, int depth, Value value, int64_t msecs, Move pv[]) {
 
   const int64_t K = 1000;
   const int64_t M = 1000000;
@@ -234,7 +234,7 @@ string pretty_pv(Position& pos, int depth, Value value, int time, Move pv[]) {
 
   s << setw(2) << depth
     << setw(8) << score_to_string(value)
-    << setw(8) << time_to_string(time);
+    << setw(8) << time_to_string(msecs);
 
   if (pos.nodes_searched() < M)
       s << setw(8) << pos.nodes_searched() / 1 << "  ";