Retire the misdesigned StepAttacks[] array.

[stockfish] / src / position.cpp

diff --git a/src/position.cpp b/src/position.cpp
index e20c822f5998902ba2149d13504bd9846a1833d0..69a756d9ce9b0b68ab0eecce7758a4ced1e05401 100644 (file)
--- a/src/position.cpp
+++ b/src/position.cpp
@@ -595,7 +595,7 @@ bool Position::pseudo_legal(const Move m) const {
                && empty(to - pawn_push(us))))
           return false;
   }
-  else if (!(attacks_from(pc, from) & to))
+  else if (!(attacks_from(type_of(pc), from) & to))
       return false;
 
   // Evasions generator already takes care to avoid some kind of illegal moves
@@ -648,7 +648,7 @@ bool Position::gives_check(Move m) const {
       return false;
 
   case PROMOTION:
-      return attacks_bb(Piece(promotion_type(m)), to, pieces() ^ from) & square<KING>(~sideToMove);
+      return attacks_bb(promotion_type(m), to, pieces() ^ from) & square<KING>(~sideToMove);
 
   // En passant capture with check? We have already handled the case
   // of direct checks and ordinary discovered check, so the only case we