void id_loop(Position& pos);
Value value_to_tt(Value v, int ply);
Value value_from_tt(Value v, int ply);
- void update_stats(Position& pos, Stack* ss, Move move, Depth depth, Move* quiets, int quietsCnt);
+ void update_stats(const Position& pos, Stack* ss, Move move, Depth depth, Move* quiets, int quietsCnt);
string uci_pv(const Position& pos, int depth, Value alpha, Value beta);
struct Skill {
for (size_t i = 0; i < Threads.size(); ++i)
Threads[i]->maxPly = 0;
- Threads.sleepWhileIdle = Options["Idle Threads Sleep"];
Threads.timer->run = true;
Threads.timer->notify_one(); // Wake up the recurring timer
id_loop(RootPos); // Let's start searching !
Threads.timer->run = false; // Stop the timer
- Threads.sleepWhileIdle = true; // Send idle threads to sleep
if (Options["Write Search Log"])
{
&& abs(beta) < VALUE_MATE_IN_MAX_PLY
&& !pos.pawn_on_7th(pos.side_to_move()))
{
+ if ( depth <= ONE_PLY
+ && eval + razor_margin(3 * ONE_PLY) <= alpha)
+ return qsearch<NonPV, false>(pos, ss, alpha, beta, DEPTH_ZERO);
+
Value ralpha = alpha - razor_margin(depth);
Value v = qsearch<NonPV, false>(pos, ss, ralpha, ralpha+1, DEPTH_ZERO);
if (v <= ralpha)
value = -search<NonPV, false>(pos, ss+1, -(alpha+1), -alpha, d, true);
- // Research at intermediate depth if reduction is very high
+ // Re-search at intermediate depth if reduction is very high
if (value > alpha && ss->reduction >= 4 * ONE_PLY)
{
Depth d2 = std::max(newDepth - 2 * ONE_PLY, ONE_PLY);
&& Threads.size() >= 2
&& depth >= Threads.minimumSplitDepth
&& ( !thisThread->activeSplitPoint
- || !thisThread->activeSplitPoint->allowLatejoin)
+ || !thisThread->activeSplitPoint->allSlavesSearching)
&& thisThread->splitPointsSize < MAX_SPLITPOINTS_PER_THREAD)
{
assert(bestValue > -VALUE_INFINITE && bestValue < beta);
// must be mate or stalemate. If we are in a singular extension search then
// return a fail low score.
if (!moveCount)
- return excludedMove ? alpha
- : inCheck ? mated_in(ss->ply) : DrawValue[pos.side_to_move()];
+ bestValue = excludedMove ? alpha
+ : inCheck ? mated_in(ss->ply) : DrawValue[pos.side_to_move()];
+
+ // Quiet best move: update killers, history, countermoves and followupmoves
+ else if (bestValue >= beta && !pos.capture_or_promotion(bestMove) && !inCheck)
+ update_stats(pos, ss, bestMove, depth, quietsSearched, quietCount - 1);
TT.store(posKey, value_to_tt(bestValue, ss->ply),
bestValue >= beta ? BOUND_LOWER :
PvNode && bestMove ? BOUND_EXACT : BOUND_UPPER,
depth, bestMove, ss->staticEval);
- // Quiet best move: update killers, history, countermoves and followupmoves
- if (bestValue >= beta && !pos.capture_or_promotion(bestMove) && !inCheck)
- update_stats(pos, ss, bestMove, depth, quietsSearched, quietCount - 1);
-
assert(bestValue > -VALUE_INFINITE && bestValue < VALUE_INFINITE);
return bestValue;
// update_stats() updates killers, history, countermoves and followupmoves stats after a fail-high
// of a quiet move.
- void update_stats(Position& pos, Stack* ss, Move move, Depth depth, Move* quiets, int quietsCnt) {
+ void update_stats(const Position& pos, Stack* ss, Move move, Depth depth, Move* quiets, int quietsCnt) {
if (ss->killers[0] != move)
{
StateInfo state[MAX_PLY_PLUS_6], *st = state;
const TTEntry* tte;
- int ply = 0;
- Move m = pv[0];
+ int ply = 1; // At root ply is 1...
+ Move m = pv[0]; // ...instead pv[] array starts from 0
+ Value expectedScore = score;
pv.clear();
do {
pv.push_back(m);
- assert(MoveList<LEGAL>(pos).contains(pv[ply]));
+ assert(MoveList<LEGAL>(pos).contains(pv[ply - 1]));
- pos.do_move(pv[ply++], *st++);
+ pos.do_move(pv[ply++ - 1], *st++);
tte = TT.probe(pos.key());
+ expectedScore = -expectedScore;
} while ( tte
+ && expectedScore == value_from_tt(tte->value(), ply)
&& pos.pseudo_legal(m = tte->move()) // Local copy, TT could change
&& pos.legal(m, pos.pinned_pieces(pos.side_to_move()))
&& ply < MAX_PLY
- && (!pos.is_draw() || ply < 2));
+ && (!pos.is_draw() || ply <= 2));
pv.push_back(MOVE_NONE); // Must be zero-terminating
- while (ply) pos.undo_move(pv[--ply]);
+ while (--ply) pos.undo_move(pv[ply - 1]);
}
StateInfo state[MAX_PLY_PLUS_6], *st = state;
const TTEntry* tte;
- int ply = 0;
+ int idx = 0; // Ply starts from 1, we need to start from 0
do {
tte = TT.probe(pos.key());
- if (!tte || tte->move() != pv[ply]) // Don't overwrite correct entries
- TT.store(pos.key(), VALUE_NONE, BOUND_NONE, DEPTH_NONE, pv[ply], VALUE_NONE);
+ if (!tte || tte->move() != pv[idx]) // Don't overwrite correct entries
+ TT.store(pos.key(), VALUE_NONE, BOUND_NONE, DEPTH_NONE, pv[idx], VALUE_NONE);
- assert(MoveList<LEGAL>(pos).contains(pv[ply]));
+ assert(MoveList<LEGAL>(pos).contains(pv[idx]));
- pos.do_move(pv[ply++], *st++);
+ pos.do_move(pv[idx++], *st++);
- } while (pv[ply] != MOVE_NONE);
+ } while (pv[idx] != MOVE_NONE);
- while (ply) pos.undo_move(pv[--ply]);
+ while (idx) pos.undo_move(pv[--idx]);
}
{
// If we are not searching, wait for a condition to be signaled instead of
// wasting CPU time polling for work.
- while ((!searching && Threads.sleepWhileIdle) || exit)
+ while (!searching || exit)
{
if (exit)
{
assert(searching);
+ searching = false;
activePosition = NULL;
sp->slavesMask.reset(idx);
- sp->allowLatejoin = false;
+ sp->allSlavesSearching = false;
sp->nodes += pos.nodes_searched();
// Wake up the master thread so to allow it to return from the idle
// loop in case we are the last slave of the split point.
- if ( Threads.sleepWhileIdle
- && this != sp->masterThread
+ if ( this != sp->masterThread
&& sp->slavesMask.none())
{
assert(!sp->masterThread->searching);
// After releasing the lock we can't access any SplitPoint related data
// in a safe way because it could have been released under our feet by
- // the sp master. Also accessing other Thread objects is unsafe because
- // if we are exiting there is a chance that they are already freed.
+ // the sp master.
sp->mutex.unlock();
- // Try to late join to another splitpoint
- if (Threads.size() <= 2 || !attempt_to_latejoin()) // FIXME: attempt_to_latejoin() is theoretically unsafe when were are exiting the program...
- searching = false;
+ // Try to late join to another split point if none of its slaves has
+ // already finished.
+ if (Threads.size() > 2)
+ for (size_t i = 0; i < Threads.size(); ++i)
+ {
+ int size = Threads[i]->splitPointsSize; // Local copy
+ sp = size ? &Threads[i]->splitPoints[size - 1] : NULL;
+
+ if ( sp
+ && sp->allSlavesSearching
+ && available_to(Threads[i]))
+ {
+ // Recheck the conditions under lock protection
+ Threads.mutex.lock();
+ sp->mutex.lock();
+
+ if ( sp->allSlavesSearching
+ && available_to(Threads[i]))
+ {
+ sp->slavesMask.set(idx);
+ activeSplitPoint = sp;
+ searching = true;
+ }
+
+ sp->mutex.unlock();
+ Threads.mutex.unlock();
+
+ break; // Just a single attempt
+ }
+ }
}
// If this thread is the master of a split point and all slaves have finished
}
}
-bool Thread::attempt_to_latejoin()
-{
- SplitPoint *sp;
- size_t i;
- bool success = false;
-
- for (i = 0; i < Threads.size(); ++i)
- {
- int size = Threads[i]->splitPointsSize; // Make a local copy to prevent size from changing under our feet.
-
- sp = size ? &Threads[i]->splitPoints[size - 1] : NULL;
-
- if ( sp
- && sp->allowLatejoin
- && available_to(Threads[i], true))
- break;
- }
-
- if (i == Threads.size())
- return false; // No suitable splitpoint found!
-
- // Recheck conditions under lock protection
- Threads.mutex.lock();
- sp->mutex.lock();
-
- if ( sp->allowLatejoin
- && available_to(Threads[i], true))
- {
- activeSplitPoint = sp;
- sp->slavesMask.set(this->idx);
- success = true;
- }
-
- sp->mutex.unlock();
- Threads.mutex.unlock();
-
- return success;
-}
/// check_time() is called by the timer thread when the timer triggers. It is
/// used to print debug info and, more importantly, to detect when we are out of
projects / stockfish / blobdiff