X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fbitboard.cpp;h=89065c49fe81eb11d0328e08b121cb0018c23f77;hp=8250e829713020bb7d13cf061eb41f39bc9082e6;hb=3901affb1d0cb1889f96e7cdade3943f441e9f5a;hpb=a6017aa728c12c48faf758e6df3b3a1e2b704dad diff --git a/src/bitboard.cpp b/src/bitboard.cpp index 8250e829..89065c49 100644 --- a/src/bitboard.cpp +++ b/src/bitboard.cpp @@ -349,30 +349,39 @@ Square first_1(Bitboard b) { /// pop_1st_bit() finds and clears the least significant nonzero bit in a /// nonzero bitboard. -#if defined(USE_32BIT_ATTACKS) && defined(_MSC_VER) +#if defined(USE_32BIT_ATTACKS) -// On 32bit system compiled with MSVC this verion seems -// slightly faster then the standard one. +// Use type-punning +union b_union { -Square pop_1st_bit(Bitboard *b) { + Bitboard b; + struct { + uint32_t l; + uint32_t h; + }; +}; - unsigned long index; - uint32_t *l, *h; +// WARNING: Needs -fno-strict-aliasing compiler option +Square pop_1st_bit(Bitboard *bb) { - if (*(l = (uint32_t*)b) != 0) - { - _BitScanForward(&index, *l); - *l &= ~(1 << index); - } - else if (*(h = (uint32_t*)b + 1) != 0) - { - _BitScanForward(&index, *h); - *h &= ~(1 << index); - index += 32; - } else - return SQ_NONE; - - return Square(index); + b_union u; + uint32_t b; + + u.b = *bb; + + if (u.l) + { + b = u.l; + *((uint32_t*)bb) = b & (b - 1); + b ^= (b - 1); + } + else + { + b = u.h; + *((uint32_t*)bb+1) = b & (b - 1); // Little endian only? + b = ~(b ^ (b - 1)); + } + return Square(BitTable[(b * 0x783a9b23) >> 26]); } #else