X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fevaluate.cpp;h=d225de26fff69994013aabd9762dc373abe730f6;hp=cf164cda786d94260b1a5c5b7d0ac651cf9bc9c2;hb=35ada63174bbec6289d6dea6d3cfc5b5f14d1d27;hpb=54b7da120f6d88f66c22598fb2d1df29e9a17a9c diff --git a/src/evaluate.cpp b/src/evaluate.cpp index cf164cda..d225de26 100644 --- a/src/evaluate.cpp +++ b/src/evaluate.cpp @@ -1,7 +1,7 @@ /* Stockfish, a UCI chess playing engine derived from Glaurung 2.1 Copyright (C) 2004-2008 Tord Romstad (Glaurung author) - Copyright (C) 2008 Marco Costalba + Copyright (C) 2008-2009 Marco Costalba Stockfish is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -25,6 +25,7 @@ #include #include +#include "bitcount.h" #include "evaluate.h" #include "material.h" #include "pawns.h" @@ -39,107 +40,77 @@ namespace { - const int Sign[2] = {1, -1}; + const int Sign[2] = { 1, -1 }; - // Evaluation grain size, must be a power of 2. - const int GrainSize = 4; + // Evaluation grain size, must be a power of 2 + const int GrainSize = 8; - // Evaluation weights - int WeightMobilityMidgame = 0x100; - int WeightMobilityEndgame = 0x100; - int WeightPawnStructureMidgame = 0x100; - int WeightPawnStructureEndgame = 0x100; - int WeightPassedPawnsMidgame = 0x100; - int WeightPassedPawnsEndgame = 0x100; - int WeightKingSafety[2] = { 0x100, 0x100 }; - int WeightSpace; + // Evaluation weights, initialized from UCI options + Score WeightMobility, WeightPawnStructure; + Score WeightPassedPawns, WeightSpace; + Score WeightKingSafety[2]; - // Internal evaluation weights. These are applied on top of the evaluation - // weights read from UCI parameters. The purpose is to be able to change + // Internal evaluation weights. These are applied on top of the evaluation + // weights read from UCI parameters. The purpose is to be able to change // the evaluation weights while keeping the default values of the UCI // parameters at 100, which looks prettier. - const int WeightMobilityMidgameInternal = 0x100; - const int WeightMobilityEndgameInternal = 0x100; - const int WeightPawnStructureMidgameInternal = 0x100; - const int WeightPawnStructureEndgameInternal = 0x100; - const int WeightPassedPawnsMidgameInternal = 0x100; - const int WeightPassedPawnsEndgameInternal = 0x100; - const int WeightKingSafetyInternal = 0x110; - const int WeightKingOppSafetyInternal = 0x110; - const int WeightSpaceInternal = 0x30; - - // Visually better to define tables constants + // + // Values modified by Joona Kiiski + const Score WeightMobilityInternal = make_score(248, 271); + const Score WeightPawnStructureInternal = make_score(233, 201); + const Score WeightPassedPawnsInternal = make_score(252, 259); + const Score WeightSpaceInternal = make_score( 46, 0); + const Score WeightKingSafetyInternal = make_score(247, 0); + const Score WeightKingOppSafetyInternal = make_score(259, 0); + + // Mobility and outposts bonus modified by Joona Kiiski + typedef Value V; + #define S(mg, eg) make_score(mg, eg) + + CACHE_LINE_ALIGNMENT // Knight mobility bonus in middle game and endgame, indexed by the number // of attacked squares not occupied by friendly piecess. - const Value MidgameKnightMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 8 - V(-30), V(-20),V(-10), V(0), V(10), V(20), V(25), V(30), V(30) - }; - - const Value EndgameKnightMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 8 - V(-30), V(-20),V(-10), V(0), V(10), V(20), V(25), V(30), V(30) + const Score KnightMobilityBonus[16] = { + S(-38,-33), S(-25,-23), S(-12,-13), S( 0,-3), + S( 12, 7), S( 25, 17), S( 31, 22), S(38, 27), S(38, 27) }; // Bishop mobility bonus in middle game and endgame, indexed by the number - // of attacked squares not occupied by friendly pieces. X-ray attacks through + // of attacked squares not occupied by friendly pieces. X-ray attacks through // queens are also included. - const Value MidgameBishopMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 - V(-30), V(-15), V(0), V(15), V(30), V(45), V(58), V(66), - // 8 9 10 11 12 13 14 15 - V( 72), V( 76), V(78), V(80), V(81), V(82), V(83), V(83) - }; - - const Value EndgameBishopMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 - V(-30), V(-15), V(0), V(15), V(30), V(45), V(58), V(66), - // 8 9 10 11 12 13 14 15 - V( 72), V( 76), V(78), V(80), V(81), V(82), V(83), V(83) + const Score BishopMobilityBonus[16] = { + S(-25,-30), S(-11,-16), S( 3, -2), S(17, 12), + S( 31, 26), S( 45, 40), S(57, 52), S(65, 60), + S( 71, 65), S( 74, 69), S(76, 71), S(78, 73), + S( 79, 74), S( 80, 75), S(81, 76), S(81, 76) }; // Rook mobility bonus in middle game and endgame, indexed by the number - // of attacked squares not occupied by friendly pieces. X-ray attacks through + // of attacked squares not occupied by friendly pieces. X-ray attacks through // queens and rooks are also included. - const Value MidgameRookMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 - V(-18), V(-12), V(-6), V(0), V(6), V(12), V(16), V(21), - // 8 9 10 11 12 13 14 15 - V( 24), V( 27), V(28), V(29), V(30), V(31), V(32), V(33) - }; - - const Value EndgameRookMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 - V(-30), V(-18), V(-6), V(6), V(18), V(30), V(42), V(54), - // 8 9 10 11 12 13 14 15 - V( 66), V( 74), V(78), V(80), V(81), V(82), V(83), V(83) + const Score RookMobilityBonus[16] = { + S(-20,-36), S(-14,-19), S(-8, -3), S(-2, 13), + S( 4, 29), S( 10, 46), S(14, 62), S(19, 79), + S( 23, 95), S( 26,106), S(27,111), S(28,114), + S( 29,116), S( 30,117), S(31,118), S(32,118) }; // Queen mobility bonus in middle game and endgame, indexed by the number // of attacked squares not occupied by friendly pieces. - const Value MidgameQueenMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 - V(-10), V(-8), V(-6), V(-4), V(-2), V( 0), V( 2), V( 4), - // 8 9 10 11 12 13 14 15 - V( 6), V( 8), V(10), V(12), V(13), V(14), V(15), V(16), - // 16 17 18 19 20 21 22 23 - V( 16), V(16), V(16), V(16), V(16), V(16), V(16), V(16), - // 24 25 26 27 28 29 30 31 - V( 16), V(16), V(16), V(16), V(16), V(16), V(16), V(16) + const Score QueenMobilityBonus[32] = { + S(-10,-18), S(-8,-13), S(-6, -7), S(-3, -2), S(-1, 3), S( 1, 8), + S( 3, 13), S( 5, 19), S( 8, 23), S(10, 27), S(12, 32), S(15, 34), + S( 16, 35), S(17, 35), S(18, 35), S(20, 35), S(20, 35), S(20, 35), + S( 20, 35), S(20, 35), S(20, 35), S(20, 35), S(20, 35), S(20, 35), + S( 20, 35), S(20, 35), S(20, 35), S(20, 35), S(20, 35), S(20, 35), + S( 20, 35), S(20, 35) }; - const Value EndgameQueenMobilityBonus[] = { - // 0 1 2 3 4 5 6 7 - V(-20),V(-15),V(-10), V(-5), V( 0), V( 5), V(10), V(15), - // 8 9 10 11 12 13 14 15 - V( 19), V(23), V(27), V(29), V(30), V(30), V(30), V(30), - // 16 17 18 19 20 21 22 23 - V( 30), V(30), V(30), V(30), V(30), V(30), V(30), V(30), - // 24 25 26 27 28 29 30 31 - V( 30), V(30), V(30), V(30), V(30), V(30), V(30), V(30) - }; + // Pointers table to access mobility tables through piece type + const Score* MobilityBonus[8] = { 0, 0, KnightMobilityBonus, BishopMobilityBonus, + RookMobilityBonus, QueenMobilityBonus, 0, 0 }; // Outpost bonuses for knights and bishops, indexed by square (from white's // point of view). @@ -147,10 +118,10 @@ namespace { // A B C D E F G H V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0), // 1 V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0), // 2 - V(0), V(0), V(5),V(10),V(10), V(5), V(0), V(0), // 3 - V(0), V(5),V(20),V(30),V(30),V(20), V(5), V(0), // 4 - V(0),V(10),V(30),V(40),V(40),V(30),V(10), V(0), // 5 - V(0), V(5),V(20),V(20),V(20),V(20), V(5), V(0), // 6 + V(0), V(0), V(4), V(8), V(8), V(4), V(0), V(0), // 3 + V(0), V(4),V(17),V(26),V(26),V(17), V(4), V(0), // 4 + V(0), V(8),V(26),V(35),V(35),V(26), V(8), V(0), // 5 + V(0), V(4),V(17),V(17),V(17),V(17), V(4), V(0), // 6 V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0), // 7 V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0) // 8 }; @@ -161,52 +132,74 @@ namespace { V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0), // 2 V(0), V(0), V(5), V(5), V(5), V(5), V(0), V(0), // 3 V(0), V(5),V(10),V(10),V(10),V(10), V(5), V(0), // 4 - V(0),V(10),V(20),V(20),V(20),V(20),V(10), V(0), // 5 + V(0),V(10),V(21),V(21),V(21),V(21),V(10), V(0), // 5 V(0), V(5), V(8), V(8), V(8), V(8), V(5), V(0), // 6 V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0), // 7 V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0) // 8 }; - // Bonus for unstoppable passed pawns: + // ThreatBonus[][] contains bonus according to which piece type + // attacks which one. + #define Z S(0, 0) + + const Score ThreatBonus[8][8] = { + { Z, Z, Z, Z, Z, Z, Z, Z }, // not used + { Z, S(18,37), Z, S(37,47), S(55,97), S(55,97), Z, Z }, // KNIGHT attacks + { Z, S(18,37), S(37,47), Z, S(55,97), S(55,97), Z, Z }, // BISHOP attacks + { Z, S( 9,27), S(27,47), S(27,47), Z, S(37,47), Z, Z }, // ROOK attacks + { Z, S(27,37), S(27,37), S(27,37), S(27,37), Z, Z, Z }, // QUEEN attacks + { Z, Z, Z, Z, Z, Z, Z, Z }, // not used + { Z, Z, Z, Z, Z, Z, Z, Z }, // not used + { Z, Z, Z, Z, Z, Z, Z, Z } // not used + }; + + // ThreatedByPawnPenalty[] contains a penalty according to which piece + // type is attacked by an enemy pawn. + const Score ThreatedByPawnPenalty[8] = { + Z, Z, S(56, 70), S(56, 70), S(76, 99), S(86, 118), Z, Z + }; + + #undef Z + #undef S + + // Bonus for unstoppable passed pawns const Value UnstoppablePawnValue = Value(0x500); - // Rooks and queens on the 7th rank: - const Value MidgameRookOn7thBonus = Value(50); - const Value EndgameRookOn7thBonus = Value(100); - const Value MidgameQueenOn7thBonus = Value(25); - const Value EndgameQueenOn7thBonus = Value(50); + // Rooks and queens on the 7th rank (modified by Joona Kiiski) + const Score RookOn7thBonus = make_score(47, 98); + const Score QueenOn7thBonus = make_score(27, 54); - // Rooks on open files: - const Value RookOpenFileBonus = Value(40); - const Value RookHalfOpenFileBonus = Value(20); + // Rooks on open files (modified by Joona Kiiski) + const Score RookOpenFileBonus = make_score(43, 43); + const Score RookHalfOpenFileBonus = make_score(19, 19); // Penalty for rooks trapped inside a friendly king which has lost the - // right to castle: + // right to castle. const Value TrappedRookPenalty = Value(180); // Penalty for a bishop on a7/h7 (a2/h2 for black) which is trapped by - // enemy pawns: - const Value TrappedBishopA7H7Penalty = Value(300); + // enemy pawns. + const Score TrappedBishopA7H7Penalty = make_score(300, 300); - // Bitboard masks for detecting trapped bishops on a7/h7 (a2/h2 for black): + // Bitboard masks for detecting trapped bishops on a7/h7 (a2/h2 for black) const Bitboard MaskA7H7[2] = { ((1ULL << SQ_A7) | (1ULL << SQ_H7)), ((1ULL << SQ_A2) | (1ULL << SQ_H2)) }; // Penalty for a bishop on a1/h1 (a8/h8 for black) which is trapped by - // a friendly pawn on b2/g2 (b7/g7 for black). This can obviously only + // a friendly pawn on b2/g2 (b7/g7 for black). This can obviously only // happen in Chess960 games. - const Value TrappedBishopA1H1Penalty = Value(100); + const Score TrappedBishopA1H1Penalty = make_score(100, 100); - // Bitboard masks for detecting trapped bishops on a1/h1 (a8/h8 for black): + // Bitboard masks for detecting trapped bishops on a1/h1 (a8/h8 for black) const Bitboard MaskA1H1[2] = { ((1ULL << SQ_A1) | (1ULL << SQ_H1)), ((1ULL << SQ_A8) | (1ULL << SQ_H8)) }; - // The SpaceMask[color] contains area of the board which is consdered by - // the space evaluation. In the middle game, each side is given a bonus + // The SpaceMask[color] contains the area of the board which is considered + // by the space evaluation. In the middle game, each side is given a bonus // based on how many squares inside this area are safe and available for // friendly minor pieces. const Bitboard SpaceMask[2] = { @@ -218,30 +211,28 @@ namespace { (1ULL< + Value do_evaluate(const Position& pos, EvalInfo& ei, int threadID); + + template + void evaluate_pieces_of_color(const Position& pos, EvalInfo& ei); + + template + void evaluate_king(const Position& pos, EvalInfo& ei); + + template + void evaluate_threats(const Position& pos, EvalInfo& ei); + template + void evaluate_space(const Position& pos, EvalInfo& ei); + + void evaluate_passed_pawns(const Position& pos, EvalInfo& ei); + void evaluate_trapped_bishop_a7h7(const Position& pos, Square s, Color us, EvalInfo& ei); + void evaluate_trapped_bishop_a1h1(const Position& pos, Square s, Color us, EvalInfo& ei); + inline Score apply_weight(Score v, Score weight); + Value scale_by_game_phase(const Score& v, Phase ph, const ScaleFactor sf[]); + Score weight_option(const std::string& mgOpt, const std::string& egOpt, Score internalWeight); + void init_safety(); } @@ -301,26 +290,33 @@ namespace { //// Functions //// -/// evaluate() is the main evaluation function. It always computes two +/// evaluate() is the main evaluation function. It always computes two /// values, an endgame score and a middle game score, and interpolates /// between them based on the remaining material. +Value evaluate(const Position& pos, EvalInfo& ei, int threadID) { + + return CpuHasPOPCNT ? do_evaluate(pos, ei, threadID) + : do_evaluate(pos, ei, threadID); +} + +namespace { -Value evaluate(const Position &pos, EvalInfo &ei, int threadID) { +template +Value do_evaluate(const Position& pos, EvalInfo& ei, int threadID) { assert(pos.is_ok()); assert(threadID >= 0 && threadID < THREAD_MAX); + assert(!pos.is_check()); memset(&ei, 0, sizeof(EvalInfo)); // Initialize by reading the incrementally updated scores included in the // position object (material + piece square tables) - ei.mgValue = pos.mg_value(); - ei.egValue = pos.eg_value(); + ei.value = pos.value(); // Probe the material hash table ei.mi = MaterialTable[threadID]->get_material_info(pos); - ei.mgValue += ei.mi->mg_value(); - ei.egValue += ei.mi->eg_value(); + ei.value += ei.mi->material_value(); // If we have a specialized evaluation function for the current material // configuration, call it and return @@ -334,78 +330,47 @@ Value evaluate(const Position &pos, EvalInfo &ei, int threadID) { // Probe the pawn hash table ei.pi = PawnTable[threadID]->get_pawn_info(pos); - ei.mgValue += apply_weight(ei.pi->mg_value(), WeightPawnStructureMidgame); - ei.egValue += apply_weight(ei.pi->eg_value(), WeightPawnStructureEndgame); + ei.value += apply_weight(ei.pi->pawns_value(), WeightPawnStructure); // Initialize king attack bitboards and king attack zones for both sides - ei.attackedBy[WHITE][KING] = pos.piece_attacks(pos.king_square(WHITE)); - ei.attackedBy[BLACK][KING] = pos.piece_attacks(pos.king_square(BLACK)); + ei.attackedBy[WHITE][KING] = pos.attacks_from(pos.king_square(WHITE)); + ei.attackedBy[BLACK][KING] = pos.attacks_from(pos.king_square(BLACK)); ei.kingZone[WHITE] = ei.attackedBy[BLACK][KING] | (ei.attackedBy[BLACK][KING] >> 8); ei.kingZone[BLACK] = ei.attackedBy[WHITE][KING] | (ei.attackedBy[WHITE][KING] << 8); // Initialize pawn attack bitboards for both sides - ei.attackedBy[WHITE][PAWN] = ((pos.pawns(WHITE) << 9) & ~FileABB) | ((pos.pawns(WHITE) << 7) & ~FileHBB); - ei.attackedBy[BLACK][PAWN] = ((pos.pawns(BLACK) >> 7) & ~FileABB) | ((pos.pawns(BLACK) >> 9) & ~FileHBB); - ei.kingAttackersCount[WHITE] = count_1s_max_15(ei.attackedBy[WHITE][PAWN] & ei.attackedBy[BLACK][KING])/2; - ei.kingAttackersCount[BLACK] = count_1s_max_15(ei.attackedBy[BLACK][PAWN] & ei.attackedBy[WHITE][KING])/2; - - // Evaluate pieces - for (Color c = WHITE; c <= BLACK; c++) - { - // Knights - for (int i = 0; i < pos.piece_count(c, KNIGHT); i++) - evaluate_knight(pos, pos.piece_list(c, KNIGHT, i), c, ei); - - // Bishops - for (int i = 0; i < pos.piece_count(c, BISHOP); i++) - evaluate_bishop(pos, pos.piece_list(c, BISHOP, i), c, ei); - - // Rooks - for (int i = 0; i < pos.piece_count(c, ROOK); i++) - evaluate_rook(pos, pos.piece_list(c, ROOK, i), c, ei); + ei.attackedBy[WHITE][PAWN] = ei.pi->pawn_attacks(WHITE); + ei.attackedBy[BLACK][PAWN] = ei.pi->pawn_attacks(BLACK); + Bitboard b1 = ei.attackedBy[WHITE][PAWN] & ei.attackedBy[BLACK][KING]; + Bitboard b2 = ei.attackedBy[BLACK][PAWN] & ei.attackedBy[WHITE][KING]; + if (b1) + ei.kingAttackersCount[WHITE] = count_1s_max_15(b1)/2; - // Queens - for(int i = 0; i < pos.piece_count(c, QUEEN); i++) - evaluate_queen(pos, pos.piece_list(c, QUEEN, i), c, ei); - - // Special pattern: trapped bishops on a7/h7/a2/h2 - Bitboard b = pos.bishops(c) & MaskA7H7[c]; - while (b) - { - Square s = pop_1st_bit(&b); - evaluate_trapped_bishop_a7h7(pos, s, c, ei); - } - - // Special pattern: trapped bishops on a1/h1/a8/h8 in Chess960: - if (Chess960) - { - b = pos.bishops(c) & MaskA1H1[c]; - while (b) - { - Square s = pop_1st_bit(&b); - evaluate_trapped_bishop_a1h1(pos, s, c, ei); - } - } + if (b2) + ei.kingAttackersCount[BLACK] = count_1s_max_15(b2)/2; - // Sum up all attacked squares - ei.attackedBy[c][0] = ei.attackedBy[c][PAWN] | ei.attackedBy[c][KNIGHT] - | ei.attackedBy[c][BISHOP] | ei.attackedBy[c][ROOK] - | ei.attackedBy[c][QUEEN] | ei.attackedBy[c][KING]; - } + // Evaluate pieces + evaluate_pieces_of_color(pos, ei); + evaluate_pieces_of_color(pos, ei); - // Kings. Kings are evaluated after all other pieces for both sides, + // Kings. Kings are evaluated after all other pieces for both sides, // because we need complete attack information for all pieces when computing // the king safety evaluation. - for (Color c = WHITE; c <= BLACK; c++) - evaluate_king(pos, pos.king_square(c), c, ei); + evaluate_king(pos, ei); + evaluate_king(pos, ei); - // Evaluate passed pawns. We evaluate passed pawns for both sides at once, + // Evaluate tactical threats, we need full attack info + evaluate_threats(pos, ei); + evaluate_threats(pos, ei); + + // Evaluate passed pawns. We evaluate passed pawns for both sides at once, // because we need to know which side promotes first in positions where - // both sides have an unstoppable passed pawn. + // both sides have an unstoppable passed pawn. To be called after all attacks + // are computed, included king. if (ei.pi->passed_pawns()) evaluate_passed_pawns(pos, ei); - Phase phase = pos.game_phase(); + Phase phase = ei.mi->game_phase(); // Middle-game specific evaluation terms if (phase > PHASE_ENDGAME) @@ -414,33 +379,30 @@ Value evaluate(const Position &pos, EvalInfo &ei, int threadID) { if ( square_file(pos.king_square(WHITE)) >= FILE_E && square_file(pos.king_square(BLACK)) <= FILE_D) - ei.mgValue += ei.pi->queenside_storm_value(WHITE) - - ei.pi->kingside_storm_value(BLACK); + ei.value += make_score(ei.pi->queenside_storm_value(WHITE) - ei.pi->kingside_storm_value(BLACK), 0); else if ( square_file(pos.king_square(WHITE)) <= FILE_D && square_file(pos.king_square(BLACK)) >= FILE_E) - ei.mgValue += ei.pi->kingside_storm_value(WHITE) - - ei.pi->queenside_storm_value(BLACK); + ei.value += make_score(ei.pi->kingside_storm_value(WHITE) - ei.pi->queenside_storm_value(BLACK), 0); // Evaluate space for both sides if (ei.mi->space_weight() > 0) { - evaluate_space(pos, WHITE, ei); - evaluate_space(pos, BLACK, ei); + evaluate_space(pos, ei); + evaluate_space(pos, ei); } } // Mobility - ei.mgValue += apply_weight(ei.mgMobility, WeightMobilityMidgame); - ei.egValue += apply_weight(ei.egMobility, WeightMobilityEndgame); + ei.value += apply_weight(ei.mobility, WeightMobility); // If we don't already have an unusual scale factor, check for opposite // colored bishop endgames, and use a lower scale for those if ( phase < PHASE_MIDGAME && pos.opposite_colored_bishops() - && ( (factor[WHITE] == SCALE_FACTOR_NORMAL && ei.egValue > Value(0)) - || (factor[BLACK] == SCALE_FACTOR_NORMAL && ei.egValue < Value(0)))) + && ( (factor[WHITE] == SCALE_FACTOR_NORMAL && eg_value(ei.value) > Value(0)) + || (factor[BLACK] == SCALE_FACTOR_NORMAL && eg_value(ei.value) < Value(0)))) { ScaleFactor sf; @@ -464,37 +426,17 @@ Value evaluate(const Position &pos, EvalInfo &ei, int threadID) { factor[BLACK] = sf; } - // Interpolate between the middle game and the endgame score, and - // return + // Interpolate between the middle game and the endgame score Color stm = pos.side_to_move(); - Value v = Sign[stm] * scale_by_game_phase(ei.mgValue, ei.egValue, phase, factor); + Value v = Sign[stm] * scale_by_game_phase(ei.value, phase, factor); return (ei.mateThreat[stm] == MOVE_NONE ? v : 8 * QueenValueMidgame - v); } +} // namespace -/// quick_evaluate() does a very approximate evaluation of the current position. -/// It currently considers only material and piece square table scores. Perhaps -/// we should add scores from the pawn and material hash tables? - -Value quick_evaluate(const Position &pos) { - - assert(pos.is_ok()); - - static const - ScaleFactor sf[2] = {SCALE_FACTOR_NORMAL, SCALE_FACTOR_NORMAL}; - - Value mgv = pos.mg_value(); - Value egv = pos.eg_value(); - Phase ph = pos.game_phase(); - Color stm = pos.side_to_move(); - - return Sign[stm] * scale_by_game_phase(mgv, egv, ph, sf); -} - - -/// init_eval() initializes various tables used by the evaluation function. +/// init_eval() initializes various tables used by the evaluation function void init_eval(int threads) { @@ -515,13 +457,10 @@ void init_eval(int threads) { if (!MaterialTable[i]) MaterialTable[i] = new MaterialInfoTable(MaterialTableSize); } - - for (Bitboard b = 0ULL; b < 256ULL; b++) - BitCount8Bit[b] = count_1s(b); } -/// quit_eval() releases heap-allocated memory at program termination. +/// quit_eval() releases heap-allocated memory at program termination void quit_eval() { @@ -529,514 +468,590 @@ void quit_eval() { { delete PawnTable[i]; delete MaterialTable[i]; + PawnTable[i] = NULL; + MaterialTable[i] = NULL; } } -/// read_weights() reads evaluation weights from the corresponding UCI -/// parameters. +/// read_weights() reads evaluation weights from the corresponding UCI parameters void read_weights(Color us) { - WeightMobilityMidgame = weight_option("Mobility (Middle Game)", WeightMobilityMidgameInternal); - WeightMobilityEndgame = weight_option("Mobility (Endgame)", WeightMobilityEndgameInternal); - WeightPawnStructureMidgame = weight_option("Pawn Structure (Middle Game)", WeightPawnStructureMidgameInternal); - WeightPawnStructureEndgame = weight_option("Pawn Structure (Endgame)", WeightPawnStructureEndgameInternal); - WeightPassedPawnsMidgame = weight_option("Passed Pawns (Middle Game)", WeightPassedPawnsMidgameInternal); - WeightPassedPawnsEndgame = weight_option("Passed Pawns (Endgame)", WeightPassedPawnsEndgameInternal); - Color them = opposite_color(us); - WeightKingSafety[us] = weight_option("Cowardice", WeightKingSafetyInternal); - WeightKingSafety[them] = weight_option("Aggressiveness", WeightKingOppSafetyInternal); - WeightSpace = weight_option("Space", WeightSpaceInternal); + WeightMobility = weight_option("Mobility (Middle Game)", "Mobility (Endgame)", WeightMobilityInternal); + WeightPawnStructure = weight_option("Pawn Structure (Middle Game)", "Pawn Structure (Endgame)", WeightPawnStructureInternal); + WeightPassedPawns = weight_option("Passed Pawns (Middle Game)", "Passed Pawns (Endgame)", WeightPassedPawnsInternal); + WeightSpace = weight_option("Space", "Space", WeightSpaceInternal); + WeightKingSafety[us] = weight_option("Cowardice", "Cowardice", WeightKingSafetyInternal); + WeightKingSafety[them] = weight_option("Aggressiveness", "Aggressiveness", WeightKingOppSafetyInternal); + // If running in analysis mode, make sure we use symmetrical king safety. We do this + // by replacing both WeightKingSafety[us] and WeightKingSafety[them] by their average. + if (get_option_value_bool("UCI_AnalyseMode")) + { + WeightKingSafety[us] = (WeightKingSafety[us] + WeightKingSafety[them]) / 2; + WeightKingSafety[them] = WeightKingSafety[us]; + } init_safety(); } namespace { - // evaluate_common() computes terms common to all pieces attack - - int evaluate_common(const Position&p, const Bitboard& b, Color us, EvalInfo& ei, - int AttackWeight, const Value* mgBonus, const Value* egBonus, - Square s = SQ_NONE, const Value* OutpostBonus = NULL) { - - Color them = opposite_color(us); - - // King attack - if (b & ei.kingZone[us]) - { - ei.kingAttackersCount[us]++; - ei.kingAttackersWeight[us] += AttackWeight; - Bitboard bb = (b & ei.attackedBy[them][KING]); - if (bb) - ei.kingAdjacentZoneAttacksCount[us] += count_1s_max_15(bb); - } + // evaluate_outposts() evaluates bishop and knight outposts squares - // Mobility - int mob = count_1s_max_15(b & ~p.pieces_of_color(us)); - ei.mgMobility += Sign[us] * mgBonus[mob]; - ei.egMobility += Sign[us] * egBonus[mob]; + template + void evaluate_outposts(const Position& pos, EvalInfo& ei, Square s) { - // Bishop and Knight outposts - if (!OutpostBonus || !p.square_is_weak(s, them)) - return mob; + const Color Them = (Us == WHITE ? BLACK : WHITE); // Initial bonus based on square - Value v, bonus; - v = bonus = OutpostBonus[relative_square(us, s)]; + Value bonus = (Piece == BISHOP ? BishopOutpostBonus[relative_square(Us, s)] + : KnightOutpostBonus[relative_square(Us, s)]); // Increase bonus if supported by pawn, especially if the opponent has // no minor piece which can exchange the outpost piece - if (v && (p.pawn_attacks(them, s) & p.pawns(us))) + if (bonus && bit_is_set(ei.attackedBy[Us][PAWN], s)) { - bonus += v / 2; - if ( p.piece_count(them, KNIGHT) == 0 - && (SquaresByColorBB[square_color(s)] & p.bishops(them)) == EmptyBoardBB) - bonus += v; + if ( pos.pieces(KNIGHT, Them) == EmptyBoardBB + && (SquaresByColorBB[square_color(s)] & pos.pieces(BISHOP, Them)) == EmptyBoardBB) + bonus += bonus + bonus / 2; + else + bonus += bonus / 2; } - ei.mgValue += Sign[us] * bonus; - ei.egValue += Sign[us] * bonus; - return mob; + ei.value += Sign[Us] * make_score(bonus, bonus); } - // evaluate_knight() assigns bonuses and penalties to a knight of a given - // color on a given square. + // evaluate_pieces<>() assigns bonuses and penalties to the pieces of a given color - void evaluate_knight(const Position &p, Square s, Color us, EvalInfo &ei) { - - Bitboard b = p.piece_attacks(s); - ei.attackedBy[us][KNIGHT] |= b; - - // King attack, mobility and outposts - evaluate_common(p, b, us, ei, KnightAttackWeight, MidgameKnightMobilityBonus, - EndgameKnightMobilityBonus, s, KnightOutpostBonus); - } + template + void evaluate_pieces(const Position& pos, EvalInfo& ei, Bitboard no_mob_area) { + Bitboard b; + Square s, ksq; + int mob; + File f; - // evaluate_bishop() assigns bonuses and penalties to a bishop of a given - // color on a given square. + const Color Them = (Us == WHITE ? BLACK : WHITE); + const Square* ptr = pos.piece_list_begin(Us, Piece); - void evaluate_bishop(const Position &p, Square s, Color us, EvalInfo &ei) { + while ((s = *ptr++) != SQ_NONE) + { + // Find attacked squares, including x-ray attacks for bishops and rooks + if (Piece == KNIGHT || Piece == QUEEN) + b = pos.attacks_from(s); + else if (Piece == BISHOP) + b = bishop_attacks_bb(s, pos.occupied_squares() & ~pos.pieces(QUEEN, Us)); + else if (Piece == ROOK) + b = rook_attacks_bb(s, pos.occupied_squares() & ~pos.pieces(ROOK, QUEEN, Us)); + else + assert(false); - Bitboard b = bishop_attacks_bb(s, p.occupied_squares() & ~p.queens(us)); - ei.attackedBy[us][BISHOP] |= b; - - // King attack, mobility and outposts - evaluate_common(p, b, us, ei, BishopAttackWeight, MidgameBishopMobilityBonus, - EndgameBishopMobilityBonus, s, BishopOutpostBonus); - } + // Update attack info + ei.attackedBy[Us][Piece] |= b; + // King attacks + if (b & ei.kingZone[Us]) + { + ei.kingAttackersCount[Us]++; + ei.kingAttackersWeight[Us] += AttackWeight[Piece]; + Bitboard bb = (b & ei.attackedBy[Them][KING]); + if (bb) + ei.kingAdjacentZoneAttacksCount[Us] += count_1s_max_15(bb); + } - // evaluate_rook() assigns bonuses and penalties to a rook of a given - // color on a given square. + // Mobility + mob = (Piece != QUEEN ? count_1s_max_15(b & no_mob_area) + : count_1s(b & no_mob_area)); - void evaluate_rook(const Position &p, Square s, Color us, EvalInfo &ei) { + ei.mobility += Sign[Us] * MobilityBonus[Piece][mob]; - Bitboard b = rook_attacks_bb(s, p.occupied_squares() & ~p.rooks_and_queens(us)); - ei.attackedBy[us][ROOK] |= b; + // Decrease score if we are attacked by an enemy pawn. Remaining part + // of threat evaluation must be done later when we have full attack info. + if (bit_is_set(ei.attackedBy[Them][PAWN], s)) + ei.value -= Sign[Us] * ThreatedByPawnPenalty[Piece]; - // King attack and mobility - int mob = evaluate_common(p, b, us, ei, RookAttackWeight, MidgameRookMobilityBonus, - EndgameRookMobilityBonus); + // Bishop and knight outposts squares + if ((Piece == BISHOP || Piece == KNIGHT) && pos.square_is_weak(s, Them)) + evaluate_outposts(pos, ei, s); - // Rook on 7th rank - Color them = opposite_color(us); + // Special patterns: trapped bishops on a7/h7/a2/h2 + // and trapped bishops on a1/h1/a8/h8 in Chess960. + if (Piece == BISHOP) + { + if (bit_is_set(MaskA7H7[Us], s)) + evaluate_trapped_bishop_a7h7(pos, s, Us, ei); - if ( relative_rank(us, s) == RANK_7 - && relative_rank(us, p.king_square(them)) == RANK_8) - { - ei.mgValue += Sign[us] * MidgameRookOn7thBonus; - ei.egValue += Sign[us] * EndgameRookOn7thBonus; - } + if (Chess960 && bit_is_set(MaskA1H1[Us], s)) + evaluate_trapped_bishop_a1h1(pos, s, Us, ei); + } - // Open and half-open files - File f = square_file(s); - if (ei.pi->file_is_half_open(us, f)) - { - if (ei.pi->file_is_half_open(them, f)) + // Queen or rook on 7th rank + if ( (Piece == ROOK || Piece == QUEEN) + && relative_rank(Us, s) == RANK_7 + && relative_rank(Us, pos.king_square(Them)) == RANK_8) { - ei.mgValue += Sign[us] * RookOpenFileBonus; - ei.egValue += Sign[us] * RookOpenFileBonus; + ei.value += Sign[Us] * (Piece == ROOK ? RookOn7thBonus : QueenOn7thBonus); } - else + + // Special extra evaluation for rooks + if (Piece == ROOK) { - ei.mgValue += Sign[us] * RookHalfOpenFileBonus; - ei.egValue += Sign[us] * RookHalfOpenFileBonus; - } - } + // Open and half-open files + f = square_file(s); + if (ei.pi->file_is_half_open(Us, f)) + { + if (ei.pi->file_is_half_open(Them, f)) + ei.value += Sign[Us] * RookOpenFileBonus; + else + ei.value += Sign[Us] * RookHalfOpenFileBonus; + } - // Penalize rooks which are trapped inside a king. Penalize more if - // king has lost right to castle - if (mob > 6 || ei.pi->file_is_half_open(us, f)) - return; + // Penalize rooks which are trapped inside a king. Penalize more if + // king has lost right to castle. + if (mob > 6 || ei.pi->file_is_half_open(Us, f)) + continue; - Square ksq = p.king_square(us); + ksq = pos.king_square(Us); - if ( square_file(ksq) >= FILE_E - && square_file(s) > square_file(ksq) - && (relative_rank(us, ksq) == RANK_1 || square_rank(ksq) == square_rank(s))) - { - // Is there a half-open file between the king and the edge of the board? - if (!ei.pi->has_open_file_to_right(us, square_file(ksq))) - ei.mgValue -= p.can_castle(us)? Sign[us] * ((TrappedRookPenalty - mob * 16) / 2) - : Sign[us] * (TrappedRookPenalty - mob * 16); - } - else if ( square_file(ksq) <= FILE_D - && square_file(s) < square_file(ksq) - && (relative_rank(us, ksq) == RANK_1 || square_rank(ksq) == square_rank(s))) - { - // Is there a half-open file between the king and the edge of the board? - if (!ei.pi->has_open_file_to_left(us, square_file(ksq))) - ei.mgValue -= p.can_castle(us)? Sign[us] * ((TrappedRookPenalty - mob * 16) / 2) - : Sign[us] * (TrappedRookPenalty - mob * 16); + if ( square_file(ksq) >= FILE_E + && square_file(s) > square_file(ksq) + && (relative_rank(Us, ksq) == RANK_1 || square_rank(ksq) == square_rank(s))) + { + // Is there a half-open file between the king and the edge of the board? + if (!ei.pi->has_open_file_to_right(Us, square_file(ksq))) + ei.value -= Sign[Us] * make_score(pos.can_castle(Us) ? (TrappedRookPenalty - mob * 16) / 2 + : (TrappedRookPenalty - mob * 16), 0); + } + else if ( square_file(ksq) <= FILE_D + && square_file(s) < square_file(ksq) + && (relative_rank(Us, ksq) == RANK_1 || square_rank(ksq) == square_rank(s))) + { + // Is there a half-open file between the king and the edge of the board? + if (!ei.pi->has_open_file_to_left(Us, square_file(ksq))) + ei.value -= Sign[Us] * make_score(pos.can_castle(Us) ? (TrappedRookPenalty - mob * 16) / 2 + : (TrappedRookPenalty - mob * 16), 0); + } + } } } - // evaluate_queen() assigns bonuses and penalties to a queen of a given - // color on a given square. + // evaluate_threats<>() assigns bonuses according to the type of attacking piece + // and the type of attacked one. - void evaluate_queen(const Position &p, Square s, Color us, EvalInfo &ei) { + template + void evaluate_threats(const Position& pos, EvalInfo& ei) { - Bitboard b = p.piece_attacks(s); - ei.attackedBy[us][QUEEN] |= b; + const Color Them = (Us == WHITE ? BLACK : WHITE); - // King attack and mobility - evaluate_common(p, b, us, ei, QueenAttackWeight, MidgameQueenMobilityBonus, - EndgameQueenMobilityBonus); + Bitboard b; + Score bonus = make_score(0, 0); - // Queen on 7th rank - Color them = opposite_color(us); + // Enemy pieces not defended by a pawn and under our attack + Bitboard weakEnemies = pos.pieces_of_color(Them) + & ~ei.attackedBy[Them][PAWN] + & ei.attackedBy[Us][0]; + if (!weakEnemies) + return; - if ( relative_rank(us, s) == RANK_7 - && relative_rank(us, p.king_square(them)) == RANK_8) + // Add bonus according to type of attacked enemy pieces and to the + // type of attacking piece, from knights to queens. Kings are not + // considered because are already special handled in king evaluation. + for (PieceType pt1 = KNIGHT; pt1 < KING; pt1++) { - ei.mgValue += Sign[us] * MidgameQueenOn7thBonus; - ei.egValue += Sign[us] * EndgameQueenOn7thBonus; + b = ei.attackedBy[Us][pt1] & weakEnemies; + if (b) + for (PieceType pt2 = PAWN; pt2 < KING; pt2++) + if (b & pos.pieces(pt2)) + bonus += ThreatBonus[pt1][pt2]; } + ei.value += Sign[Us] * bonus; } - inline Bitboard shiftRowsDown(const Bitboard& b, int num) { - return b >> (num << 3); + // evaluate_pieces_of_color<>() assigns bonuses and penalties to all the + // pieces of a given color. + + template + void evaluate_pieces_of_color(const Position& pos, EvalInfo& ei) { + + const Color Them = (Us == WHITE ? BLACK : WHITE); + + // Do not include in mobility squares protected by enemy pawns or occupied by our pieces + const Bitboard no_mob_area = ~(ei.attackedBy[Them][PAWN] | pos.pieces_of_color(Us)); + + evaluate_pieces(pos, ei, no_mob_area); + evaluate_pieces(pos, ei, no_mob_area); + evaluate_pieces(pos, ei, no_mob_area); + evaluate_pieces(pos, ei, no_mob_area); + + // Sum up all attacked squares + ei.attackedBy[Us][0] = ei.attackedBy[Us][PAWN] | ei.attackedBy[Us][KNIGHT] + | ei.attackedBy[Us][BISHOP] | ei.attackedBy[Us][ROOK] + | ei.attackedBy[Us][QUEEN] | ei.attackedBy[Us][KING]; } - // evaluate_king() assigns bonuses and penalties to a king of a given - // color on a given square. - void evaluate_king(const Position &p, Square s, Color us, EvalInfo &ei) { + // evaluate_king<>() assigns bonuses and penalties to a king of a given color + + template + void evaluate_king(const Position& pos, EvalInfo& ei) { + + const Color Them = (Us == WHITE ? BLACK : WHITE); - int shelter = 0, sign = Sign[us]; + Bitboard undefended, attackedByOthers, escapeSquares, occ, b, b2, safe; + Square from, to; + bool sente; + int attackUnits, count, shelter = 0; + const Square s = pos.king_square(Us); // King shelter - if (relative_rank(us, s) <= RANK_4) + if (relative_rank(Us, s) <= RANK_4) { - Bitboard pawns = p.pawns(us) & this_and_neighboring_files_bb(s); - Rank r = square_rank(s); - for (int i = 1; i < 4; i++) - shelter += count_1s_8bit(shiftRowsDown(pawns, r+i*sign)) * (128>>i); - - ei.mgValue += sign * Value(shelter); + shelter = ei.pi->get_king_shelter(pos, Us, s); + ei.value += Sign[Us] * make_score(shelter, 0); } - // King safety. This is quite complicated, and is almost certainly far + // King safety. This is quite complicated, and is almost certainly far // from optimally tuned. - Color them = opposite_color(us); - - if ( p.piece_count(them, QUEEN) >= 1 - && ei.kingAttackersCount[them] >= 2 - && p.non_pawn_material(them) >= QueenValueMidgame + RookValueMidgame - && ei.kingAdjacentZoneAttacksCount[them]) + if ( pos.piece_count(Them, QUEEN) >= 1 + && ei.kingAttackersCount[Them] >= 2 + && pos.non_pawn_material(Them) >= QueenValueMidgame + RookValueMidgame + && ei.kingAdjacentZoneAttacksCount[Them]) { // Is it the attackers turn to move? - bool sente = (them == p.side_to_move()); + sente = (Them == pos.side_to_move()); // Find the attacked squares around the king which has no defenders // apart from the king itself - Bitboard undefended = - ei.attacked_by(them) & ~ei.attacked_by(us, PAWN) - & ~ei.attacked_by(us, KNIGHT) & ~ei.attacked_by(us, BISHOP) - & ~ei.attacked_by(us, ROOK) & ~ei.attacked_by(us, QUEEN) - & ei.attacked_by(us, KING); - - Bitboard occ = p.occupied_squares(), b, b2; + undefended = ei.attacked_by(Them) & ei.attacked_by(Us, KING); + undefended &= ~( ei.attacked_by(Us, PAWN) | ei.attacked_by(Us, KNIGHT) + | ei.attacked_by(Us, BISHOP) | ei.attacked_by(Us, ROOK) + | ei.attacked_by(Us, QUEEN)); // Initialize the 'attackUnits' variable, which is used later on as an - // index to the SafetyTable[] array. The initial value is based on the + // index to the SafetyTable[] array. The initial value is based on the // number and types of the attacking pieces, the number of attacked and // undefended squares around the king, the square of the king, and the // quality of the pawn shelter. - int attackUnits = - Min((ei.kingAttackersCount[them] * ei.kingAttackersWeight[them]) / 2, 25) - + (ei.kingAdjacentZoneAttacksCount[them] + count_1s_max_15(undefended)) * 3 - + InitKingDanger[relative_square(us, s)] - (shelter >> 5); + attackUnits = Min(25, (ei.kingAttackersCount[Them] * ei.kingAttackersWeight[Them]) / 2) + + 3 * (ei.kingAdjacentZoneAttacksCount[Them] + count_1s_max_15(undefended)) + + InitKingDanger[relative_square(Us, s)] + - (shelter >> 5); // Analyse safe queen contact checks - b = undefended & ei.attacked_by(them, QUEEN) & ~p.pieces_of_color(them); + b = undefended & ei.attacked_by(Them, QUEEN) & ~pos.pieces_of_color(Them); if (b) { - Bitboard attackedByOthers = - ei.attacked_by(them, PAWN) | ei.attacked_by(them, KNIGHT) - | ei.attacked_by(them, BISHOP) | ei.attacked_by(them, ROOK); + attackedByOthers = ei.attacked_by(Them, PAWN) | ei.attacked_by(Them, KNIGHT) + | ei.attacked_by(Them, BISHOP) | ei.attacked_by(Them, ROOK); b &= attackedByOthers; + + // Squares attacked by the queen and supported by another enemy piece and + // not defended by other pieces but our king. if (b) { - // The bitboard b now contains the squares available for safe queen - // contact checks. - int count = count_1s_max_15(b); - attackUnits += QueenContactCheckBonus * count * (sente ? 2 : 1); - - // Is there a mate threat? - if (QueenContactMates && !p.is_check()) - { - Bitboard escapeSquares = - p.piece_attacks(s) & ~p.pieces_of_color(us) & ~attackedByOthers; - - while (b) + // The bitboard b now contains the squares available for safe queen + // contact checks. + count = count_1s_max_15(b); + attackUnits += QueenContactCheckBonus * count * (sente ? 2 : 1); + + // Is there a mate threat? + if (QueenContactMates && !pos.is_check()) { - Square from, to = pop_1st_bit(&b); - if (!(escapeSquares & ~queen_attacks_bb(to, occ & ClearMaskBB[s]))) + escapeSquares = pos.attacks_from(s) & ~pos.pieces_of_color(Us) & ~attackedByOthers; + occ = pos.occupied_squares(); + while (b) { - // We have a mate, unless the queen is pinned or there - // is an X-ray attack through the queen. - for (int i = 0; i < p.piece_count(them, QUEEN); i++) + to = pop_1st_bit(&b); + + // Do we have escape squares from queen contact check attack ? + if (!(escapeSquares & ~queen_attacks_bb(to, occ & ClearMaskBB[s]))) { - from = p.piece_list(them, QUEEN, i); - if ( bit_is_set(p.piece_attacks(from), to) - && !bit_is_set(p.pinned_pieces(them), from) - && !(rook_attacks_bb(to, occ & ClearMaskBB[from]) & p.rooks_and_queens(us)) - && !(rook_attacks_bb(to, occ & ClearMaskBB[from]) & p.rooks_and_queens(us))) - - ei.mateThreat[them] = make_move(from, to); + // We have a mate, unless the queen is pinned or there + // is an X-ray attack through the queen. + for (int i = 0; i < pos.piece_count(Them, QUEEN); i++) + { + from = pos.piece_list(Them, QUEEN, i); + if ( bit_is_set(pos.attacks_from(from), to) + && !bit_is_set(pos.pinned_pieces(Them), from) + && !(rook_attacks_bb(to, occ & ClearMaskBB[from]) & pos.pieces(ROOK, QUEEN, Us)) + && !(bishop_attacks_bb(to, occ & ClearMaskBB[from]) & pos.pieces(BISHOP, QUEEN, Us))) + + // Set the mate threat move + ei.mateThreat[Them] = make_move(from, to); + } } } } - } } } // Analyse safe distance checks + safe = ~(pos.pieces_of_color(Them) | ei.attacked_by(Us)); + if (QueenCheckBonus > 0 || RookCheckBonus > 0) { - b = p.piece_attacks(s) & ~p.pieces_of_color(them) & ~ei.attacked_by(us); + b = pos.attacks_from(s) & safe; // Queen checks - b2 = b & ei.attacked_by(them, QUEEN); - if( b2) - attackUnits += QueenCheckBonus * count_1s_max_15(b2); + b2 = b & ei.attacked_by(Them, QUEEN); + if (b2) + attackUnits += QueenCheckBonus * count_1s_max_15(b2); // Rook checks - b2 = b & ei.attacked_by(them, ROOK); + b2 = b & ei.attacked_by(Them, ROOK); if (b2) - attackUnits += RookCheckBonus * count_1s_max_15(b2); + attackUnits += RookCheckBonus * count_1s_max_15(b2); } if (QueenCheckBonus > 0 || BishopCheckBonus > 0) { - b = p.piece_attacks(s) & ~p.pieces_of_color(them) & ~ei.attacked_by(us); + b = pos.attacks_from(s) & safe; // Queen checks - b2 = b & ei.attacked_by(them, QUEEN); + b2 = b & ei.attacked_by(Them, QUEEN); if (b2) - attackUnits += QueenCheckBonus * count_1s_max_15(b2); + attackUnits += QueenCheckBonus * count_1s_max_15(b2); // Bishop checks - b2 = b & ei.attacked_by(them, BISHOP); + b2 = b & ei.attacked_by(Them, BISHOP); if (b2) - attackUnits += BishopCheckBonus * count_1s_max_15(b2); + attackUnits += BishopCheckBonus * count_1s_max_15(b2); } if (KnightCheckBonus > 0) { - b = p.piece_attacks(s) & ~p.pieces_of_color(them) & ~ei.attacked_by(us); + b = pos.attacks_from(s) & safe; // Knight checks - b2 = b & ei.attacked_by(them, KNIGHT); + b2 = b & ei.attacked_by(Them, KNIGHT); if (b2) - attackUnits += KnightCheckBonus * count_1s_max_15(b2); + attackUnits += KnightCheckBonus * count_1s_max_15(b2); } // Analyse discovered checks (only for non-pawns right now, consider // adding pawns later). if (DiscoveredCheckBonus) { - b = p.discovered_check_candidates(them) & ~p.pawns(); - if (b) - attackUnits += DiscoveredCheckBonus * count_1s_max_15(b) * (sente? 2 : 1); + b = pos.discovered_check_candidates(Them) & ~pos.pieces(PAWN); + if (b) + attackUnits += DiscoveredCheckBonus * count_1s_max_15(b) * (sente ? 2 : 1); } - // Has a mate threat been found? We don't do anything here if the + // Has a mate threat been found? We don't do anything here if the // side with the mating move is the side to move, because in that // case the mating side will get a huge bonus at the end of the main // evaluation function instead. - if (ei.mateThreat[them] != MOVE_NONE) + if (ei.mateThreat[Them] != MOVE_NONE) attackUnits += MateThreatBonus; // Ensure that attackUnits is between 0 and 99, in order to avoid array - // out of bounds errors: - if (attackUnits < 0) - attackUnits = 0; - - if (attackUnits >= 100) - attackUnits = 99; + // out of bounds errors. + attackUnits = Min(99, Max(0, attackUnits)); // Finally, extract the king safety score from the SafetyTable[] array. - // Add the score to the evaluation, and also to ei.futilityMargin. The + // Add the score to the evaluation, and also to ei.futilityMargin. The // reason for adding the king safety score to the futility margin is // that the king safety scores can sometimes be very big, and that // capturing a single attacking piece can therefore result in a score // change far bigger than the value of the captured piece. - Value v = apply_weight(SafetyTable[attackUnits], WeightKingSafety[us]); - - ei.mgValue -= sign * v; - - if (us == p.side_to_move()) - ei.futilityMargin += v; + Score v = apply_weight(make_score(SafetyTable[attackUnits], 0), WeightKingSafety[Us]); + ei.value -= Sign[Us] * v; + ei.futilityMargin[Us] += mg_value(v); } } - // evaluate_passed_pawns() evaluates the passed pawns for both sides. + // evaluate_passed_pawns() evaluates the passed pawns of the given color + + template + void evaluate_passed_pawns_of_color(const Position& pos, int movesToGo[], Square pawnToGo[], EvalInfo& ei) { - void evaluate_passed_pawns(const Position &pos, EvalInfo &ei) { - bool hasUnstoppable[2] = {false, false}; - int movesToGo[2] = {100, 100}; + const Color Them = (Us == WHITE ? BLACK : WHITE); - for(Color us = WHITE; us <= BLACK; us++) { - Color them = opposite_color(us); - Square ourKingSq = pos.king_square(us); - Square theirKingSq = pos.king_square(them); - Bitboard b = ei.pi->passed_pawns() & pos.pawns(us), b2, b3, b4; + Bitboard b2, b3, b4; + Square ourKingSq = pos.king_square(Us); + Square theirKingSq = pos.king_square(Them); + Bitboard b = ei.pi->passed_pawns() & pos.pieces(PAWN, Us); - while(b) { + while (b) + { Square s = pop_1st_bit(&b); - assert(pos.piece_on(s) == pawn_of_color(us)); - assert(pos.pawn_is_passed(us, s)); - int r = int(relative_rank(us, s) - RANK_2); - int tr = Max(0, r * (r-1)); - Square blockSq = s + pawn_push(us); + assert(pos.piece_on(s) == piece_of_color_and_type(Us, PAWN)); + assert(pos.pawn_is_passed(Us, s)); + + int r = int(relative_rank(Us, s) - RANK_2); + int tr = Max(0, r * (r - 1)); - // Base bonus based on rank: + // Base bonus based on rank Value mbonus = Value(20 * tr); Value ebonus = Value(10 + r * r * 10); - // Adjust bonus based on king proximity: - ebonus -= Value(square_distance(ourKingSq, blockSq) * 3 * tr); - ebonus -= - Value(square_distance(ourKingSq, blockSq + pawn_push(us)) * 1 * tr); - ebonus += Value(square_distance(theirKingSq, blockSq) * 6 * tr); - - // If the pawn is free to advance, increase bonus: - if(pos.square_is_empty(blockSq)) { - - b2 = squares_in_front_of(us, s); - b3 = b2 & ei.attacked_by(them); - b4 = b2 & ei.attacked_by(us); - if((b2 & pos.pieces_of_color(them)) == EmptyBoardBB) { - // There are no enemy pieces in the pawn's path! Are any of the - // squares in the pawn's path attacked by the enemy? - if(b3 == EmptyBoardBB) - // No enemy attacks, huge bonus! - ebonus += Value(tr * ((b2 == b4)? 17 : 15)); - else - // OK, there are enemy attacks. Are those squares which are - // attacked by the enemy also attacked by us? If yes, big bonus - // (but smaller than when there are no enemy attacks), if no, - // somewhat smaller bonus. - ebonus += Value(tr * (((b3 & b4) == b3)? 13 : 8)); - } - else { - // There are some enemy pieces in the pawn's path. While this is - // sad, we still assign a moderate bonus if all squares in the path - // which are either occupied by or attacked by enemy pieces are - // also attacked by us. - if(((b3 | (b2 & pos.pieces_of_color(them))) & ~b4) == EmptyBoardBB) - ebonus += Value(tr * 6); - } - // At last, add a small bonus when there are no *friendly* pieces - // in the pawn's path: - if((b2 & pos.pieces_of_color(us)) == EmptyBoardBB) - ebonus += Value(tr); - } + // Adjust bonus based on king proximity + if (tr) + { + Square blockSq = s + pawn_push(Us); + + ebonus -= Value(square_distance(ourKingSq, blockSq) * 3 * tr); + ebonus -= Value(square_distance(ourKingSq, blockSq + pawn_push(Us)) * 1 * tr); + ebonus += Value(square_distance(theirKingSq, blockSq) * 6 * tr); + + // If the pawn is free to advance, increase bonus + if (pos.square_is_empty(blockSq)) + { + // There are no enemy pawns in the pawn's path + b2 = squares_in_front_of(Us, s); + + assert((b2 & pos.pieces(PAWN, Them)) == EmptyBoardBB); + + // Squares attacked by us + b4 = b2 & ei.attacked_by(Us); + + // Squares attacked or occupied by enemy pieces + b3 = b2 & (ei.attacked_by(Them) | pos.pieces_of_color(Them)); + + // If there is an enemy rook or queen attacking the pawn from behind, + // add all X-ray attacks by the rook or queen. + if ( (squares_behind(Us, s) & pos.pieces(ROOK, QUEEN, Them)) + && (squares_behind(Us, s) & pos.pieces(ROOK, QUEEN, Them) & pos.attacks_from(s))) + b3 = b2; + + // Are any of the squares in the pawn's path attacked or occupied by the enemy? + if (b3 == EmptyBoardBB) + // No enemy attacks or pieces, huge bonus! + // Even bigger if we protect the pawn's path + ebonus += Value(tr * (b2 == b4 ? 17 : 15)); + else + // OK, there are enemy attacks or pieces (but not pawns). Are those + // squares which are attacked by the enemy also attacked by us ? + // If yes, big bonus (but smaller than when there are no enemy attacks), + // if no, somewhat smaller bonus. + ebonus += Value(tr * ((b3 & b4) == b3 ? 13 : 8)); + + // At last, add a small bonus when there are no *friendly* pieces + // in the pawn's path. + if ((b2 & pos.pieces_of_color(Us)) == EmptyBoardBB) + ebonus += Value(tr); + } + } // tr != 0 - // If the pawn is supported by a friendly pawn, increase bonus. - b2 = pos.pawns(us) & neighboring_files_bb(s); - if(b2 & rank_bb(s)) - ebonus += Value(r * 20); - else if(pos.pawn_attacks(them, s) & b2) - ebonus += Value(r * 12); + // If the pawn is supported by a friendly pawn, increase bonus + b2 = pos.pieces(PAWN, Us) & neighboring_files_bb(s); + if (b2 & rank_bb(s)) + ebonus += Value(r * 20); + else if (pos.attacks_from(s, Them) & b2) + ebonus += Value(r * 12); // If the other side has only a king, check whether the pawn is - // unstoppable: - if(pos.non_pawn_material(them) == Value(0)) { - Square qsq; - int d; - - qsq = relative_square(us, make_square(square_file(s), RANK_8)); - d = square_distance(s, qsq) - square_distance(theirKingSq, qsq) - + ((us == pos.side_to_move())? 0 : 1); - - if(d < 0) { - int mtg = RANK_8 - relative_rank(us, s); - int blockerCount = - count_1s_max_15(squares_in_front_of(us,s)&pos.occupied_squares()); - mtg += blockerCount; - d += blockerCount; - if(d < 0) { - hasUnstoppable[us] = true; - movesToGo[us] = Min(movesToGo[us], mtg); + // unstoppable + if (pos.non_pawn_material(Them) == Value(0)) + { + Square qsq; + int d; + + qsq = relative_square(Us, make_square(square_file(s), RANK_8)); + d = square_distance(s, qsq) + - square_distance(theirKingSq, qsq) + + (Us != pos.side_to_move()); + + if (d < 0) + { + int mtg = RANK_8 - relative_rank(Us, s); + int blockerCount = count_1s_max_15(squares_in_front_of(Us,s) & pos.occupied_squares()); + mtg += blockerCount; + d += blockerCount; + if (d < 0 && (!movesToGo[Us] || movesToGo[Us] > mtg)) + { + movesToGo[Us] = mtg; + pawnToGo[Us] = s; + } } - } } - // Rook pawns are a special case: They are sometimes worse, and - // sometimes better than other passed pawns. It is difficult to find - // good rules for determining whether they are good or bad. For now, - // we try the following: Increase the value for rook pawns if the + + // Rook pawns are a special case: They are sometimes worse, and + // sometimes better than other passed pawns. It is difficult to find + // good rules for determining whether they are good or bad. For now, + // we try the following: Increase the value for rook pawns if the // other side has no pieces apart from a knight, and decrease the // value if the other side has a rook or queen. - if(square_file(s) == FILE_A || square_file(s) == FILE_H) { - if(pos.non_pawn_material(them) == KnightValueMidgame - && pos.piece_count(them, KNIGHT) == 1) - ebonus += ebonus / 4; - else if(pos.rooks_and_queens(them)) - ebonus -= ebonus / 4; + if (square_file(s) == FILE_A || square_file(s) == FILE_H) + { + if ( pos.non_pawn_material(Them) <= KnightValueMidgame + && pos.piece_count(Them, KNIGHT) <= 1) + ebonus += ebonus / 4; + else if (pos.pieces(ROOK, QUEEN, Them)) + ebonus -= ebonus / 4; } // Add the scores for this pawn to the middle game and endgame eval. - ei.mgValue += apply_weight(Sign[us] * mbonus, WeightPassedPawnsMidgame); - ei.egValue += apply_weight(Sign[us] * ebonus, WeightPassedPawnsEndgame); - } + ei.value += Sign[Us] * apply_weight(make_score(mbonus, ebonus), WeightPassedPawns); + + } // while + } + + + // evaluate_passed_pawns() evaluates the passed pawns for both sides + + void evaluate_passed_pawns(const Position& pos, EvalInfo& ei) { + + int movesToGo[2] = {0, 0}; + Square pawnToGo[2] = {SQ_NONE, SQ_NONE}; + + // Evaluate pawns for each color + evaluate_passed_pawns_of_color(pos, movesToGo, pawnToGo, ei); + evaluate_passed_pawns_of_color(pos, movesToGo, pawnToGo, ei); + + // Neither side has an unstoppable passed pawn? + if (!(movesToGo[WHITE] | movesToGo[BLACK])) + return; + + // Does only one side have an unstoppable passed pawn? + if (!movesToGo[WHITE] || !movesToGo[BLACK]) + { + Color winnerSide = movesToGo[WHITE] ? WHITE : BLACK; + ei.value += make_score(0, Sign[winnerSide] * (UnstoppablePawnValue - Value(0x40 * movesToGo[winnerSide]))); } + else + { // Both sides have unstoppable pawns! Try to find out who queens + // first. We begin by transforming 'movesToGo' to the number of + // plies until the pawn queens for both sides. + movesToGo[WHITE] *= 2; + movesToGo[BLACK] *= 2; + movesToGo[pos.side_to_move()]--; + + Color winnerSide = movesToGo[WHITE] < movesToGo[BLACK] ? WHITE : BLACK; + Color loserSide = opposite_color(winnerSide); + + // If one side queens at least three plies before the other, that side wins + if (movesToGo[winnerSide] <= movesToGo[loserSide] - 3) + ei.value += Sign[winnerSide] * make_score(0, UnstoppablePawnValue - Value(0x40 * (movesToGo[winnerSide]/2))); + + // If one side queens one ply before the other and checks the king or attacks + // the undefended opponent's queening square, that side wins. To avoid cases + // where the opponent's king could move somewhere before first pawn queens we + // consider only free paths to queen for both pawns. + else if ( !(squares_in_front_of(WHITE, pawnToGo[WHITE]) & pos.occupied_squares()) + && !(squares_in_front_of(BLACK, pawnToGo[BLACK]) & pos.occupied_squares())) + { + assert(movesToGo[loserSide] - movesToGo[winnerSide] == 1); + + Square winnerQSq = relative_square(winnerSide, make_square(square_file(pawnToGo[winnerSide]), RANK_8)); + Square loserQSq = relative_square(loserSide, make_square(square_file(pawnToGo[loserSide]), RANK_8)); + + Bitboard b = pos.occupied_squares(); + clear_bit(&b, pawnToGo[winnerSide]); + clear_bit(&b, pawnToGo[loserSide]); + b = queen_attacks_bb(winnerQSq, b); - // Does either side have an unstoppable passed pawn? - if(hasUnstoppable[WHITE] && !hasUnstoppable[BLACK]) - ei.egValue += UnstoppablePawnValue - Value(0x40 * movesToGo[WHITE]); - else if(hasUnstoppable[BLACK] && !hasUnstoppable[WHITE]) - ei.egValue -= UnstoppablePawnValue - Value(0x40 * movesToGo[BLACK]); - else if(hasUnstoppable[BLACK] && hasUnstoppable[WHITE]) { - // Both sides have unstoppable pawns! Try to find out who queens - // first. We begin by transforming 'movesToGo' to the number of - // plies until the pawn queens for both sides: - movesToGo[WHITE] *= 2; - movesToGo[BLACK] *= 2; - movesToGo[pos.side_to_move()]--; - - // If one side queens at least three plies before the other, that - // side wins: - if(movesToGo[WHITE] <= movesToGo[BLACK] - 3) - ei.egValue += UnstoppablePawnValue - Value(0x40 * (movesToGo[WHITE]/2)); - else if(movesToGo[BLACK] <= movesToGo[WHITE] - 3) - ei.egValue -= UnstoppablePawnValue - Value(0x40 * (movesToGo[BLACK]/2)); - - // We could also add some rules about the situation when one side - // queens exactly one ply before the other: Does the first queen - // check the opponent's king, or attack the opponent's queening square? - // This is slightly tricky to get right, because it is possible that - // the opponent's king has moved somewhere before the first pawn queens. + if ( (b & pos.pieces(KING, loserSide)) + ||(bit_is_set(b, loserQSq) && !bit_is_set(ei.attacked_by(loserSide), loserQSq))) + ei.value += Sign[winnerSide] * make_score(0, UnstoppablePawnValue - Value(0x40 * (movesToGo[winnerSide]/2))); + } } } @@ -1045,64 +1060,63 @@ namespace { // (a2/h2 for black) is trapped by enemy pawns, and assigns a penalty // if it is. - void evaluate_trapped_bishop_a7h7(const Position &pos, Square s, Color us, - EvalInfo &ei) { + void evaluate_trapped_bishop_a7h7(const Position& pos, Square s, Color us, EvalInfo &ei) { assert(square_is_ok(s)); - assert(pos.piece_on(s) == bishop_of_color(us)); + assert(pos.piece_on(s) == piece_of_color_and_type(us, BISHOP)); Square b6 = relative_square(us, (square_file(s) == FILE_A) ? SQ_B6 : SQ_G6); Square b8 = relative_square(us, (square_file(s) == FILE_A) ? SQ_B8 : SQ_G8); - if ( pos.piece_on(b6) == pawn_of_color(opposite_color(us)) + if ( pos.piece_on(b6) == piece_of_color_and_type(opposite_color(us), PAWN) && pos.see(s, b6) < 0 && pos.see(s, b8) < 0) { - ei.mgValue -= Sign[us] * TrappedBishopA7H7Penalty; - ei.egValue -= Sign[us] * TrappedBishopA7H7Penalty; + ei.value -= Sign[us] * TrappedBishopA7H7Penalty; } } // evaluate_trapped_bishop_a1h1() determines whether a bishop on a1/h1 // (a8/h8 for black) is trapped by a friendly pawn on b2/g2 (b7/g7 for - // black), and assigns a penalty if it is. This pattern can obviously + // black), and assigns a penalty if it is. This pattern can obviously // only occur in Chess960 games. - void evaluate_trapped_bishop_a1h1(const Position &pos, Square s, Color us, - EvalInfo &ei) { - Piece pawn = pawn_of_color(us); + void evaluate_trapped_bishop_a1h1(const Position& pos, Square s, Color us, EvalInfo& ei) { + + Piece pawn = piece_of_color_and_type(us, PAWN); Square b2, b3, c3; assert(Chess960); assert(square_is_ok(s)); - assert(pos.piece_on(s) == bishop_of_color(us)); + assert(pos.piece_on(s) == piece_of_color_and_type(us, BISHOP)); - if(square_file(s) == FILE_A) { - b2 = relative_square(us, SQ_B2); - b3 = relative_square(us, SQ_B3); - c3 = relative_square(us, SQ_C3); + if (square_file(s) == FILE_A) + { + b2 = relative_square(us, SQ_B2); + b3 = relative_square(us, SQ_B3); + c3 = relative_square(us, SQ_C3); } - else { - b2 = relative_square(us, SQ_G2); - b3 = relative_square(us, SQ_G3); - c3 = relative_square(us, SQ_F3); + else + { + b2 = relative_square(us, SQ_G2); + b3 = relative_square(us, SQ_G3); + c3 = relative_square(us, SQ_F3); } - if(pos.piece_on(b2) == pawn) { - Value penalty; + if (pos.piece_on(b2) == pawn) + { + Score penalty; - if(!pos.square_is_empty(b3)) - penalty = 2*TrappedBishopA1H1Penalty; - else if(pos.piece_on(c3) == pawn) - penalty = TrappedBishopA1H1Penalty; - else - penalty = TrappedBishopA1H1Penalty / 2; + if (!pos.square_is_empty(b3)) + penalty = 2 * TrappedBishopA1H1Penalty; + else if (pos.piece_on(c3) == pawn) + penalty = TrappedBishopA1H1Penalty; + else + penalty = TrappedBishopA1H1Penalty / 2; - ei.mgValue -= Sign[us] * penalty; - ei.egValue -= Sign[us] * penalty; + ei.value -= Sign[us] * penalty; } - } @@ -1112,44 +1126,37 @@ namespace { // squares one, two or three squares behind a friendly pawn are counted // twice. Finally, the space bonus is scaled by a weight taken from the // material hash table. + template + void evaluate_space(const Position& pos, EvalInfo& ei) { - void evaluate_space(const Position &pos, Color us, EvalInfo &ei) { - - Color them = opposite_color(us); + const Color Them = (Us == WHITE ? BLACK : WHITE); // Find the safe squares for our pieces inside the area defined by - // SpaceMask[us]. A square is unsafe it is attacked by an enemy + // SpaceMask[us]. A square is unsafe if it is attacked by an enemy // pawn, or if it is undefended and attacked by an enemy piece. - Bitboard safeSquares = - SpaceMask[us] & ~pos.pawns(us) & ~ei.attacked_by(them, PAWN) - & ~(~ei.attacked_by(us) & ei.attacked_by(them)); + Bitboard safeSquares = SpaceMask[Us] + & ~pos.pieces(PAWN, Us) + & ~ei.attacked_by(Them, PAWN) + & ~(~ei.attacked_by(Us) & ei.attacked_by(Them)); // Find all squares which are at most three squares behind some friendly // pawn. - Bitboard behindFriendlyPawns = pos.pawns(us); - if(us == WHITE) { - behindFriendlyPawns |= (behindFriendlyPawns >> 8); - behindFriendlyPawns |= (behindFriendlyPawns >> 16); - } - else { - behindFriendlyPawns |= (behindFriendlyPawns << 8); - behindFriendlyPawns |= (behindFriendlyPawns << 16); - } + Bitboard behindFriendlyPawns = pos.pieces(PAWN, Us); + behindFriendlyPawns |= (Us == WHITE ? behindFriendlyPawns >> 8 : behindFriendlyPawns << 8); + behindFriendlyPawns |= (Us == WHITE ? behindFriendlyPawns >> 16 : behindFriendlyPawns << 16); - int space = - count_1s_max_15(safeSquares) - + count_1s_max_15(behindFriendlyPawns & safeSquares); + int space = count_1s_max_15(safeSquares) + + count_1s_max_15(behindFriendlyPawns & safeSquares); - ei.mgValue += Sign[us] * - apply_weight(Value(space * ei.mi->space_weight()), WeightSpace); + ei.value += Sign[Us] * apply_weight(make_score(space * ei.mi->space_weight(), 0), WeightSpace); } - // apply_weight() applies an evaluation weight to a value + // apply_weight() applies an evaluation weight to a value trying to prevent overflow - inline Value apply_weight(Value v, int w) { - return (v*w) / 0x100; + inline Score apply_weight(Score v, Score w) { + return make_score((int(mg_value(v)) * mg_value(w)) / 0x100, (int(eg_value(v)) * eg_value(w)) / 0x100); } @@ -1157,44 +1164,37 @@ namespace { // score, based on game phase. It also scales the return value by a // ScaleFactor array. - Value scale_by_game_phase(Value mv, Value ev, Phase ph, const ScaleFactor sf[]) { + Value scale_by_game_phase(const Score& v, Phase ph, const ScaleFactor sf[]) { - assert(mv > -VALUE_INFINITE && mv < VALUE_INFINITE); - assert(ev > -VALUE_INFINITE && ev < VALUE_INFINITE); + assert(mg_value(v) > -VALUE_INFINITE && mg_value(v) < VALUE_INFINITE); + assert(eg_value(v) > -VALUE_INFINITE && eg_value(v) < VALUE_INFINITE); assert(ph >= PHASE_ENDGAME && ph <= PHASE_MIDGAME); - ev = apply_scale_factor(ev, sf[(ev > Value(0) ? WHITE : BLACK)]); - - Value result = Value(int((mv * ph + ev * (128 - ph)) / 128)); - return Value(int(result) & ~(GrainSize - 1)); - } - - - // count_1s_8bit() counts the number of nonzero bits in the 8 least - // significant bits of a Bitboard. This function is used by the king - // shield evaluation. + Value ev = apply_scale_factor(eg_value(v), sf[(eg_value(v) > Value(0) ? WHITE : BLACK)]); - int count_1s_8bit(Bitboard b) { - return int(BitCount8Bit[b & 0xFF]); + int result = (mg_value(v) * ph + ev * (128 - ph)) / 128; + return Value(result & ~(GrainSize - 1)); } - // compute_weight() computes the value of an evaluation weight, by combining - // an UCI-configurable weight with an internal weight. + // weight_option() computes the value of an evaluation weight, by combining + // two UCI-configurable weights (midgame and endgame) with an internal weight. - int compute_weight(int uciWeight, int internalWeight) { - uciWeight = (uciWeight * 0x100) / 100; - return (uciWeight * internalWeight) / 0x100; - } + Score weight_option(const std::string& mgOpt, const std::string& egOpt, Score internalWeight) { + Score uciWeight = make_score(get_option_value_int(mgOpt), get_option_value_int(egOpt)); - // helper used in read_weights() - int weight_option(const std::string& opt, int weight) { + // Convert to integer to prevent overflow + int mg = mg_value(uciWeight); + int eg = eg_value(uciWeight); - return compute_weight(get_option_value_int(opt), weight); + mg = (mg * 0x100) / 100; + eg = (eg * 0x100) / 100; + mg = (mg * mg_value(internalWeight)) / 0x100; + eg = (eg * eg_value(internalWeight)) / 0x100; + return make_score(mg, eg); } - // init_safety() initizes the king safety evaluation, based on UCI // parameters. It is called from read_weights(). @@ -1219,9 +1219,9 @@ namespace { { if (i < b) SafetyTable[i] = Value(0); - else if(quad) + else if (quad) SafetyTable[i] = Value((int)(a * (i - b) * (i - b))); - else if(linear) + else if (linear) SafetyTable[i] = Value((int)(100 * a * (i - b))); } @@ -1235,5 +1235,4 @@ namespace { SafetyTable[i] = Value(peak); } } - }