X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fmovepick.cpp;h=2a090b1b30c38640f0fe2d656d85ecf851fea14e;hp=e2428554249c7a81e6cb6641ff2769715e11745f;hb=a795187c50cdbe00d5364ce049d8673a04803c21;hpb=cca34e234cc98ed4b61e75a25f8cd0d917c2a3fa diff --git a/src/movepick.cpp b/src/movepick.cpp index e2428554..2a090b1b 100644 --- a/src/movepick.cpp +++ b/src/movepick.cpp @@ -35,7 +35,7 @@ namespace { STOP }; - // Our insertion sort, guaranteed to be stable, as is needed + // Our insertion sort, which is guaranteed (and also needed) to be stable void insertion_sort(ExtMove* begin, ExtMove* end) { ExtMove tmp, *p, *q; @@ -50,12 +50,12 @@ namespace { } // Unary predicate used by std::partition to split positive scores from remaining - // ones so to sort separately the two sets, and with the second sort delayed. + // ones so as to sort the two sets separately, with the second sort delayed. inline bool has_positive_score(const ExtMove& ms) { return ms.score > 0; } - // Picks and moves to the front the best move in the range [begin, end), - // it is faster than sorting all the moves in advance when moves are few, as - // normally are the possible captures. + // Picks the best move in the range (begin, end) and moves it to the front. + // It's faster than sorting all the moves in advance when there are few + // moves e.g. possible captures. inline ExtMove* pick_best(ExtMove* begin, ExtMove* end) { std::swap(*begin, *std::max_element(begin, end)); @@ -65,10 +65,10 @@ namespace { /// Constructors of the MovePicker class. As arguments we pass information -/// to help it to return the presumably good moves first, to decide which +/// to help it to return the (presumably) good moves first, to decide which /// moves to return (in the quiescence search, for instance, we only want to -/// search captures, promotions and some checks) and about how important good -/// move ordering is at the current node. +/// search captures, promotions and some checks) and how important good move +/// ordering is at the current node. MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const HistoryStats& h, Move* cm, Search::Stack* s) : pos(p), history(h), depth(d) { @@ -105,7 +105,7 @@ MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const HistoryStats& { stage = QSEARCH_1; - // Skip TT move if is not a capture or a promotion, this avoids qsearch + // Skip TT move if is not a capture or a promotion. This avoids qsearch // tree explosion due to a possible perpetual check or similar rare cases // when TT table is full. if (ttm && !pos.capture_or_promotion(ttm)) @@ -129,7 +129,8 @@ MovePicker::MovePicker(const Position& p, Move ttm, const HistoryStats& h, Piece stage = PROBCUT; - // In ProbCut we generate only captures better than parent's captured piece + // In ProbCut we generate only captures that are better than the parent's + // captured piece. captureThreshold = PieceValue[MG][pt]; ttMove = (ttm && pos.pseudo_legal(ttm) ? ttm : MOVE_NONE); @@ -153,10 +154,10 @@ void MovePicker::score() { // where it is possible to recapture with the hanging piece). Exchanging // big pieces before capturing a hanging piece probably helps to reduce // the subtree size. - // In main search we want to push captures with negative SEE values to - // badCaptures[] array, but instead of doing it now we delay till when - // the move has been picked up in pick_move_from_list(), this way we save - // some SEE calls in case we get a cutoff (idea from Pablo Vazquez). + // In main search we want to push captures with negative SEE values to the + // badCaptures[] array, but instead of doing it now we delay until the move + // has been picked up in pick_move_from_list(). This way we save some SEE + // calls in case we get a cutoff. Move m; for (ExtMove* it = moves; it != end; ++it) @@ -283,9 +284,9 @@ void MovePicker::generate_next() { /// next_move() is the most important method of the MovePicker class. It returns -/// a new pseudo legal move every time is called, until there are no more moves +/// a new pseudo legal move every time it is called, until there are no more moves /// left. It picks the move with the biggest score from a list of generated moves -/// taking care not returning the ttMove if has already been searched previously. +/// taking care not returning the ttMove if it has already been searched previously. template<> Move MovePicker::next_move() { @@ -299,7 +300,7 @@ Move MovePicker::next_move() { switch (stage) { case MAIN_SEARCH: case EVASION: case QSEARCH_0: case QSEARCH_1: case PROBCUT: - cur++; + ++cur; return ttMove; case CAPTURES_S1: