X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fmovepick.cpp;h=7e338dbf62de586ec2e14fa0346eaab44c36b875;hp=4b1fccc4fdc810db49cb461ec54d2502b5f4d716;hb=b088f0aefd658261e9231b556382acf532920513;hpb=2943e1ca3171341cd301b18280f3fa3b6bdda162
diff --git a/src/movepick.cpp b/src/movepick.cpp
index 4b1fccc4..7e338dbf 100644
--- a/src/movepick.cpp
+++ b/src/movepick.cpp
@@ -1,17 +1,19 @@
/*
- Glaurung, a UCI chess playing engine.
- Copyright (C) 2004-2008 Tord Romstad
+ Stockfish, a UCI chess playing engine derived from Glaurung 2.1
+ Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
+ Copyright (C) 2008-2009 Marco Costalba
- Glaurung is free software: you can redistribute it and/or modify
+ Stockfish is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
-
- Glaurung is distributed in the hope that it will be useful,
+
+
+ Stockfish is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
along with this program. If not, see .
*/
@@ -21,9 +23,11 @@
//// Includes
////
+#include
#include
#include "history.h"
+#include "evaluate.h"
#include "movegen.h"
#include "movepick.h"
#include "search.h"
@@ -38,16 +42,16 @@ namespace {
/// Variables
- MovePicker::MovegenPhase PhaseTable[32];
- int MainSearchPhaseIndex;
- int EvasionsPhaseIndex;
- int QsearchWithChecksPhaseIndex;
- int QsearchWithoutChecksPhaseIndex;
-
+ CACHE_LINE_ALIGNMENT
+ const MovegenPhaseT MainSearchPhaseTable[] = { PH_STOP, PH_NULL_MOVE, PH_TT_MOVES, PH_GOOD_CAPTURES, PH_KILLERS, PH_NONCAPTURES, PH_BAD_CAPTURES, PH_STOP};
+ const MovegenPhaseT MainSearchNoNullPhaseTable[] = { PH_STOP, PH_TT_MOVES, PH_GOOD_CAPTURES, PH_KILLERS, PH_NONCAPTURES, PH_BAD_CAPTURES, PH_STOP};
+ const MovegenPhaseT LowSearchPhaseTable[] = { PH_STOP, PH_TT_MOVES, PH_GOOD_CAPTURES, PH_NULL_MOVE, PH_KILLERS, PH_NONCAPTURES, PH_BAD_CAPTURES, PH_STOP};
+ const MovegenPhaseT EvasionsPhaseTable[] = { PH_STOP, PH_EVASIONS, PH_STOP};
+ const MovegenPhaseT QsearchWithChecksPhaseTable[] = { PH_STOP, PH_TT_MOVES, PH_QCAPTURES, PH_QCHECKS, PH_STOP};
+ const MovegenPhaseT QsearchWithoutChecksPhaseTable[] = { PH_STOP, PH_TT_MOVES, PH_QCAPTURES, PH_STOP};
}
-
////
//// Functions
////
@@ -60,31 +64,35 @@ namespace {
/// search captures, promotions and some checks) and about how important good
/// move ordering is at the current node.
-MovePicker::MovePicker(const Position& p, bool pvnode, Move ttm, Move mk,
- Move k1, Move k2, Depth d) : pos(p) {
- pvNode = pvnode;
- ttMove = ttm;
- mateKiller = (mk == ttm)? MOVE_NONE : mk;
- killer1 = k1;
- killer2 = k2;
- depth = d;
- movesPicked = 0;
- numOfMoves = 0;
- numOfBadCaptures = 0;
- dc = p.discovered_check_candidates(p.side_to_move());
-
- if(p.is_check())
- phaseIndex = EvasionsPhaseIndex;
- else if(depth > Depth(0))
- phaseIndex = MainSearchPhaseIndex;
- else if(depth == Depth(0))
- phaseIndex = QsearchWithChecksPhaseIndex;
+MovePicker::MovePicker(const Position& p, Move ttm, Depth d,
+ const History& h, SearchStack* ss, bool useNullMove) : pos(p), H(h) {
+ ttMoves[0] = ttm;
+ if (ss)
+ {
+ ttMoves[1] = (ss->mateKiller == ttm)? MOVE_NONE : ss->mateKiller;
+ killers[0] = ss->killers[0];
+ killers[1] = ss->killers[1];
+ } else
+ ttMoves[1] = killers[0] = killers[1] = MOVE_NONE;
+
+ movesPicked = numOfMoves = numOfBadCaptures = 0;
+ finished = false;
+
+ if (p.is_check())
+ phasePtr = EvasionsPhaseTable;
+ else if (d >= Depth(3 * OnePly))
+ phasePtr = useNullMove ? MainSearchPhaseTable : MainSearchNoNullPhaseTable;
+ else if (d > Depth(0))
+ phasePtr = useNullMove ? LowSearchPhaseTable : MainSearchNoNullPhaseTable;
+ else if (d == Depth(0))
+ phasePtr = QsearchWithChecksPhaseTable;
else
- phaseIndex = QsearchWithoutChecksPhaseIndex;
+ phasePtr = QsearchWithoutChecksPhaseTable;
- pinned = p.pinned_pieces(p.side_to_move());
+ Color us = pos.side_to_move();
- finished = false;
+ dc = p.discovered_check_candidates(us);
+ pinned = p.pinned_pieces(us);
}
@@ -99,7 +107,7 @@ Move MovePicker::get_next_move() {
while (true)
{
// If we already have a list of generated moves, pick the best move from
- // the list, and return it:
+ // the list, and return it.
move = pick_move_from_list();
if (move != MOVE_NONE)
{
@@ -107,59 +115,60 @@ Move MovePicker::get_next_move() {
return move;
}
- // Next phase:
- phaseIndex++;
- switch (PhaseTable[phaseIndex]) {
+ // Next phase
+ phasePtr++;
+ switch (*phasePtr) {
- case PH_TT_MOVE:
- if (ttMove != MOVE_NONE)
- {
- assert(move_is_ok(ttMove));
- if (generate_move_if_legal(pos, ttMove, pinned) != MOVE_NONE)
- return ttMove;
- }
- break;
+ case PH_NULL_MOVE:
+ return MOVE_NULL;
- case PH_MATE_KILLER:
- if (mateKiller != MOVE_NONE)
- {
- assert(move_is_ok(mateKiller));
- if (generate_move_if_legal(pos, mateKiller, pinned) != MOVE_NONE)
- return ttMove;
- }
+ case PH_TT_MOVES:
+ movesPicked = 0; // This is used as index to ttMoves[]
break;
- case PH_GOOD_CAPTURES:
+ case PH_GOOD_CAPTURES:
numOfMoves = generate_captures(pos, moves);
score_captures();
+ std::sort(moves, moves + numOfMoves);
movesPicked = 0;
break;
- case PH_BAD_CAPTURES:
- badCapturesPicked = 0;
+ case PH_KILLERS:
+ movesPicked = 0; // This is used as index to killers[]
break;
case PH_NONCAPTURES:
numOfMoves = generate_noncaptures(pos, moves);
score_noncaptures();
+ std::sort(moves, moves + numOfMoves);
+ movesPicked = 0;
+ break;
+
+ case PH_BAD_CAPTURES:
+ // Bad captures SEE value is already calculated so just sort them
+ // to get SEE move ordering.
+ std::sort(badCaptures, badCaptures + numOfBadCaptures);
movesPicked = 0;
break;
case PH_EVASIONS:
- assert(pos.is_check());
- numOfMoves = generate_evasions(pos, moves);
+ assert(pos.is_check());
+ numOfMoves = generate_evasions(pos, moves, pinned);
score_evasions();
+ std::sort(moves, moves + numOfMoves);
movesPicked = 0;
break;
- case PH_QCAPTURES:
+ case PH_QCAPTURES:
numOfMoves = generate_captures(pos, moves);
- score_qcaptures();
+ score_captures();
+ std::sort(moves, moves + numOfMoves);
movesPicked = 0;
break;
case PH_QCHECKS:
- numOfMoves = generate_checks(pos, moves, dc);
+ // Perhaps we should order moves move here? FIXME
+ numOfMoves = generate_non_capture_checks(pos, moves, dc);
movesPicked = 0;
break;
@@ -171,9 +180,6 @@ Move MovePicker::get_next_move() {
return MOVE_NONE;
}
}
- assert(false);
-
- return MOVE_NONE;
}
@@ -182,67 +188,75 @@ Move MovePicker::get_next_move() {
Move MovePicker::get_next_move(Lock &lock) {
- lock_grab(&lock);
- if (finished)
- {
- lock_release(&lock);
- return MOVE_NONE;
- }
- Move m = get_next_move();
- if (m == MOVE_NONE)
- finished = true;
-
- lock_release(&lock);
- return m;
+ lock_grab(&lock);
+ if (finished)
+ {
+ lock_release(&lock);
+ return MOVE_NONE;
+ }
+ Move m = get_next_move();
+ if (m == MOVE_NONE)
+ finished = true;
+
+ lock_release(&lock);
+ return m;
}
+
/// MovePicker::score_captures(), MovePicker::score_noncaptures(),
/// MovePicker::score_evasions() and MovePicker::score_qcaptures() assign a
/// numerical move ordering score to each move in a move list. The moves
-/// with highest scores will be picked first by
-/// MovePicker::pick_move_from_list().
+/// with highest scores will be picked first by pick_move_from_list().
void MovePicker::score_captures() {
// Winning and equal captures in the main search are ordered by MVV/LVA.
// Suprisingly, this appears to perform slightly better than SEE based
- // move ordering. The reason is probably that in a position with a winning
+ // move ordering. The reason is probably that in a position with a winning
// capture, capturing a more valuable (but sufficiently defended) piece
- // first usually doesn't hurt. The opponent will have to recapture, and
+ // first usually doesn't hurt. The opponent will have to recapture, and
// the hanging piece will still be hanging (except in the unusual cases
- // where it is possible to recapture with the hanging piece). Exchanging
+ // where it is possible to recapture with the hanging piece). Exchanging
// big pieces before capturing a hanging piece probably helps to reduce
// the subtree size.
+ // In main search we want to push captures with negative SEE values to
+ // badCaptures[] array, but instead of doing it now we delay till when
+ // the move has been picked up in pick_move_from_list(), this way we save
+ // some SEE calls in case we get a cutoff (idea from Pablo Vazquez).
+ Move m;
+
+ // Use MVV/LVA ordering
for (int i = 0; i < numOfMoves; i++)
{
- Move m = moves[i].move;
- moves[i].score = pos.see(m);
- if (moves[i].score >= 0)
- {
- moves[i].score = move_promotion(m) ? QueenValueMidgame
- : int(pos.midgame_value_of_piece_on(move_to(m)))
- -int(pos.type_of_piece_on(move_from(m)));
- // FIXME second term seems wrong !
- }
+ m = moves[i].move;
+ if (move_is_promotion(m))
+ moves[i].score = QueenValueMidgame;
+ else
+ moves[i].score = int(pos.midgame_value_of_piece_on(move_to(m)))
+ -int(pos.type_of_piece_on(move_from(m)));
}
}
void MovePicker::score_noncaptures() {
+ // First score by history, when no history is available then use
+ // piece/square tables values. This seems to be better then a
+ // random choice when we don't have an history for any move.
+ Piece piece;
+ Square from, to;
+ int hs;
for (int i = 0; i < numOfMoves; i++)
{
- Move m = moves[i].move;
- if (m == killer1)
- moves[i].score = HistoryMax + 2;
- else if (m == killer2)
- moves[i].score = HistoryMax + 1;
- else
- moves[i].score = H.move_ordering_score(pos.piece_on(move_from(m)), m);
+ from = move_from(moves[i].move);
+ to = move_to(moves[i].move);
+ piece = pos.piece_on(from);
+ hs = H.move_ordering_score(piece, to);
- // Ensure moves in history are always sorted as first
- if (moves[i].score > 0)
- moves[i].score += 1000;
+ // Ensure history is always preferred to pst
+ if (hs > 0)
+ hs += 1000;
- moves[i].score += pos.mg_pst_delta(moves[i].move);
+ // pst based scoring
+ moves[i].score = hs + pos.pst_delta(piece, from, to);
}
}
@@ -251,30 +265,14 @@ void MovePicker::score_evasions() {
for (int i = 0; i < numOfMoves; i++)
{
Move m = moves[i].move;
- if (m == ttMove)
+ if (m == ttMoves[0])
moves[i].score = 2*HistoryMax;
else if (!pos.square_is_empty(move_to(m)))
{
- moves[i].score = pos.see(m);
- if (moves[i].score >= 0)
- moves[i].score += HistoryMax;
- }
- else
- moves[i].score = H.move_ordering_score(pos.piece_on(move_from(m)), m);
- }
- // FIXME try psqt also here
-}
-
-void MovePicker::score_qcaptures() {
-
- // Use MVV/LVA ordering.
- for (int i = 0; i < numOfMoves; i++)
- {
- Move m = moves[i].move;
- moves[i].score = move_promotion(m) ? QueenValueMidgame
- : int(pos.midgame_value_of_piece_on(move_to(m)))
- -int(pos.midgame_value_of_piece_on(move_to(m))) / 64;
- // FIXME Why second term like that ???
+ int seeScore = pos.see(m);
+ moves[i].score = (seeScore >= 0)? seeScore + HistoryMax : seeScore;
+ } else
+ moves[i].score = H.move_ordering_score(pos.piece_on(move_from(m)), move_to(m));
}
}
@@ -283,166 +281,89 @@ void MovePicker::score_qcaptures() {
/// from a list of generated moves (moves[] or badCaptures[], depending on
/// the current move generation phase). It takes care not to return the
/// transposition table move if that has already been serched previously.
-/// While picking captures in the PH_GOOD_CAPTURES phase (i.e. while picking
-/// non-losing captures in the main search), it moves all captures with
-/// negative SEE values to the badCaptures[] array.
Move MovePicker::pick_move_from_list() {
- int bestScore = -10000000;
- int bestIndex;
- Move move;
+ assert(movesPicked >= 0);
+ assert(!pos.is_check() || *phasePtr == PH_EVASIONS || *phasePtr == PH_STOP);
+ assert( pos.is_check() || *phasePtr != PH_EVASIONS);
+
+ switch (*phasePtr) {
- switch (PhaseTable[phaseIndex]) {
+ case PH_TT_MOVES:
+ while (movesPicked < 2) {
+ Move move = ttMoves[movesPicked++];
+ if ( move != MOVE_NONE
+ && move_is_legal(pos, move, pinned))
+ return move;
+ }
+ break;
case PH_GOOD_CAPTURES:
- assert(!pos.is_check());
- assert(movesPicked >= 0);
while (movesPicked < numOfMoves)
{
- bestScore = -10000000;
- bestIndex = -1;
- for (int i = movesPicked; i < numOfMoves; i++)
- {
- if (moves[i].score < 0)
- {
- // Losing capture, move it to the badCaptures[] array
- assert(numOfBadCaptures < 63);
- badCaptures[numOfBadCaptures++] = moves[i];
- moves[i--] = moves[--numOfMoves];
- }
- else if (moves[i].score > bestScore)
- {
- bestIndex = i;
- bestScore = moves[i].score;
- }
- }
- if (bestIndex != -1) // Found a good capture
+ Move move = moves[movesPicked++].move;
+ if ( move != ttMoves[0]
+ && move != ttMoves[1]
+ && pos.pl_move_is_legal(move, pinned))
{
- move = moves[bestIndex].move;
- moves[bestIndex] = moves[movesPicked++];
- if ( move != ttMove
- && move != mateKiller
- && pos.move_is_legal(move, pinned))
+ // Check for a non negative SEE now
+ int seeValue = pos.see_sign(move);
+ if (seeValue >= 0)
return move;
+
+ // Losing capture, move it to the badCaptures[] array, note
+ // that move has now been already checked for legality.
+ assert(numOfBadCaptures < 63);
+ badCaptures[numOfBadCaptures].move = move;
+ badCaptures[numOfBadCaptures++].score = seeValue;
}
}
break;
- case PH_NONCAPTURES:
- assert(!pos.is_check());
- assert(movesPicked >= 0);
- while (movesPicked < numOfMoves)
- {
- // If this is a PV node or we have only picked a few moves, scan
- // the entire move list for the best move. If many moves have already
- // been searched and it is not a PV node, we are probably failing low
- // anyway, so we just pick the first move from the list.
- if (pvNode || movesPicked < 12)
- {
- bestScore = -10000000;
- bestIndex = -1;
- for (int i = movesPicked; i < numOfMoves; i++)
- if(moves[i].score > bestScore)
- {
- bestIndex = i;
- bestScore = moves[i].score;
- }
- } else
- bestIndex = movesPicked;
-
- if (bestIndex != -1)
- {
- move = moves[bestIndex].move;
- moves[bestIndex] = moves[movesPicked++];
- if ( move != ttMove
- && move != mateKiller
- && pos.move_is_legal(move, pinned))
- return move;
- }
- }
- break;
+ case PH_KILLERS:
+ while (movesPicked < 2) {
+ Move move = killers[movesPicked++];
+ if ( move != MOVE_NONE
+ && move != ttMoves[0]
+ && move != ttMoves[1]
+ && move_is_legal(pos, move, pinned)
+ && !pos.move_is_capture(move))
+ return move;
+ }
+ break;
- case PH_EVASIONS:
- assert(pos.is_check());
- assert(movesPicked >= 0);
+ case PH_NONCAPTURES:
while (movesPicked < numOfMoves)
{
- bestScore = -10000000;
- bestIndex = -1;
- for (int i = movesPicked; i < numOfMoves; i++)
- if (moves[i].score > bestScore)
- {
- bestIndex = i;
- bestScore = moves[i].score;
- }
-
- if (bestIndex != -1)
- {
- move = moves[bestIndex].move;
- moves[bestIndex] = moves[movesPicked++];
+ Move move = moves[movesPicked++].move;
+ if ( move != ttMoves[0]
+ && move != ttMoves[1]
+ && move != killers[0]
+ && move != killers[1]
+ && pos.pl_move_is_legal(move, pinned))
return move;
- }
}
break;
- case PH_BAD_CAPTURES:
- assert(!pos.is_check());
- assert(badCapturesPicked >= 0);
- // It's probably a good idea to use SEE move ordering here, instead
- // of just picking the first move. FIXME
- while (badCapturesPicked < numOfBadCaptures)
- {
- move = badCaptures[badCapturesPicked++].move;
- if ( move != ttMove
- && move != mateKiller
- && pos.move_is_legal(move, pinned))
- return move;
- }
+ case PH_EVASIONS:
+ if (movesPicked < numOfMoves)
+ return moves[movesPicked++].move;
break;
- case PH_QCAPTURES:
- assert(!pos.is_check());
- assert(movesPicked >= 0);
- while (movesPicked < numOfMoves)
- {
- bestScore = -10000000;
- if (movesPicked < 4) // FIXME makes sens to score qcaps?
- {
- bestIndex = -1;
- for (int i = movesPicked; i < numOfMoves; i++)
- if(moves[i].score > bestScore)
- {
- bestIndex = i;
- bestScore = moves[i].score;
- }
- } else
- bestIndex = movesPicked;
-
- if (bestIndex != -1)
- {
- move = moves[bestIndex].move;
- moves[bestIndex] = moves[movesPicked++];
- // Remember to change the line below if we decide to hash the qsearch!
- // Maybe also postpone the legality check until after futility pruning?
- // FIXME !!!
- if (/* move != ttMove && */ pos.move_is_legal(move, pinned))
- return move;
- }
- }
+ case PH_BAD_CAPTURES:
+ if (movesPicked < numOfBadCaptures)
+ return badCaptures[movesPicked++].move;
break;
+ case PH_QCAPTURES:
case PH_QCHECKS:
- assert(!pos.is_check());
- assert(movesPicked >= 0);
- // Perhaps we should do something better than just picking the first
- // move here? FIXME
while (movesPicked < numOfMoves)
{
- move = moves[movesPicked++].move;
- // Remember to change the line below if we decide to hash the qsearch!
- // FIXME !!!
- if (/* move != ttMove && */ pos.move_is_legal(move, pinned))
+ Move move = moves[movesPicked++].move;
+ // Maybe postpone the legality check until after futility pruning?
+ if ( move != ttMoves[0]
+ && pos.pl_move_is_legal(move, pinned))
return move;
}
break;
@@ -452,50 +373,3 @@ Move MovePicker::pick_move_from_list() {
}
return MOVE_NONE;
}
-
-
-/// MovePicker::current_move_type() returns the type of the just
-/// picked next move. It can be used in search to further differentiate
-/// according to the current move type: capture, non capture, escape, etc.
-MovePicker::MovegenPhase MovePicker::current_move_type() const {
- return PhaseTable[phaseIndex];
-}
-
-
-/// MovePicker::init_phase_table() initializes the PhaseTable[],
-/// MainSearchPhaseIndex, EvasionPhaseIndex, QsearchWithChecksPhaseIndex
-/// and QsearchWithoutChecksPhaseIndex variables. It is only called once
-/// during program startup, and never again while the program is running.
-
-void MovePicker::init_phase_table() {
-
- int i = 0;
-
- // Main search
- MainSearchPhaseIndex = i - 1;
- PhaseTable[i++] = PH_TT_MOVE;
- PhaseTable[i++] = PH_MATE_KILLER;
- PhaseTable[i++] = PH_GOOD_CAPTURES;
- // PH_KILLER_1 and PH_KILLER_2 are not yet used.
- // PhaseTable[i++] = PH_KILLER_1;
- // PhaseTable[i++] = PH_KILLER_2;
- PhaseTable[i++] = PH_NONCAPTURES;
- PhaseTable[i++] = PH_BAD_CAPTURES;
- PhaseTable[i++] = PH_STOP;
-
- // Check evasions
- EvasionsPhaseIndex = i - 1;
- PhaseTable[i++] = PH_EVASIONS;
- PhaseTable[i++] = PH_STOP;
-
- // Quiescence search with checks
- QsearchWithChecksPhaseIndex = i - 1;
- PhaseTable[i++] = PH_QCAPTURES;
- PhaseTable[i++] = PH_QCHECKS;
- PhaseTable[i++] = PH_STOP;
-
- // Quiescence search without checks
- QsearchWithoutChecksPhaseIndex = i - 1;
- PhaseTable[i++] = PH_QCAPTURES;
- PhaseTable[i++] = PH_STOP;
-}