X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fmovepick.cpp;h=9ada404b299bacc6c5c127c66eab4ce32a303987;hp=ea435026241f21b72275af2fd0585b35480ff9a8;hb=67338e6f322b8f8ec0d897815e16a87937efc9b0;hpb=d6b04c27989bba77b23474f5b6f75974c7199644
diff --git a/src/movepick.cpp b/src/movepick.cpp
index ea435026..9ada404b 100644
--- a/src/movepick.cpp
+++ b/src/movepick.cpp
@@ -1,7 +1,7 @@
/*
Stockfish, a UCI chess playing engine derived from Glaurung 2.1
Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
- Copyright (C) 2008-2009 Marco Costalba
+ Copyright (C) 2008-2012 Marco Costalba, Joona Kiiski, Tord Romstad
Stockfish is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -18,90 +18,138 @@
along with this program. If not, see .
*/
-
-////
-//// Includes
-////
-
#include
#include
-#include "history.h"
#include "movegen.h"
#include "movepick.h"
#include "search.h"
-#include "value.h"
-
-
-////
-//// Local definitions
-////
+#include "types.h"
namespace {
enum MovegenPhase {
- PH_TT_MOVES, // Transposition table move and mate killer
- PH_GOOD_CAPTURES, // Queen promotions and captures with SEE values >= 0
- PH_KILLERS, // Killer moves from the current ply
- PH_NONCAPTURES, // Non-captures and underpromotions
- PH_BAD_CAPTURES, // Queen promotions and captures with SEE values < 0
- PH_EVASIONS, // Check evasions
- PH_QCAPTURES, // Captures in quiescence search
- PH_QCHECKS, // Non-capture checks in quiescence search
+ PH_TT_MOVE, // Transposition table move
+ PH_GOOD_CAPTURES, // Queen promotions and captures with SEE values >= captureThreshold (captureThreshold <= 0)
+ PH_GOOD_PROBCUT, // Queen promotions and captures with SEE values > captureThreshold (captureThreshold >= 0)
+ PH_KILLERS, // Killer moves from the current ply
+ PH_NONCAPTURES_1, // Non-captures and underpromotions with positive score
+ PH_NONCAPTURES_2, // Non-captures and underpromotions with non-positive score
+ PH_BAD_CAPTURES, // Queen promotions and captures with SEE values < captureThreshold (captureThreshold <= 0)
+ PH_EVASIONS, // Check evasions
+ PH_QCAPTURES, // Captures in quiescence search
+ PH_QRECAPTURES, // Recaptures in quiescence search
+ PH_QCHECKS, // Non-capture checks in quiescence search
PH_STOP
};
CACHE_LINE_ALIGNMENT
- const uint8_t MainSearchPhaseTable[] = { PH_TT_MOVES, PH_GOOD_CAPTURES, PH_KILLERS, PH_NONCAPTURES, PH_BAD_CAPTURES, PH_STOP};
- const uint8_t EvasionsPhaseTable[] = { PH_EVASIONS, PH_STOP};
- const uint8_t QsearchWithChecksPhaseTable[] = { PH_TT_MOVES, PH_QCAPTURES, PH_QCHECKS, PH_STOP};
- const uint8_t QsearchWithoutChecksPhaseTable[] = { PH_TT_MOVES, PH_QCAPTURES, PH_STOP};
+ const uint8_t MainSearchTable[] = { PH_TT_MOVE, PH_GOOD_CAPTURES, PH_KILLERS, PH_NONCAPTURES_1, PH_NONCAPTURES_2, PH_BAD_CAPTURES, PH_STOP };
+ const uint8_t EvasionTable[] = { PH_TT_MOVE, PH_EVASIONS, PH_STOP };
+ const uint8_t QsearchWithChecksTable[] = { PH_TT_MOVE, PH_QCAPTURES, PH_QCHECKS, PH_STOP };
+ const uint8_t QsearchWithoutChecksTable[] = { PH_TT_MOVE, PH_QCAPTURES, PH_STOP };
+ const uint8_t QsearchRecapturesTable[] = { PH_TT_MOVE, PH_QRECAPTURES, PH_STOP };
+ const uint8_t ProbCutTable[] = { PH_TT_MOVE, PH_GOOD_PROBCUT, PH_STOP };
+
+ // Unary predicate used by std::partition to split positive scores from remaining
+ // ones so to sort separately the two sets, and with the second sort delayed.
+ inline bool has_positive_score(const MoveStack& move) { return move.score > 0; }
+
+ // Picks and pushes to the front the best move in range [firstMove, lastMove),
+ // it is faster than sorting all the moves in advance when moves are few, as
+ // normally are the possible captures.
+ inline MoveStack* pick_best(MoveStack* firstMove, MoveStack* lastMove)
+ {
+ std::swap(*firstMove, *std::max_element(firstMove, lastMove));
+ return firstMove;
+ }
}
-
-////
-//// Functions
-////
-
-
-/// Constructor for the MovePicker class. Apart from the position for which
-/// it is asked to pick legal moves, MovePicker also wants some information
+/// Constructors for the MovePicker class. As arguments we pass information
/// to help it to return the presumably good moves first, to decide which
/// moves to return (in the quiescence search, for instance, we only want to
/// search captures, promotions and some checks) and about how important good
/// move ordering is at the current node.
-MovePicker::MovePicker(const Position& p, Move ttm, Depth d,
- const History& h, SearchStack* ss) : pos(p), H(h) {
- int searchTT = ttm;
- ttMoves[0].move = ttm;
- finished = false;
- lastBadCapture = badCaptures;
+MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const History& h,
+ Search::Stack* ss, Value beta) : pos(p), H(h), depth(d) {
+ captureThreshold = 0;
+ badCaptures = moves + MAX_MOVES;
- if (ss)
+ assert(d > DEPTH_ZERO);
+
+ if (p.in_check())
+ {
+ killers[0].move = killers[1].move = MOVE_NONE;
+ phasePtr = EvasionTable;
+ }
+ else
{
- ttMoves[1].move = (ss->mateKiller == ttm)? MOVE_NONE : ss->mateKiller;
- searchTT |= ttMoves[1].move;
killers[0].move = ss->killers[0];
killers[1].move = ss->killers[1];
- } else
- ttMoves[1].move = killers[0].move = killers[1].move = MOVE_NONE;
- Color us = pos.side_to_move();
+ // Consider sligtly negative captures as good if at low depth and far from beta
+ if (ss && ss->eval < beta - PawnValueMidgame && d < 3 * ONE_PLY)
+ captureThreshold = -PawnValueMidgame;
+
+ // Consider negative captures as good if still enough to reach beta
+ else if (ss && ss->eval > beta)
+ captureThreshold = beta - ss->eval;
+
+ phasePtr = MainSearchTable;
+ }
+
+ ttMove = (ttm && pos.is_pseudo_legal(ttm) ? ttm : MOVE_NONE);
+ phasePtr += int(ttMove == MOVE_NONE) - 1;
+ go_next_phase();
+}
+
+MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const History& h, Square recaptureSq)
+ : pos(p), H(h) {
- dc = p.discovered_check_candidates(us);
- pinned = p.pinned_pieces(us);
+ assert(d <= DEPTH_ZERO);
- if (p.is_check())
- phasePtr = EvasionsPhaseTable;
- else if (d > Depth(0))
- phasePtr = MainSearchPhaseTable + !searchTT;
- else if (d == Depth(0))
- phasePtr = QsearchWithChecksPhaseTable + !searchTT;
+ if (p.in_check())
+ phasePtr = EvasionTable;
+ else if (d >= DEPTH_QS_CHECKS)
+ phasePtr = QsearchWithChecksTable;
+ else if (d >= DEPTH_QS_RECAPTURES)
+ {
+ phasePtr = QsearchWithoutChecksTable;
+
+ // Skip TT move if is not a capture or a promotion, this avoids
+ // qsearch tree explosion due to a possible perpetual check or
+ // similar rare cases when TT table is full.
+ if (ttm != MOVE_NONE && !pos.is_capture_or_promotion(ttm))
+ ttm = MOVE_NONE;
+ }
else
- phasePtr = QsearchWithoutChecksPhaseTable + !searchTT;
+ {
+ phasePtr = QsearchRecapturesTable;
+ recaptureSquare = recaptureSq;
+ ttm = MOVE_NONE;
+ }
+
+ ttMove = (ttm && pos.is_pseudo_legal(ttm) ? ttm : MOVE_NONE);
+ phasePtr += int(ttMove == MOVE_NONE) - 1;
+ go_next_phase();
+}
+
+MovePicker::MovePicker(const Position& p, Move ttm, const History& h, PieceType parentCapture)
+ : pos(p), H(h) {
+
+ assert (!pos.in_check());
+
+ // In ProbCut we consider only captures better than parent's move
+ captureThreshold = PieceValueMidgame[Piece(parentCapture)];
+ phasePtr = ProbCutTable;
+
+ if ( ttm != MOVE_NONE
+ && (!pos.is_capture(ttm) || pos.see(ttm) <= captureThreshold))
+ ttm = MOVE_NONE;
- phasePtr--;
+ ttMove = (ttm && pos.is_pseudo_legal(ttm) ? ttm : MOVE_NONE);
+ phasePtr += int(ttMove == MOVE_NONE) - 1;
go_next_phase();
}
@@ -115,15 +163,14 @@ void MovePicker::go_next_phase() {
phase = *(++phasePtr);
switch (phase) {
- case PH_TT_MOVES:
- curMove = ttMoves;
- lastMove = curMove + 2;
+ case PH_TT_MOVE:
+ lastMove = curMove + 1;
return;
case PH_GOOD_CAPTURES:
- lastMove = generate_captures(pos, moves);
+ case PH_GOOD_PROBCUT:
+ lastMove = generate(pos, moves);
score_captures();
- std::sort(moves, lastMove);
return;
case PH_KILLERS:
@@ -131,40 +178,48 @@ void MovePicker::go_next_phase() {
lastMove = curMove + 2;
return;
- case PH_NONCAPTURES:
- lastMove = generate_noncaptures(pos, moves);
+ case PH_NONCAPTURES_1:
+ lastNonCapture = lastMove = generate(pos, moves);
score_noncaptures();
- std::sort(moves, lastMove);
+ lastMove = std::partition(curMove, lastMove, has_positive_score);
+ sort(curMove, lastMove);
+ return;
+
+ case PH_NONCAPTURES_2:
+ curMove = lastMove;
+ lastMove = lastNonCapture;
+ if (depth >= 3 * ONE_PLY)
+ sort(curMove, lastMove);
return;
case PH_BAD_CAPTURES:
- // Bad captures SEE value is already calculated so just sort them
- // to get SEE move ordering.
+ // Bad captures SEE value is already calculated so just pick
+ // them in order to get SEE move ordering.
curMove = badCaptures;
- lastMove = lastBadCapture;
- std::sort(badCaptures, lastMove);
+ lastMove = moves + MAX_MOVES;
return;
case PH_EVASIONS:
- assert(pos.is_check());
- lastMove = generate_evasions(pos, moves, pinned);
+ assert(pos.in_check());
+ lastMove = generate(pos, moves);
score_evasions();
- std::sort(moves, lastMove);
return;
case PH_QCAPTURES:
- lastMove = generate_captures(pos, moves);
+ lastMove = generate(pos, moves);
score_captures();
- std::sort(moves, lastMove);
+ return;
+
+ case PH_QRECAPTURES:
+ lastMove = generate(pos, moves);
return;
case PH_QCHECKS:
- // Perhaps we should order moves move here? FIXME
- lastMove = generate_non_capture_checks(pos, moves, dc);
+ lastMove = generate(pos, moves);
return;
case PH_STOP:
- lastMove = curMove + 1; // hack to be friendly for get_next_move()
+ lastMove = curMove + 1; // Avoid another go_next_phase() call
return;
default:
@@ -177,7 +232,7 @@ void MovePicker::go_next_phase() {
/// MovePicker::score_captures(), MovePicker::score_noncaptures() and
/// MovePicker::score_evasions() assign a numerical move ordering score
/// to each move in a move list. The moves with highest scores will be
-/// picked first by get_next_move().
+/// picked first by next_move().
void MovePicker::score_captures() {
// Winning and equal captures in the main search are ordered by MVV/LVA.
@@ -199,161 +254,146 @@ void MovePicker::score_captures() {
for (MoveStack* cur = moves; cur != lastMove; cur++)
{
m = cur->move;
- if (move_is_promotion(m))
- cur->score = QueenValueMidgame;
- else
- cur->score = int(pos.midgame_value_of_piece_on(move_to(m)))
- -int(pos.type_of_piece_on(move_from(m)));
+ cur->score = PieceValueMidgame[pos.piece_on(to_sq(m))]
+ - type_of(pos.piece_on(from_sq(m)));
+
+ if (is_promotion(m))
+ cur->score += PieceValueMidgame[Piece(promotion_piece_type(m))];
}
}
void MovePicker::score_noncaptures() {
- // First score by history, when no history is available then use
- // piece/square tables values. This seems to be better then a
- // random choice when we don't have an history for any move.
+
Move m;
- Piece piece;
- Square from, to;
- int hs;
+ Square from;
for (MoveStack* cur = moves; cur != lastMove; cur++)
{
m = cur->move;
- from = move_from(m);
- to = move_to(m);
- piece = pos.piece_on(from);
- hs = H.move_ordering_score(piece, to);
-
- // Ensure history is always preferred to pst
- if (hs > 0)
- hs += 1000;
-
- // pst based scoring
- cur->score = hs + pos.pst_delta(piece, from, to);
+ from = from_sq(m);
+ cur->score = H.value(pos.piece_on(from), to_sq(m));
}
}
void MovePicker::score_evasions() {
-
+ // Try good captures ordered by MVV/LVA, then non-captures if
+ // destination square is not under attack, ordered by history
+ // value, and at the end bad-captures and non-captures with a
+ // negative SEE. This last group is ordered by the SEE score.
Move m;
+ int seeScore;
+
+ // Skip if we don't have at least two moves to order
+ if (lastMove < moves + 2)
+ return;
for (MoveStack* cur = moves; cur != lastMove; cur++)
{
m = cur->move;
- if (m == ttMoves[0].move)
- cur->score = 2 * HistoryMax;
- else if (!pos.square_is_empty(move_to(m)))
- {
- int seeScore = pos.see(m);
- cur->score = seeScore + (seeScore >= 0 ? HistoryMax : 0);
- } else
- cur->score = H.move_ordering_score(pos.piece_on(move_from(m)), move_to(m));
+ if ((seeScore = pos.see_sign(m)) < 0)
+ cur->score = seeScore - History::MaxValue; // Be sure we are at the bottom
+ else if (pos.is_capture(m))
+ cur->score = PieceValueMidgame[pos.piece_on(to_sq(m))]
+ - type_of(pos.piece_on(from_sq(m))) + History::MaxValue;
+ else
+ cur->score = H.value(pos.piece_on(from_sq(m)), to_sq(m));
}
}
-/// MovePicker::get_next_move() is the most important method of the MovePicker
-/// class. It returns a new legal move every time it is called, until there
-/// are no more moves left.
-/// It picks the move with the biggest score from a list of generated moves taking
-/// care not to return the tt move if has already been searched previously.
-
-Move MovePicker::get_next_move() {
+/// MovePicker::next_move() is the most important method of the MovePicker class.
+/// It returns a new pseudo legal move every time it is called, until there
+/// are no more moves left. It picks the move with the biggest score from a list
+/// of generated moves taking care not to return the tt move if has already been
+/// searched previously. Note that this function is not thread safe so should be
+/// lock protected by caller when accessed through a shared MovePicker object.
- assert(!pos.is_check() || *phasePtr == PH_EVASIONS || *phasePtr == PH_STOP);
- assert( pos.is_check() || *phasePtr != PH_EVASIONS);
+Move MovePicker::next_move() {
Move move;
while (true)
{
- while (curMove != lastMove)
- {
- move = (curMove++)->move;
+ while (curMove == lastMove)
+ go_next_phase();
- switch (phase) {
+ switch (phase) {
- case PH_TT_MOVES:
- if ( move != MOVE_NONE
- && move_is_legal(pos, move, pinned))
- return move;
- break;
-
- case PH_GOOD_CAPTURES:
- if ( move != ttMoves[0].move
- && move != ttMoves[1].move
- && pos.pl_move_is_legal(move, pinned))
- {
- // Check for a non negative SEE now
- int seeValue = pos.see_sign(move);
- if (seeValue >= 0)
- return move;
-
- // Losing capture, move it to the badCaptures[] array, note
- // that move has now been already checked for legality.
- assert(int(lastBadCapture - badCaptures) < 63);
- lastBadCapture->move = move;
- lastBadCapture->score = seeValue;
- lastBadCapture++;
- }
- break;
-
- case PH_KILLERS:
- if ( move != MOVE_NONE
- && move != ttMoves[0].move
- && move != ttMoves[1].move
- && move_is_legal(pos, move, pinned)
- && !pos.move_is_capture(move))
- return move;
- break;
-
- case PH_NONCAPTURES:
- if ( move != ttMoves[0].move
- && move != ttMoves[1].move
- && move != killers[0].move
- && move != killers[1].move
- && pos.pl_move_is_legal(move, pinned))
+ case PH_TT_MOVE:
+ curMove++;
+ return ttMove;
+ break;
+
+ case PH_GOOD_CAPTURES:
+ move = pick_best(curMove++, lastMove)->move;
+ if (move != ttMove)
+ {
+ assert(captureThreshold <= 0); // Otherwise we must use see instead of see_sign
+
+ // Check for a non negative SEE now
+ int seeValue = pos.see_sign(move);
+ if (seeValue >= captureThreshold)
return move;
- break;
- case PH_EVASIONS:
- case PH_BAD_CAPTURES:
+ // Losing capture, move it to the tail of the array
+ (--badCaptures)->move = move;
+ badCaptures->score = seeValue;
+ }
+ break;
+
+ case PH_GOOD_PROBCUT:
+ move = pick_best(curMove++, lastMove)->move;
+ if ( move != ttMove
+ && pos.see(move) > captureThreshold)
return move;
+ break;
- case PH_QCAPTURES:
- case PH_QCHECKS:
- // Maybe postpone the legality check until after futility pruning?
- if ( move != ttMoves[0].move
- && pos.pl_move_is_legal(move, pinned))
- return move;
- break;
+ case PH_KILLERS:
+ move = (curMove++)->move;
+ if ( move != MOVE_NONE
+ && pos.is_pseudo_legal(move)
+ && move != ttMove
+ && !pos.is_capture(move))
+ return move;
+ break;
- case PH_STOP:
- return MOVE_NONE;
+ case PH_NONCAPTURES_1:
+ case PH_NONCAPTURES_2:
+ move = (curMove++)->move;
+ if ( move != ttMove
+ && move != killers[0].move
+ && move != killers[1].move)
+ return move;
+ break;
- default:
- assert(false);
- break;
- }
- }
- go_next_phase();
- }
-}
+ case PH_BAD_CAPTURES:
+ move = pick_best(curMove++, lastMove)->move;
+ return move;
-/// A variant of get_next_move() which takes a lock as a parameter, used to
-/// prevent multiple threads from picking the same move at a split point.
+ case PH_EVASIONS:
+ case PH_QCAPTURES:
+ move = pick_best(curMove++, lastMove)->move;
+ if (move != ttMove)
+ return move;
+ break;
+
+ case PH_QRECAPTURES:
+ move = (curMove++)->move;
+ if (to_sq(move) == recaptureSquare)
+ return move;
+ break;
-Move MovePicker::get_next_move(Lock &lock) {
+ case PH_QCHECKS:
+ move = (curMove++)->move;
+ if (move != ttMove)
+ return move;
+ break;
- lock_grab(&lock);
- if (finished)
- {
- lock_release(&lock);
- return MOVE_NONE;
- }
- Move m = get_next_move();
- if (m == MOVE_NONE)
- finished = true;
+ case PH_STOP:
+ return MOVE_NONE;
- lock_release(&lock);
- return m;
+ default:
+ assert(false);
+ break;
+ }
+ }
}