X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fmovepick.cpp;h=b992d2353041f69b1579c064904fc5b15ce28cb3;hp=88b4fe9c6ab9bf320832e34642b7f657de95f186;hb=ad43ce143664953087b44dd3b4324f77c212bd46;hpb=3141490374182551ed26f39ba4e3efb59589f057 diff --git a/src/movepick.cpp b/src/movepick.cpp index 88b4fe9c..b992d235 100644 --- a/src/movepick.cpp +++ b/src/movepick.cpp @@ -72,7 +72,7 @@ namespace { /// move ordering is at the current node. MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const History& h, - SearchStack* ss, Value beta) : pos(p), H(h), depth(d) { + Search::Stack* ss, Value beta) : pos(p), H(h), depth(d) { captureThreshold = 0; badCaptures = moves + MAX_MOVES; @@ -88,11 +88,14 @@ MovePicker::MovePicker(const Position& p, Move ttm, Depth d, const History& h, killers[0].move = ss->killers[0]; killers[1].move = ss->killers[1]; - // Consider sligtly negative captures as good if at low - // depth and far from beta. + // Consider sligtly negative captures as good if at low depth and far from beta if (ss && ss->eval < beta - PawnValueMidgame && d < 3 * ONE_PLY) captureThreshold = -PawnValueMidgame; + // Consider negative captures as good if still enough to reach beta + else if (ss && ss->eval > beta) + captureThreshold = beta - ss->eval; + phasePtr = MainSearchTable; } @@ -138,7 +141,7 @@ MovePicker::MovePicker(const Position& p, Move ttm, const History& h, PieceType assert (!pos.in_check()); // In ProbCut we consider only captures better than parent's move - captureThreshold = piece_value_midgame(Piece(parentCapture)); + captureThreshold = PieceValueMidgame[Piece(parentCapture)]; phasePtr = ProbCutTable; if ( ttm != MOVE_NONE @@ -229,7 +232,7 @@ void MovePicker::go_next_phase() { /// MovePicker::score_captures(), MovePicker::score_noncaptures() and /// MovePicker::score_evasions() assign a numerical move ordering score /// to each move in a move list. The moves with highest scores will be -/// picked first by get_next_move(). +/// picked first by next_move(). void MovePicker::score_captures() { // Winning and equal captures in the main search are ordered by MVV/LVA. @@ -251,11 +254,11 @@ void MovePicker::score_captures() { for (MoveStack* cur = moves; cur != lastMove; cur++) { m = cur->move; - cur->score = piece_value_midgame(pos.piece_on(move_to(m))) + cur->score = PieceValueMidgame[pos.piece_on(move_to(m))] - type_of(pos.piece_on(move_from(m))); if (is_promotion(m)) - cur->score += piece_value_midgame(Piece(promotion_piece_type(m))); + cur->score += PieceValueMidgame[Piece(promotion_piece_type(m))]; } } @@ -290,21 +293,21 @@ void MovePicker::score_evasions() { if ((seeScore = pos.see_sign(m)) < 0) cur->score = seeScore - History::MaxValue; // Be sure we are at the bottom else if (pos.is_capture(m)) - cur->score = piece_value_midgame(pos.piece_on(move_to(m))) + cur->score = PieceValueMidgame[pos.piece_on(move_to(m))] - type_of(pos.piece_on(move_from(m))) + History::MaxValue; else cur->score = H.value(pos.piece_on(move_from(m)), move_to(m)); } } -/// MovePicker::get_next_move() is the most important method of the MovePicker -/// class. It returns a new pseudo legal move every time it is called, until there +/// MovePicker::next_move() is the most important method of the MovePicker class. +/// It returns a new pseudo legal move every time it is called, until there /// are no more moves left. It picks the move with the biggest score from a list /// of generated moves taking care not to return the tt move if has already been /// searched previously. Note that this function is not thread safe so should be /// lock protected by caller when accessed through a shared MovePicker object. -Move MovePicker::get_next_move() { +Move MovePicker::next_move() { Move move;