X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fposition.cpp;h=28b39c8d50feda128a034bfbcb8ed065a616f6a1;hp=4cb7e3063be940f54e919607a760d949b1130317;hb=cca34e234cc98ed4b61e75a25f8cd0d917c2a3fa;hpb=ed95ad1c0eab8a27d1866a3f4532c2793a53ca36 diff --git a/src/position.cpp b/src/position.cpp index 4cb7e306..28b39c8d 100644 --- a/src/position.cpp +++ b/src/position.cpp @@ -340,11 +340,11 @@ const string Position::fen() const { { Square sq = file | rank; - if (is_empty(sq)) + if (empty(sq)) { int emptyCnt = 1; - for ( ; file < FILE_H && is_empty(++sq); ++file) + for ( ; file < FILE_H && empty(++sq); ++file) emptyCnt++; ss << emptyCnt; @@ -472,9 +472,9 @@ Bitboard Position::attacks_from(Piece p, Square s, Bitboard occ) { } -/// Position::pl_move_is_legal() tests whether a pseudo-legal move is legal +/// Position::legal() tests whether a pseudo-legal move is legal -bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { +bool Position::legal(Move m, Bitboard pinned) const { assert(is_ok(m)); assert(pinned == pinned_pieces()); @@ -482,7 +482,7 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { Color us = sideToMove; Square from = from_sq(m); - assert(color_of(piece_moved(m)) == us); + assert(color_of(moved_piece(m)) == us); assert(piece_on(king_square(us)) == make_piece(us, KING)); // En passant captures are a tricky special case. Because they are rather @@ -497,7 +497,7 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { Bitboard b = (pieces() ^ from ^ capsq) | to; assert(to == ep_square()); - assert(piece_moved(m) == make_piece(us, PAWN)); + assert(moved_piece(m) == make_piece(us, PAWN)); assert(piece_on(capsq) == make_piece(them, PAWN)); assert(piece_on(to) == NO_PIECE); @@ -519,16 +519,16 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { } -/// Position::is_pseudo_legal() takes a random move and tests whether the move -/// is pseudo legal. It is used to validate moves from TT that can be corrupted +/// Position::pseudo_legal() takes a random move and tests whether the move is +/// pseudo legal. It is used to validate moves from TT that can be corrupted /// due to SMP concurrent access or hash position key aliasing. -bool Position::is_pseudo_legal(const Move m) const { +bool Position::pseudo_legal(const Move m) const { Color us = sideToMove; Square from = from_sq(m); Square to = to_sq(m); - Piece pc = piece_moved(m); + Piece pc = moved_piece(m); // Use a slower but simpler function for uncommon cases if (type_of(m) != NORMAL) @@ -581,7 +581,7 @@ bool Position::is_pseudo_legal(const Move m) const { case DELTA_N: case DELTA_S: // Pawn push. The destination square must be empty. - if (!is_empty(to)) + if (!empty(to)) return false; break; @@ -590,8 +590,8 @@ bool Position::is_pseudo_legal(const Move m) const { // rank, and both the destination square and the square between the // source and destination squares must be empty. if ( rank_of(to) != RANK_4 - || !is_empty(to) - || !is_empty(from + DELTA_N)) + || !empty(to) + || !empty(from + DELTA_N)) return false; break; @@ -600,8 +600,8 @@ bool Position::is_pseudo_legal(const Move m) const { // rank, and both the destination square and the square between the // source and destination squares must be empty. if ( rank_of(to) != RANK_5 - || !is_empty(to) - || !is_empty(from + DELTA_S)) + || !empty(to) + || !empty(from + DELTA_S)) return false; break; @@ -639,11 +639,11 @@ bool Position::is_pseudo_legal(const Move m) const { /// Position::move_gives_check() tests whether a pseudo-legal move gives a check -bool Position::move_gives_check(Move m, const CheckInfo& ci) const { +bool Position::gives_check(Move m, const CheckInfo& ci) const { assert(is_ok(m)); assert(ci.dcCandidates == discovered_check_candidates()); - assert(color_of(piece_moved(m)) == sideToMove); + assert(color_of(moved_piece(m)) == sideToMove); Square from = from_sq(m); Square to = to_sq(m); @@ -710,7 +710,7 @@ bool Position::move_gives_check(Move m, const CheckInfo& ci) const { void Position::do_move(Move m, StateInfo& newSt) { CheckInfo ci(*this); - do_move(m, newSt, ci, move_gives_check(m, ci)); + do_move(m, newSt, ci, gives_check(m, ci)); } void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveIsCheck) { @@ -744,11 +744,11 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI Square to = to_sq(m); Piece pc = piece_on(from); PieceType pt = type_of(pc); - PieceType capture = type_of(m) == ENPASSANT ? PAWN : type_of(piece_on(to)); + PieceType captured = type_of(m) == ENPASSANT ? PAWN : type_of(piece_on(to)); assert(color_of(pc) == us); assert(piece_on(to) == NO_PIECE || color_of(piece_on(to)) == them || type_of(m) == CASTLE); - assert(capture != KING); + assert(captured != KING); if (type_of(m) == CASTLE) { @@ -758,7 +758,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI Square rfrom = to; // Castle is encoded as "king captures friendly rook" Square rto = relative_square(us, kingSide ? SQ_F1 : SQ_D1); to = relative_square(us, kingSide ? SQ_G1 : SQ_C1); - capture = NO_PIECE_TYPE; + captured = NO_PIECE_TYPE; do_castle(from, to, rfrom, rto); @@ -766,13 +766,13 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI k ^= Zobrist::psq[us][ROOK][rfrom] ^ Zobrist::psq[us][ROOK][rto]; } - if (capture) + if (captured) { Square capsq = to; // If the captured piece is a pawn, update pawn hash key, otherwise // update non-pawn material. - if (capture == PAWN) + if (captured == PAWN) { if (type_of(m) == ENPASSANT) { @@ -790,18 +790,18 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI st->pawnKey ^= Zobrist::psq[them][PAWN][capsq]; } else - st->npMaterial[them] -= PieceValue[MG][capture]; + st->npMaterial[them] -= PieceValue[MG][captured]; // Update board and piece lists - remove_piece(capsq, them, capture); + remove_piece(capsq, them, captured); // Update material hash key and prefetch access to materialTable - k ^= Zobrist::psq[them][capture][capsq]; - st->materialKey ^= Zobrist::psq[them][capture][pieceCount[them][capture]]; + k ^= Zobrist::psq[them][captured][capsq]; + st->materialKey ^= Zobrist::psq[them][captured][pieceCount[them][captured]]; prefetch((char*)thisThread->materialTable[st->materialKey]); // Update incremental scores - st->psq -= psq[them][capture][capsq]; + st->psq -= psq[them][captured][capsq]; // Reset rule 50 counter st->rule50 = 0; @@ -878,7 +878,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI st->psq += psq[us][pt][to] - psq[us][pt][from]; // Set capture piece - st->capturedType = capture; + st->capturedType = captured; // Update the key with the final value st->key = k; @@ -928,10 +928,10 @@ void Position::undo_move(Move m) { Square from = from_sq(m); Square to = to_sq(m); PieceType pt = type_of(piece_on(to)); - PieceType capture = st->capturedType; + PieceType captured = st->capturedType; - assert(is_empty(from) || type_of(m) == CASTLE); - assert(capture != KING); + assert(empty(from) || type_of(m) == CASTLE); + assert(captured != KING); if (type_of(m) == PROMOTION) { @@ -952,14 +952,14 @@ void Position::undo_move(Move m) { Square rfrom = to; // Castle is encoded as "king captures friendly rook" Square rto = relative_square(us, kingSide ? SQ_F1 : SQ_D1); to = relative_square(us, kingSide ? SQ_G1 : SQ_C1); - capture = NO_PIECE_TYPE; + captured = NO_PIECE_TYPE; pt = KING; do_castle(to, from, rto, rfrom); } else move_piece(to, from, us, pt); // Put the piece back at the source square - if (capture) + if (captured) { Square capsq = to; @@ -973,7 +973,7 @@ void Position::undo_move(Move m) { assert(piece_on(capsq) == NO_PIECE); } - put_piece(capsq, them, capture); // Restore the captured piece + put_piece(capsq, them, captured); // Restore the captured piece } // Finally point our state pointer back to the previous state @@ -1049,7 +1049,7 @@ int Position::see_sign(Move m) const { // Early return if SEE cannot be negative because captured piece value // is not less then capturing one. Note that king moves always return // here because king midgame value is set to 0. - if (PieceValue[MG][piece_moved(m)] <= PieceValue[MG][piece_on(to_sq(m))]) + if (PieceValue[MG][moved_piece(m)] <= PieceValue[MG][piece_on(to_sq(m))]) return 1; return see(m);