X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fposition.cpp;h=c6c315271f1f27a79ccf15ea616564127e6be4fd;hp=275dace2a033fe259052c09d800ffc64593ae4f9;hb=2f21ec39adcfc3a2ce4d4fd08eb1fa688c4e67a7;hpb=30e8f0c9ada37eaf6a4730215c3d05a4c301ade8 diff --git a/src/position.cpp b/src/position.cpp index 275dace2..c6c31527 100644 --- a/src/position.cpp +++ b/src/position.cpp @@ -210,8 +210,8 @@ void Position::from_fen(const std::string& fen) { key = compute_key(); pawnKey = compute_pawn_key(); materialKey = compute_material_key(); - mgValue = compute_mg_value(); - egValue = compute_eg_value(); + mgValue = compute_value(); + egValue = compute_value(); npMaterial[WHITE] = compute_non_pawn_material(WHITE); npMaterial[BLACK] = compute_non_pawn_material(BLACK); } @@ -323,29 +323,42 @@ void Position::copy(const Position &pos) { /// king) pieces for the given color. Bitboard Position::pinned_pieces(Color c) const { + if (pinned[c] != ~EmptyBoardBB) + return pinned[c]; + + Bitboard p1, p2; Square ksq = king_square(c); - return hidden_checks(c, ksq) | hidden_checks(c, ksq); + pinned[c] = hidden_checks(c, ksq, p1) | hidden_checks(c, ksq, p2); + pinners[c] = p1 | p2; + return pinned[c]; } +Bitboard Position::pinned_pieces(Color c, Bitboard& p) const { + + if (pinned[c] == ~EmptyBoardBB) + pinned_pieces(c); -/// Position:discovered_check_candidates() returns a bitboard containing all -/// pieces for the given side which are candidates for giving a discovered -/// check. The code is almost the same as the function for finding pinned -/// pieces. + p = pinners[c]; + return pinned[c]; +} Bitboard Position::discovered_check_candidates(Color c) const { + if (dcCandidates[c] != ~EmptyBoardBB) + return dcCandidates[c]; + + Bitboard dummy; Square ksq = king_square(opposite_color(c)); - return hidden_checks(c, ksq) | hidden_checks(c, ksq); + dcCandidates[c] = hidden_checks(c, ksq, dummy) | hidden_checks(c, ksq, dummy); + return dcCandidates[c]; } - /// Position:hidden_checks<>() returns a bitboard of all pinned (against the /// king) pieces for the given color and for the given pinner type. Or, when /// template parameter FindPinned is false, the pinned pieces of opposite color /// that are, indeed, the pieces candidate for a discovery check. template -Bitboard Position::hidden_checks(Color c, Square ksq) const { +Bitboard Position::hidden_checks(Color c, Square ksq, Bitboard& pinners) const { Square s; Bitboard sliders, result = EmptyBoardBB; @@ -362,7 +375,7 @@ Bitboard Position::hidden_checks(Color c, Square ksq) const { // Pinners are sliders, not checkers, that give check when // candidate pinned are removed. - Bitboard pinners = (FindPinned ? sliders & ~checkersBB : sliders); + pinners = (FindPinned ? sliders & ~checkersBB : sliders); if (Piece == ROOK) pinners &= rook_attacks_bb(ksq, occupied_squares() ^ candidate_pinned); @@ -371,12 +384,16 @@ Bitboard Position::hidden_checks(Color c, Square ksq) const { // Finally for each pinner find the corresponding pinned piece (if same color of king) // or discovery checker (if opposite color) among the candidates. - while (pinners) + Bitboard p = pinners; + while (p) { - s = pop_1st_bit(&pinners); + s = pop_1st_bit(&p); result |= (squares_between(s, ksq) & candidate_pinned); } } + else + pinners = EmptyBoardBB; + return result; } @@ -399,12 +416,12 @@ Bitboard Position::attacks_to(Square s) const { /// Position::piece_attacks_square() tests whether the piece on square f /// attacks square t. -bool Position::piece_attacks_square(Square f, Square t) const { +bool Position::piece_attacks_square(Piece p, Square f, Square t) const { assert(square_is_ok(f)); assert(square_is_ok(t)); - switch (piece_on(f)) + switch (p) { case WP: return pawn_attacks_square(WHITE, f, t); case BP: return pawn_attacks_square(BLACK, f, t); @@ -420,8 +437,7 @@ bool Position::piece_attacks_square(Square f, Square t) const { /// Position::move_attacks_square() tests whether a move from the current -/// position attacks a given square. Only attacks by the moving piece are -/// considered; the function does not handle X-ray attacks. +/// position attacks a given square. bool Position::move_attacks_square(Move m, Square s) const { @@ -432,18 +448,20 @@ bool Position::move_attacks_square(Move m, Square s) const { assert(square_is_occupied(f)); - switch (piece_on(f)) - { - case WP: return pawn_attacks_square(WHITE, t, s); - case BP: return pawn_attacks_square(BLACK, t, s); - case WN: case BN: return piece_attacks_square(t, s); - case WB: case BB: return piece_attacks_square(t, s); - case WR: case BR: return piece_attacks_square(t, s); - case WQ: case BQ: return piece_attacks_square(t, s); - case WK: case BK: return piece_attacks_square(t, s); - default: break; - } - return false; + if (piece_attacks_square(piece_on(f), t, s)) + return true; + + // Move the piece and scan for X-ray attacks behind it + Bitboard occ = occupied_squares(); + Color us = color_of_piece_on(f); + clear_bit(&occ, f); + set_bit(&occ, t); + Bitboard xray = ( (rook_attacks_bb(s, occ) & rooks_and_queens()) + |(bishop_attacks_bb(s, occ) & bishops_and_queens())) & pieces_of_color(us); + + // If we have attacks we need to verify that are caused by our move + // and are not already existent ones. + return xray && (xray ^ (xray & piece_attacks(s))); } @@ -460,22 +478,12 @@ void Position::find_checkers() { } -/// Position::pl_move_is_legal() tests whether a pseudo-legal move is legal. -/// There are two versions of this function: One which takes only a -/// move as input, and one which takes a move and a bitboard of pinned -/// pieces. The latter function is faster, and should always be preferred -/// when a pinned piece bitboard has already been computed. +/// Position::pl_move_is_legal() tests whether a pseudo-legal move is legal -bool Position::pl_move_is_legal(Move m) const { - - return pl_move_is_legal(m, pinned_pieces(side_to_move())); -} - -bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { +bool Position::pl_move_is_legal(Move m) const { assert(is_ok()); assert(move_is_ok(m)); - assert(pinned == pinned_pieces(side_to_move())); // If we're in check, all pseudo-legal moves are legal, because our // check evasion generator only generates true legal moves. @@ -492,7 +500,7 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { Square ksq = king_square(us); assert(color_of_piece_on(from) == us); - assert(piece_on(ksq) == king_of_color(us)); + assert(piece_on(ksq) == piece_of_color_and_type(us, KING)); // En passant captures are a tricky special case. Because they are // rather uncommon, we do it simply by testing whether the king is attacked @@ -504,8 +512,8 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { Bitboard b = occupied_squares(); assert(to == ep_square()); - assert(piece_on(from) == pawn_of_color(us)); - assert(piece_on(capsq) == pawn_of_color(them)); + assert(piece_on(from) == piece_of_color_and_type(us, PAWN)); + assert(piece_on(capsq) == piece_of_color_and_type(them, PAWN)); assert(piece_on(to) == EMPTY); clear_bit(&b, from); @@ -523,37 +531,27 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { // A non-king move is legal if and only if it is not pinned or it // is moving along the ray towards or away from the king. - return ( !bit_is_set(pinned, from) + return ( !bit_is_set(pinned_pieces(us), from) || (direction_between_squares(from, ksq) == direction_between_squares(move_to(m), ksq))); } -/// Position::move_is_check() tests whether a pseudo-legal move is a check. -/// There are two versions of this function: One which takes only a move as -/// input, and one which takes a move and a bitboard of discovered check -/// candidates. The latter function is faster, and should always be preferred -/// when a discovered check candidates bitboard has already been computed. +/// Position::move_is_check() tests whether a pseudo-legal move is a check bool Position::move_is_check(Move m) const { - Bitboard dc = discovered_check_candidates(side_to_move()); - return move_is_check(m, dc); -} - -bool Position::move_is_check(Move m, Bitboard dcCandidates) const { - assert(is_ok()); assert(move_is_ok(m)); - assert(dcCandidates == discovered_check_candidates(side_to_move())); Color us = side_to_move(); Color them = opposite_color(us); Square from = move_from(m); Square to = move_to(m); Square ksq = king_square(them); + Bitboard dcCandidates = discovered_check_candidates(us); assert(color_of_piece_on(from) == us); - assert(piece_on(ksq) == king_of_color(them)); + assert(piece_on(ksq) == piece_of_color_and_type(them, KING)); // Proceed according to the type of the moving piece switch (type_of_piece_on(from)) @@ -665,54 +663,12 @@ bool Position::move_is_capture(Move m) const { assert(m != MOVE_NONE); return ( !square_is_empty(move_to(m)) - && (color_of_piece_on(move_to(m)) == opposite_color(side_to_move())) + && (color_of_piece_on(move_to(m)) != color_of_piece_on(move_from(m))) ) || move_is_ep(m); } -/// Position::backup() is called when making a move. All information -/// necessary to restore the position when the move is later unmade -/// is saved to an UndoInfo object. The function Position::restore -/// does the reverse operation: When one does a backup followed by -/// a restore with the same UndoInfo object, the position is restored -/// to the state before backup was called. - -void Position::backup(UndoInfo& u) const { - - u.castleRights = castleRights; - u.epSquare = epSquare; - u.checkersBB = checkersBB; - u.key = key; - u.pawnKey = pawnKey; - u.materialKey = materialKey; - u.rule50 = rule50; - u.lastMove = lastMove; - u.mgValue = mgValue; - u.egValue = egValue; - u.capture = NO_PIECE_TYPE; -} - - -/// Position::restore() is called when unmaking a move. It copies back -/// the information backed up during a previous call to Position::backup. - -void Position::restore(const UndoInfo& u) { - - castleRights = u.castleRights; - epSquare = u.epSquare; - checkersBB = u.checkersBB; - key = u.key; - pawnKey = u.pawnKey; - materialKey = u.materialKey; - rule50 = u.rule50; - lastMove = u.lastMove; - mgValue = u.mgValue; - egValue = u.egValue; - // u.capture is restored in undo_move() -} - - /// Position::update_checkers() is a private method to udpate chekers info template @@ -736,25 +692,21 @@ inline void Position::update_checkers(Bitboard* pCheckersBB, Square ksq, Square /// Position::do_move() makes a move, and backs up all information necessary /// to undo the move to an UndoInfo object. The move is assumed to be legal. /// Pseudo-legal moves should be filtered out before this function is called. -/// There are two versions of this function, one which takes only the move and -/// the UndoInfo as input, and one which takes a third parameter, a bitboard of -/// discovered check candidates. The second version is faster, because knowing -/// the discovered check candidates makes it easier to update the checkersBB -/// member variable in the position object. void Position::do_move(Move m, UndoInfo& u) { - do_move(m, u, discovered_check_candidates(side_to_move())); -} - -void Position::do_move(Move m, UndoInfo& u, Bitboard dcCandidates) { - assert(is_ok()); assert(move_is_ok(m)); + // Get now the current (pre-move) dc candidates that we will use + // in update_checkers(). + Bitboard oldDcCandidates = discovered_check_candidates(side_to_move()); + // Back up the necessary information to our UndoInfo object (except the // captured piece, which is taken care of later. - backup(u); + u = undoInfoUnion; + u.capture = NO_PIECE_TYPE; + previous = &u; // Save the current key to the history[] array, in order to be able to // detect repetition draws. @@ -764,10 +716,14 @@ void Position::do_move(Move m, UndoInfo& u, Bitboard dcCandidates) { // case of non-reversible moves is taken care of later. rule50++; + // Reset pinned bitboard and its friends + for (Color c = WHITE; c <= BLACK; c++) + pinners[c] = pinned[c] = dcCandidates[c] = ~EmptyBoardBB; + if (move_is_castle(m)) do_castle_move(m); else if (move_promotion(m)) - do_promotion_move(m, u); + do_promotion_move(m); else if (move_is_ep(m)) do_ep_move(m); else @@ -803,10 +759,10 @@ void Position::do_move(Move m, UndoInfo& u, Bitboard dcCandidates) { key ^= zobrist[us][piece][from] ^ zobrist[us][piece][to]; // Update incremental scores - mgValue -= mg_pst(us, piece, from); - mgValue += mg_pst(us, piece, to); - egValue -= eg_pst(us, piece, from); - egValue += eg_pst(us, piece, to); + mgValue -= pst(us, piece, from); + mgValue += pst(us, piece, to); + egValue -= pst(us, piece, from); + egValue += pst(us, piece, to); // If the moving piece was a king, update the king square if (piece == KING) @@ -855,12 +811,12 @@ void Position::do_move(Move m, UndoInfo& u, Bitboard dcCandidates) { Square ksq = king_square(them); switch (piece) { - case PAWN: update_checkers(&checkersBB, ksq, from, to, dcCandidates); break; - case KNIGHT: update_checkers(&checkersBB, ksq, from, to, dcCandidates); break; - case BISHOP: update_checkers(&checkersBB, ksq, from, to, dcCandidates); break; - case ROOK: update_checkers(&checkersBB, ksq, from, to, dcCandidates); break; - case QUEEN: update_checkers(&checkersBB, ksq, from, to, dcCandidates); break; - case KING: update_checkers(&checkersBB, ksq, from, to, dcCandidates); break; + case PAWN: update_checkers(&checkersBB, ksq, from, to, oldDcCandidates); break; + case KNIGHT: update_checkers(&checkersBB, ksq, from, to, oldDcCandidates); break; + case BISHOP: update_checkers(&checkersBB, ksq, from, to, oldDcCandidates); break; + case ROOK: update_checkers(&checkersBB, ksq, from, to, oldDcCandidates); break; + case QUEEN: update_checkers(&checkersBB, ksq, from, to, oldDcCandidates); break; + case KING: update_checkers(&checkersBB, ksq, from, to, oldDcCandidates); break; default: assert(false); break; } } @@ -896,8 +852,8 @@ void Position::do_capture_move(Move m, PieceType capture, Color them, Square to) pawnKey ^= zobrist[them][PAWN][to]; // Update incremental scores - mgValue -= mg_pst(them, capture, to); - egValue -= eg_pst(them, capture, to); + mgValue -= pst(them, capture, to); + egValue -= pst(them, capture, to); assert(!move_promotion(m) || capture != PAWN); @@ -939,8 +895,8 @@ void Position::do_castle_move(Move m) { Square rfrom = move_to(m); // HACK: See comment at beginning of function Square kto, rto; - assert(piece_on(kfrom) == king_of_color(us)); - assert(piece_on(rfrom) == rook_of_color(us)); + assert(piece_on(kfrom) == piece_of_color_and_type(us, KING)); + assert(piece_on(rfrom) == piece_of_color_and_type(us, ROOK)); // Find destination squares for king and rook if (rfrom > kfrom) // O-O @@ -970,8 +926,8 @@ void Position::do_castle_move(Move m) { // Update board array board[kfrom] = board[rfrom] = EMPTY; - board[kto] = king_of_color(us); - board[rto] = rook_of_color(us); + board[kto] = piece_of_color_and_type(us, KING); + board[rto] = piece_of_color_and_type(us, ROOK); // Update king square kingSquare[us] = kto; @@ -984,14 +940,14 @@ void Position::do_castle_move(Move m) { index[rto] = tmp; // Update incremental scores - mgValue -= mg_pst(us, KING, kfrom); - mgValue += mg_pst(us, KING, kto); - egValue -= eg_pst(us, KING, kfrom); - egValue += eg_pst(us, KING, kto); - mgValue -= mg_pst(us, ROOK, rfrom); - mgValue += mg_pst(us, ROOK, rto); - egValue -= eg_pst(us, ROOK, rfrom); - egValue += eg_pst(us, ROOK, rto); + mgValue -= pst(us, KING, kfrom); + mgValue += pst(us, KING, kto); + egValue -= pst(us, KING, kfrom); + egValue += pst(us, KING, kto); + mgValue -= pst(us, ROOK, rfrom); + mgValue += pst(us, ROOK, rto); + egValue -= pst(us, ROOK, rfrom); + egValue += pst(us, ROOK, rto); // Update hash key key ^= zobrist[us][KING][kfrom] ^ zobrist[us][KING][kto]; @@ -1022,7 +978,7 @@ void Position::do_castle_move(Move m) { /// UndoInfo object, which has been initialized in Position::do_move, is /// used to store the captured piece (if any). -void Position::do_promotion_move(Move m, UndoInfo &u) { +void Position::do_promotion_move(Move m) { Color us, them; Square from, to; @@ -1038,14 +994,14 @@ void Position::do_promotion_move(Move m, UndoInfo &u) { to = move_to(m); assert(relative_rank(us, to) == RANK_8); - assert(piece_on(from) == pawn_of_color(us)); + assert(piece_on(from) == piece_of_color_and_type(us, PAWN)); assert(color_of_piece_on(to) == them || square_is_empty(to)); capture = type_of_piece_on(to); if (capture) { - u.capture = capture; + previous->capture = capture; do_capture_move(m, capture, them, to); } @@ -1084,10 +1040,10 @@ void Position::do_promotion_move(Move m, UndoInfo &u) { index[to] = pieceCount[us][promotion] - 1; // Update incremental scores - mgValue -= mg_pst(us, PAWN, from); - mgValue += mg_pst(us, promotion, to); - egValue -= eg_pst(us, PAWN, from); - egValue += eg_pst(us, promotion, to); + mgValue -= pst(us, PAWN, from); + mgValue += pst(us, promotion, to); + egValue -= pst(us, PAWN, from); + egValue += pst(us, promotion, to); // Update material npMaterial[us] += piece_value_midgame(promotion); @@ -1135,8 +1091,8 @@ void Position::do_ep_move(Move m) { assert(to == epSquare); assert(relative_rank(us, to) == RANK_6); assert(piece_on(to) == EMPTY); - assert(piece_on(from) == pawn_of_color(us)); - assert(piece_on(capsq) == pawn_of_color(them)); + assert(piece_on(from) == piece_of_color_and_type(us, PAWN)); + assert(piece_on(capsq) == piece_of_color_and_type(them, PAWN)); // Remove captured piece clear_bit(&(byColorBB[them]), capsq); @@ -1178,12 +1134,12 @@ void Position::do_ep_move(Move m) { pawnKey ^= zobrist[them][PAWN][capsq]; // Update incremental scores - mgValue -= mg_pst(them, PAWN, capsq); - mgValue -= mg_pst(us, PAWN, from); - mgValue += mg_pst(us, PAWN, to); - egValue -= eg_pst(them, PAWN, capsq); - egValue -= eg_pst(us, PAWN, from); - egValue += eg_pst(us, PAWN, to); + mgValue -= pst(them, PAWN, capsq); + mgValue -= pst(us, PAWN, from); + mgValue += pst(us, PAWN, to); + egValue -= pst(them, PAWN, capsq); + egValue -= pst(us, PAWN, from); + egValue += pst(us, PAWN, to); // Reset en passant square epSquare = SQ_NONE; @@ -1201,7 +1157,7 @@ void Position::do_ep_move(Move m) { /// important that Position::undo_move is called with the same move and UndoInfo /// object as the earlier call to Position::do_move. -void Position::undo_move(Move m, const UndoInfo &u) { +void Position::undo_move(Move m) { assert(is_ok()); assert(move_is_ok(m)); @@ -1211,19 +1167,19 @@ void Position::undo_move(Move m, const UndoInfo &u) { // Restore information from our UndoInfo object (except the captured piece, // which is taken care of later) - restore(u); + undoInfoUnion = *previous; if (move_is_castle(m)) undo_castle_move(m); else if (move_promotion(m)) - undo_promotion_move(m, u); + undo_promotion_move(m); else if (move_is_ep(m)) undo_ep_move(m); else { Color us, them; Square from, to; - PieceType piece, capture; + PieceType piece; us = side_to_move(); them = opposite_color(us); @@ -1253,8 +1209,6 @@ void Position::undo_move(Move m, const UndoInfo &u) { pieceList[us][piece][index[to]] = from; index[from] = index[to]; - capture = u.capture; - if (capture) { assert(capture != KING); @@ -1313,8 +1267,8 @@ void Position::undo_castle_move(Move m) { rto = relative_square(us, SQ_D1); } - assert(piece_on(kto) == king_of_color(us)); - assert(piece_on(rto) == rook_of_color(us)); + assert(piece_on(kto) == piece_of_color_and_type(us, KING)); + assert(piece_on(rto) == piece_of_color_and_type(us, ROOK)); // Remove pieces from destination squares clear_bit(&(byColorBB[us]), kto); @@ -1334,8 +1288,8 @@ void Position::undo_castle_move(Move m) { // Update board board[rto] = board[kto] = EMPTY; - board[rfrom] = rook_of_color(us); - board[kfrom] = king_of_color(us); + board[rfrom] = piece_of_color_and_type(us, ROOK); + board[kfrom] = piece_of_color_and_type(us, KING); // Update king square kingSquare[us] = kfrom; @@ -1354,11 +1308,11 @@ void Position::undo_castle_move(Move m) { /// function. The UndoInfo object, which has been initialized in /// Position::do_move, is used to put back the captured piece (if any). -void Position::undo_promotion_move(Move m, const UndoInfo &u) { +void Position::undo_promotion_move(Move m) { Color us, them; Square from, to; - PieceType capture, promotion; + PieceType promotion; assert(move_is_ok(m)); assert(move_promotion(m)); @@ -1386,7 +1340,7 @@ void Position::undo_promotion_move(Move m, const UndoInfo &u) { set_bit(&(byColorBB[us]), from); set_bit(&(byTypeBB[PAWN]), from); set_bit(&(byTypeBB[0]), from); // HACK: byTypeBB[0] == occupied squares - board[from] = pawn_of_color(us); + board[from] = piece_of_color_and_type(us, PAWN); // Update material npMaterial[us] -= piece_value_midgame(promotion); @@ -1402,8 +1356,6 @@ void Position::undo_promotion_move(Move m, const UndoInfo &u) { pieceCount[us][promotion]--; pieceCount[us][PAWN]++; - capture = u.capture; - if (capture) { assert(capture != KING); @@ -1451,7 +1403,7 @@ void Position::undo_ep_move(Move m) { assert(to == ep_square()); assert(relative_rank(us, to) == RANK_6); - assert(piece_on(to) == pawn_of_color(us)); + assert(piece_on(to) == piece_of_color_and_type(us, PAWN)); assert(piece_on(from) == EMPTY); assert(piece_on(capsq) == EMPTY); @@ -1459,7 +1411,7 @@ void Position::undo_ep_move(Move m) { set_bit(&(byColorBB[them]), capsq); set_bit(&(byTypeBB[PAWN]), capsq); set_bit(&(byTypeBB[0]), capsq); - board[capsq] = pawn_of_color(them); + board[capsq] = piece_of_color_and_type(them, PAWN); // Remove moving piece from destination square clear_bit(&(byColorBB[us]), to); @@ -1471,7 +1423,7 @@ void Position::undo_ep_move(Move m) { set_bit(&(byColorBB[us]), from); set_bit(&(byTypeBB[PAWN]), from); set_bit(&(byTypeBB[0]), from); - board[from] = pawn_of_color(us); + board[from] = piece_of_color_and_type(us, PAWN); // Update piece list: pieceList[us][PAWN][index[to]] = from; @@ -1493,10 +1445,12 @@ void Position::do_null_move(UndoInfo& u) { assert(!is_check()); // Back up the information necessary to undo the null move to the supplied - // UndoInfo object. In the case of a null move, the only thing we need to + // UndoInfo object. In the case of a null move, the only thing we need to // remember is the last move made and the en passant square. u.lastMove = lastMove; u.epSquare = epSquare; + u.previous = previous; + previous = &u; // Save the current key to the history[] array, in order to be able to // detect repetition draws. @@ -1521,18 +1475,20 @@ void Position::do_null_move(UndoInfo& u) { /// Position::undo_null_move() unmakes a "null move". -void Position::undo_null_move(const UndoInfo &u) { +void Position::undo_null_move() { assert(is_ok()); assert(!is_check()); - // Restore information from the supplied UndoInfo object: - lastMove = u.lastMove; - epSquare = u.epSquare; + // Restore information from the our UndoInfo object + lastMove = previous->lastMove; + epSquare = previous->epSquare; + previous = previous->previous; + if (epSquare != SQ_NONE) key ^= zobEp[epSquare]; - // Update the necessary information. + // Update the necessary information sideToMove = opposite_color(sideToMove); rule50--; gamePly--; @@ -1718,6 +1674,8 @@ void Position::clear() { } checkersBB = EmptyBoardBB; + for (Color c = WHITE; c <= BLACK; c++) + pinners[c] = pinned[c] = dcCandidates[c] = ~EmptyBoardBB; lastMove = MOVE_NONE; @@ -1729,6 +1687,7 @@ void Position::clear() { epSquare = SQ_NONE; rule50 = 0; gamePly = 0; + previous = NULL; } @@ -1854,13 +1813,12 @@ Key Position::compute_material_key() const { } -/// Position::compute_mg_value() and Position::compute_eg_value() compute the -/// incremental scores for the middle game and the endgame. These functions -/// are used to initialize the incremental scores when a new position is set -/// up, and to verify that the scores are correctly updated by do_move -/// and undo_move when the program is running in debug mode. - -Value Position::compute_mg_value() const { +/// Position::compute_value() compute the incremental scores for the middle +/// game and the endgame. These functions are used to initialize the incremental +/// scores when a new position is set up, and to verify that the scores are correctly +/// updated by do_move and undo_move when the program is running in debug mode. +template +Value Position::compute_value() const { Value result = Value(0); Bitboard b; @@ -1874,31 +1832,12 @@ Value Position::compute_mg_value() const { { s = pop_1st_bit(&b); assert(piece_on(s) == piece_of_color_and_type(c, pt)); - result += mg_pst(c, pt, s); + result += pst(c, pt, s); } } - result += (side_to_move() == WHITE)? TempoValueMidgame / 2 : -TempoValueMidgame / 2; - return result; -} - -Value Position::compute_eg_value() const { - Value result = Value(0); - Bitboard b; - Square s; - - for (Color c = WHITE; c <= BLACK; c++) - for (PieceType pt = PAWN; pt <= KING; pt++) - { - b = pieces_of_color_and_type(c, pt); - while(b) - { - s = pop_1st_bit(&b); - assert(piece_on(s) == piece_of_color_and_type(c, pt)); - result += eg_pst(c, pt, s); - } - } - result += (side_to_move() == WHITE)? TempoValueEndgame / 2 : -TempoValueEndgame / 2; + const Value TempoValue = (Phase == MidGame ? TempoValueMidgame : TempoValueEndgame); + result += (side_to_move() == WHITE)? TempoValue / 2 : -TempoValue / 2; return result; } @@ -2002,12 +1941,12 @@ bool Position::has_mate_threat(Color c) { if (is_mate()) result = true; - undo_move(mlist[i].move, u2); + undo_move(mlist[i].move); } // Undo null move, if necessary if (c != stm) - undo_null_move(u1); + undo_null_move(); return result; } @@ -2119,8 +2058,8 @@ void Position::flipped_copy(const Position &pos) { materialKey = compute_material_key(); // Incremental scores - mgValue = compute_mg_value(); - egValue = compute_eg_value(); + mgValue = compute_value(); + egValue = compute_value(); // Material npMaterial[WHITE] = compute_non_pawn_material(WHITE); @@ -2249,10 +2188,10 @@ bool Position::is_ok(int* failedStep) const { if (failedStep) (*failedStep)++; if (debugIncrementalEval) { - if (mgValue != compute_mg_value()) + if (mgValue != compute_value()) return false; - if (egValue != compute_eg_value()) + if (egValue != compute_value()) return false; }