X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fposition.cpp;h=ccc29acf20974d8a09c6a26ccdc209150c76ce1a;hp=2f18427d827f8111d0357416d92525bb4ad7bb72;hb=78908b7aed41ba0a70c557182ab1b27792db9b0c;hpb=bb3427ca85bdb20b4c8af12b63f635d03c5e9146 diff --git a/src/position.cpp b/src/position.cpp index 2f18427d..ccc29acf 100644 --- a/src/position.cpp +++ b/src/position.cpp @@ -1,7 +1,7 @@ /* Stockfish, a UCI chess playing engine derived from Glaurung 2.1 Copyright (C) 2004-2008 Tord Romstad (Glaurung author) - Copyright (C) 2008-2010 Marco Costalba, Joona Kiiski, Tord Romstad + Copyright (C) 2008-2012 Marco Costalba, Joona Kiiski, Tord Romstad Stockfish is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -70,7 +70,7 @@ namespace { const Score TempoValue = make_score(48, 22); // To convert a Piece to and from a FEN char - const string PieceToChar(".PNBRQK pnbrqk "); + const string PieceToChar(" PNBRQK pnbrqk ."); } @@ -78,8 +78,8 @@ namespace { CheckInfo::CheckInfo(const Position& pos) { - Color them = flip(pos.side_to_move()); - Square ksq = pos.king_square(them); + Color them = ~pos.side_to_move(); + ksq = pos.king_square(them); pinned = pos.pinned_pieces(); dcCandidates = pos.discovered_check_candidates(); @@ -89,7 +89,7 @@ CheckInfo::CheckInfo(const Position& pos) { checkSq[BISHOP] = pos.attacks_from(ksq); checkSq[ROOK] = pos.attacks_from(ksq); checkSq[QUEEN] = checkSq[BISHOP] | checkSq[ROOK]; - checkSq[KING] = EmptyBoardBB; + checkSq[KING] = 0; } @@ -100,6 +100,8 @@ CheckInfo::CheckInfo(const Position& pos) { void Position::copy(const Position& pos, int th) { memcpy(this, &pos, sizeof(Position)); + startState = *st; + st = &startState; threadID = th; nodes = 0; @@ -163,11 +165,11 @@ void Position::from_fen(const string& fenStr, bool isChess960) { // 1. Piece placement while ((fen >> token) && !isspace(token)) { - if (token == '/') - sq -= Square(16); // Jump back of 2 rows + if (isdigit(token)) + sq += Square(token - '0'); // Advance the given number of files - else if (isdigit(token)) - sq += Square(token - '0'); // Skip the given number of files + else if (token == '/') + sq = make_square(FILE_A, rank_of(sq) - Rank(2)); else if ((p = PieceToChar.find(token)) != string::npos) { @@ -190,15 +192,14 @@ void Position::from_fen(const string& fenStr, bool isChess960) { { Square rsq; Color c = islower(token) ? BLACK : WHITE; - Piece rook = make_piece(c, ROOK); token = char(toupper(token)); if (token == 'K') - for (rsq = relative_square(c, SQ_H1); piece_on(rsq) != rook; rsq--) {} + for (rsq = relative_square(c, SQ_H1); type_of(piece_on(rsq)) != ROOK; rsq--) {} else if (token == 'Q') - for (rsq = relative_square(c, SQ_A1); piece_on(rsq) != rook; rsq++) {} + for (rsq = relative_square(c, SQ_A1); type_of(piece_on(rsq)) != ROOK; rsq++) {} else if (token >= 'A' && token <= 'H') rsq = make_square(File(token - 'A'), relative_rank(c, RANK_1)); @@ -206,7 +207,7 @@ void Position::from_fen(const string& fenStr, bool isChess960) { else continue; - set_castle_right(king_square(c), rsq); + set_castle_right(c, rsq); } // 4. En passant square. Ignore if no pawn capture is possible @@ -232,7 +233,7 @@ void Position::from_fen(const string& fenStr, bool isChess960) { st->value = compute_value(); st->npMaterial[WHITE] = compute_non_pawn_material(WHITE); st->npMaterial[BLACK] = compute_non_pawn_material(BLACK); - st->checkersBB = attackers_to(king_square(sideToMove)) & pieces(flip(sideToMove)); + st->checkersBB = attackers_to(king_square(sideToMove)) & pieces(~sideToMove); chess960 = isChess960; assert(pos_is_ok()); @@ -240,14 +241,14 @@ void Position::from_fen(const string& fenStr, bool isChess960) { /// Position::set_castle_right() is an helper function used to set castling -/// rights given the corresponding king and rook starting squares. +/// rights given the corresponding color and the rook starting square. -void Position::set_castle_right(Square ksq, Square rsq) { +void Position::set_castle_right(Color c, Square rsq) { - int f = (rsq < ksq ? WHITE_OOO : WHITE_OO) << color_of(piece_on(ksq)); + int f = (rsq < king_square(c) ? WHITE_OOO : WHITE_OO) << c; st->castleRights |= f; - castleRightsMask[ksq] ^= f; + castleRightsMask[king_square(c)] ^= f; castleRightsMask[rsq] ^= f; castleRookSquare[f] = rsq; } @@ -336,8 +337,8 @@ void Position::print(Move move) const { Piece piece = piece_on(sq); char c = (color_of(piece) == BLACK ? '=' : ' '); - if (piece == PIECE_NONE && color_of(sq) == DARK) - piece = PIECE_NONE_DARK_SQ; + if (piece == NO_PIECE && !opposite_colors(sq, SQ_A1)) + piece++; // Index the dot cout << c << PieceToChar[piece] << c << '|'; } @@ -355,12 +356,12 @@ Bitboard Position::hidden_checkers() const { // Pinned pieces protect our king, dicovery checks attack the enemy king Bitboard b, result = 0; - Bitboard pinners = pieces(FindPinned ? flip(sideToMove) : sideToMove); - Square ksq = king_square(FindPinned ? sideToMove : flip(sideToMove)); + Bitboard pinners = pieces(FindPinned ? ~sideToMove : sideToMove); + Square ksq = king_square(FindPinned ? sideToMove : ~sideToMove); // Pinners are sliders, that give check when candidate pinned is removed - pinners &= (pieces(ROOK, QUEEN) & RookPseudoAttacks[ksq]) - | (pieces(BISHOP, QUEEN) & BishopPseudoAttacks[ksq]); + pinners &= (pieces(ROOK, QUEEN) & PseudoAttacks[ROOK][ksq]) + | (pieces(BISHOP, QUEEN) & PseudoAttacks[BISHOP][ksq]); while (pinners) { @@ -399,12 +400,12 @@ Bitboard Position::attacks_from(Piece p, Square s, Bitboard occ) { assert(square_is_ok(s)); - switch (p) + switch (type_of(p)) { - case WB: case BB: return bishop_attacks_bb(s, occ); - case WR: case BR: return rook_attacks_bb(s, occ); - case WQ: case BQ: return bishop_attacks_bb(s, occ) | rook_attacks_bb(s, occ); - default: return StepAttacksBB[p][s]; + case BISHOP: return bishop_attacks_bb(s, occ); + case ROOK : return rook_attacks_bb(s, occ); + case QUEEN : return bishop_attacks_bb(s, occ) | rook_attacks_bb(s, occ); + default : return StepAttacksBB[p][s]; } } @@ -418,8 +419,8 @@ bool Position::move_attacks_square(Move m, Square s) const { assert(square_is_ok(s)); Bitboard occ, xray; - Square from = move_from(m); - Square to = move_to(m); + Square from = from_sq(m); + Square to = to_sq(m); Piece piece = piece_on(from); assert(!square_is_empty(from)); @@ -448,8 +449,8 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { assert(is_ok(m)); assert(pinned == pinned_pieces()); - Color us = side_to_move(); - Square from = move_from(m); + Color us = sideToMove; + Square from = from_sq(m); assert(color_of(piece_on(from)) == us); assert(piece_on(king_square(us)) == make_piece(us, KING)); @@ -459,8 +460,8 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { // the move is made. if (is_enpassant(m)) { - Color them = flip(us); - Square to = move_to(m); + Color them = ~us; + Square to = to_sq(m); Square capsq = to + pawn_push(them); Square ksq = king_square(us); Bitboard b = occupied_squares(); @@ -468,7 +469,7 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { assert(to == ep_square()); assert(piece_on(from) == make_piece(us, PAWN)); assert(piece_on(capsq) == make_piece(them, PAWN)); - assert(piece_on(to) == PIECE_NONE); + assert(piece_on(to) == NO_PIECE); clear_bit(&b, from); clear_bit(&b, capsq); @@ -482,13 +483,13 @@ bool Position::pl_move_is_legal(Move m, Bitboard pinned) const { // square is attacked by the opponent. Castling moves are checked // for legality during move generation. if (type_of(piece_on(from)) == KING) - return is_castle(m) || !(attackers_to(move_to(m)) & pieces(flip(us))); + return is_castle(m) || !(attackers_to(to_sq(m)) & pieces(~us)); // A non-king move is legal if and only if it is not pinned or it // is moving along the ray towards or away from the king. return !pinned || !bit_is_set(pinned, from) - || squares_aligned(from, move_to(m), king_square(us)); + || squares_aligned(from, to_sq(m), king_square(us)); } @@ -513,9 +514,9 @@ bool Position::move_is_legal(const Move m) const { bool Position::is_pseudo_legal(const Move m) const { Color us = sideToMove; - Color them = flip(sideToMove); - Square from = move_from(m); - Square to = move_to(m); + Color them = ~sideToMove; + Square from = from_sq(m); + Square to = to_sq(m); Piece pc = piece_on(from); // Use a slower but simpler function for uncommon cases @@ -523,12 +524,12 @@ bool Position::is_pseudo_legal(const Move m) const { return move_is_legal(m); // Is not a promotion, so promotion piece must be empty - if (promotion_piece_type(m) - 2 != PIECE_TYPE_NONE) + if (promotion_piece_type(m) - 2 != NO_PIECE_TYPE) return false; // If the from square is not occupied by a piece belonging to the side to // move, the move is obviously not legal. - if (pc == PIECE_NONE || color_of(pc) != us) + if (pc == NO_PIECE || color_of(pc) != us) return false; // The destination square cannot be occupied by a friendly piece @@ -611,7 +612,7 @@ bool Position::is_pseudo_legal(const Move m) const { { Bitboard b = occupied_squares(); clear_bit(&b, from); - if (attackers_to(move_to(m), b) & pieces(flip(us))) + if (attackers_to(to_sq(m), b) & pieces(~us)) return false; } else @@ -624,7 +625,7 @@ bool Position::is_pseudo_legal(const Move m) const { // Our move must be a blocking evasion or a capture of the checking piece target = squares_between(checksq, king_square(us)) | checkers(); - if (!bit_is_set(target, move_to(m))) + if (!bit_is_set(target, to_sq(m))) return false; } } @@ -639,10 +640,10 @@ bool Position::move_gives_check(Move m, const CheckInfo& ci) const { assert(is_ok(m)); assert(ci.dcCandidates == discovered_check_candidates()); - assert(color_of(piece_on(move_from(m))) == side_to_move()); + assert(color_of(piece_moved(m)) == sideToMove); - Square from = move_from(m); - Square to = move_to(m); + Square from = from_sq(m); + Square to = to_sq(m); PieceType pt = type_of(piece_on(from)); // Direct check ? @@ -654,7 +655,7 @@ bool Position::move_gives_check(Move m, const CheckInfo& ci) const { { // For pawn and king moves we need to verify also direction if ( (pt != PAWN && pt != KING) - || !squares_aligned(from, to, king_square(flip(side_to_move())))) + || !squares_aligned(from, to, king_square(~sideToMove))) return true; } @@ -662,9 +663,9 @@ bool Position::move_gives_check(Move m, const CheckInfo& ci) const { if (!is_special(m)) return false; - Color us = side_to_move(); + Color us = sideToMove; Bitboard b = occupied_squares(); - Square ksq = king_square(flip(us)); + Square ksq = king_square(~us); // Promotion with check ? if (is_promotion(m)) @@ -729,7 +730,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI assert(&newSt != st); nodes++; - Key key = st->key; + Key k = st->key; // Copy some fields of old state to our new StateInfo object except the ones // which are recalculated from scratch anyway, then switch our state pointer @@ -748,7 +749,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI st = &newSt; // Update side to move - key ^= zobSideToMove; + k ^= zobSideToMove; // Increment the 50 moves rule draw counter. Resetting it to zero in the // case of non-reversible moves is taken care of later. @@ -757,15 +758,15 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI if (is_castle(m)) { - st->key = key; + st->key = k; do_castle_move(m); return; } - Color us = side_to_move(); - Color them = flip(us); - Square from = move_from(m); - Square to = move_to(m); + Color us = sideToMove; + Color them = ~us; + Square from = from_sq(m); + Square to = to_sq(m); Piece piece = piece_on(from); PieceType pt = type_of(piece); PieceType capture = is_enpassant(m) ? PAWN : type_of(piece_on(to)); @@ -789,10 +790,10 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI assert(pt == PAWN); assert(to == st->epSquare); assert(relative_rank(us, to) == RANK_6); - assert(piece_on(to) == PIECE_NONE); + assert(piece_on(to) == NO_PIECE); assert(piece_on(capsq) == make_piece(them, PAWN)); - board[capsq] = PIECE_NONE; + board[capsq] = NO_PIECE; } st->pawnKey ^= zobrist[them][PAWN][capsq]; @@ -818,7 +819,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI pieceList[them][capture][pieceCount[them][capture]] = SQ_NONE; // Update hash keys - key ^= zobrist[them][capture][capsq]; + k ^= zobrist[them][capture][capsq]; st->materialKey ^= zobrist[them][capture][pieceCount[them][capture]]; // Update incremental scores @@ -829,12 +830,12 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI } // Update hash key - key ^= zobrist[us][pt][from] ^ zobrist[us][pt][to]; + k ^= zobrist[us][pt][from] ^ zobrist[us][pt][to]; // Reset en passant square if (st->epSquare != SQ_NONE) { - key ^= zobEp[st->epSquare]; + k ^= zobEp[st->epSquare]; st->epSquare = SQ_NONE; } @@ -842,13 +843,13 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI if ( st->castleRights != CASTLES_NONE && (castleRightsMask[from] & castleRightsMask[to]) != ALL_CASTLES) { - key ^= zobCastle[st->castleRights]; + k ^= zobCastle[st->castleRights]; st->castleRights &= castleRightsMask[from] & castleRightsMask[to]; - key ^= zobCastle[st->castleRights]; + k ^= zobCastle[st->castleRights]; } // Prefetch TT access as soon as we know key is updated - prefetch((char*)TT.first_entry(key)); + prefetch((char*)TT.first_entry(k)); // Move the piece Bitboard move_bb = make_move_bb(from, to); @@ -857,7 +858,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI do_move_bb(&occupied, move_bb); board[to] = board[from]; - board[from] = PIECE_NONE; + board[from] = NO_PIECE; // Update piece lists, index[from] is not updated and becomes stale. This // works as long as index[] is accessed just by known occupied squares. @@ -872,7 +873,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI && (attacks_from(from + pawn_push(us), us) & pieces(PAWN, them))) { st->epSquare = Square((from + to) / 2); - key ^= zobEp[st->epSquare]; + k ^= zobEp[st->epSquare]; } if (is_promotion(m)) @@ -897,7 +898,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI pieceList[us][promotion][index[to]] = to; // Update hash keys - key ^= zobrist[us][PAWN][to] ^ zobrist[us][promotion][to]; + k ^= zobrist[us][PAWN][to] ^ zobrist[us][promotion][to]; st->pawnKey ^= zobrist[us][PAWN][to]; st->materialKey ^= zobrist[us][promotion][pieceCount[us][promotion]++] ^ zobrist[us][PAWN][pieceCount[us][PAWN]]; @@ -928,10 +929,10 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI st->capturedType = capture; // Update the key with the final value - st->key = key; + st->key = k; // Update checkers bitboard, piece must be already moved - st->checkersBB = EmptyBoardBB; + st->checkersBB = 0; if (moveIsCheck) { @@ -956,7 +957,7 @@ void Position::do_move(Move m, StateInfo& newSt, const CheckInfo& ci, bool moveI } // Finish - sideToMove = flip(sideToMove); + sideToMove = ~sideToMove; st->value += (sideToMove == WHITE ? TempoValue : -TempoValue); assert(pos_is_ok()); @@ -970,7 +971,7 @@ void Position::undo_move(Move m) { assert(is_ok(m)); - sideToMove = flip(sideToMove); + sideToMove = ~sideToMove; if (is_castle(m)) { @@ -978,10 +979,10 @@ void Position::undo_move(Move m) { return; } - Color us = side_to_move(); - Color them = flip(us); - Square from = move_from(m); - Square to = move_to(m); + Color us = sideToMove; + Color them = ~us; + Square from = from_sq(m); + Square to = to_sq(m); Piece piece = piece_on(to); PieceType pt = type_of(piece); PieceType capture = st->capturedType; @@ -1022,7 +1023,7 @@ void Position::undo_move(Move m) { do_move_bb(&occupied, move_bb); board[from] = board[to]; - board[to] = PIECE_NONE; + board[to] = NO_PIECE; // Update piece lists, index[to] is not updated and becomes stale. This // works as long as index[] is accessed just by known occupied squares. @@ -1040,7 +1041,7 @@ void Position::undo_move(Move m) { assert(pt == PAWN); assert(to == st->previous->epSquare); assert(relative_rank(us, to) == RANK_6); - assert(piece_on(capsq) == PIECE_NONE); + assert(piece_on(capsq) == NO_PIECE); } // Restore the captured piece @@ -1074,9 +1075,9 @@ void Position::do_castle_move(Move m) { Square kto, kfrom, rfrom, rto, kAfter, rAfter; - Color us = side_to_move(); - Square kBefore = move_from(m); - Square rBefore = move_to(m); + Color us = sideToMove; + Square kBefore = from_sq(m); + Square rBefore = to_sq(m); // Find after-castle squares for king and rook if (rBefore > kBefore) // O-O @@ -1118,7 +1119,7 @@ void Position::do_castle_move(Move m) { // Update board Piece king = make_piece(us, KING); Piece rook = make_piece(us, ROOK); - board[kfrom] = board[rfrom] = PIECE_NONE; + board[kfrom] = board[rfrom] = NO_PIECE; board[kto] = king; board[rto] = rook; @@ -1132,7 +1133,7 @@ void Position::do_castle_move(Move m) { if (Do) { // Reset capture field - st->capturedType = PIECE_TYPE_NONE; + st->capturedType = NO_PIECE_TYPE; // Update incremental scores st->value += pst_delta(king, kfrom, kto); @@ -1158,10 +1159,10 @@ void Position::do_castle_move(Move m) { st->rule50 = 0; // Update checkers BB - st->checkersBB = attackers_to(king_square(flip(us))) & pieces(us); + st->checkersBB = attackers_to(king_square(~us)) & pieces(us); // Finish - sideToMove = flip(sideToMove); + sideToMove = ~sideToMove; st->value += (sideToMove == WHITE ? TempoValue : -TempoValue); } else @@ -1192,7 +1193,7 @@ void Position::do_null_move(StateInfo& backupSt) { dst->rule50 = src->rule50; dst->pliesFromNull = src->pliesFromNull; - sideToMove = flip(sideToMove); + sideToMove = ~sideToMove; if (Do) { @@ -1226,8 +1227,8 @@ int Position::see_sign(Move m) const { assert(is_ok(m)); - Square from = move_from(m); - Square to = move_to(m); + Square from = from_sq(m); + Square to = to_sq(m); // Early return if SEE cannot be negative because captured piece value // is not less then capturing one. Note that king moves always return @@ -1254,17 +1255,17 @@ int Position::see(Move m) const { if (is_castle(m)) return 0; - from = move_from(m); - to = move_to(m); + from = from_sq(m); + to = to_sq(m); capturedType = type_of(piece_on(to)); occ = occupied_squares(); // Handle en passant moves if (is_enpassant(m)) { - Square capQq = to - pawn_push(side_to_move()); + Square capQq = to - pawn_push(sideToMove); - assert(capturedType == PIECE_TYPE_NONE); + assert(!capturedType); assert(type_of(piece_on(capQq)) == PAWN); // Remove the captured pawn @@ -1278,7 +1279,7 @@ int Position::see(Move m) const { attackers = attackers_to(to, occ); // If the opponent has no attackers we are finished - stm = flip(color_of(piece_on(from))); + stm = ~color_of(piece_on(from)); stmAttackers = attackers & pieces(stm); if (!stmAttackers) return PieceValueMidgame[capturedType]; @@ -1316,7 +1317,7 @@ int Position::see(Move m) const { // Remember the value of the capturing piece, and change the side to // move before beginning the next iteration. capturedType = pt; - stm = flip(stm); + stm = ~stm; stmAttackers = attackers & pieces(stm); // Stop before processing a king capture @@ -1357,7 +1358,7 @@ void Position::clear() { for (Square sq = SQ_A1; sq <= SQ_H8; sq++) { - board[sq] = PIECE_NONE; + board[sq] = NO_PIECE; castleRightsMask[sq] = ALL_CASTLES; } sideToMove = WHITE; @@ -1400,7 +1401,7 @@ Key Position::compute_key() const { if (ep_square() != SQ_NONE) result ^= zobEp[ep_square()]; - if (side_to_move() == BLACK) + if (sideToMove == BLACK) result ^= zobSideToMove; return result; @@ -1464,7 +1465,7 @@ Score Position::compute_value() const { result += pst(make_piece(c, pt), pop_1st_bit(&b)); } - result += (side_to_move() == WHITE ? TempoValue / 2 : -TempoValue / 2); + result += (sideToMove == WHITE ? TempoValue / 2 : -TempoValue / 2); return result; } @@ -1497,7 +1498,7 @@ bool Position::is_draw() const { return true; // Draw by the 50 moves rule? - if (st->rule50 > 99 && !is_mate()) + if (st->rule50 > 99 && (!in_check() || MoveList(*this).size())) return true; // Draw by repetition? @@ -1529,15 +1530,6 @@ template bool Position::is_draw() const; template bool Position::is_draw() const; -/// Position::is_mate() returns true or false depending on whether the -/// side to move is checkmated. - -bool Position::is_mate() const { - - return in_check() && !MoveList(*this).size(); -} - - /// Position::init() is a static member function which initializes at startup /// the various arrays used to compute hash keys and the piece square tables. /// The latter is a two-step operation: First, the white halves of the tables @@ -1562,14 +1554,14 @@ void Position::init() { zobSideToMove = rk.rand(); zobExclusion = rk.rand(); - for (Piece p = WP; p <= WK; p++) + for (Piece p = W_PAWN; p <= W_KING; p++) { Score ps = make_score(PieceValueMidgame[p], PieceValueEndgame[p]); for (Square s = SQ_A1; s <= SQ_H8; s++) { pieceSquareTable[p][s] = ps + PSQT[p][s]; - pieceSquareTable[p+8][flip(s)] = -pieceSquareTable[p][s]; + pieceSquareTable[p+8][~s] = -pieceSquareTable[p][s]; } } } @@ -1589,27 +1581,27 @@ void Position::flip_me() { // Board for (Square s = SQ_A1; s <= SQ_H8; s++) if (!pos.square_is_empty(s)) - put_piece(Piece(pos.piece_on(s) ^ 8), flip(s)); + put_piece(Piece(pos.piece_on(s) ^ 8), ~s); // Side to move - sideToMove = flip(pos.side_to_move()); + sideToMove = ~pos.side_to_move(); // Castling rights if (pos.can_castle(WHITE_OO)) - set_castle_right(king_square(BLACK), flip(pos.castle_rook_square(WHITE_OO))); + set_castle_right(BLACK, ~pos.castle_rook_square(WHITE_OO)); if (pos.can_castle(WHITE_OOO)) - set_castle_right(king_square(BLACK), flip(pos.castle_rook_square(WHITE_OOO))); + set_castle_right(BLACK, ~pos.castle_rook_square(WHITE_OOO)); if (pos.can_castle(BLACK_OO)) - set_castle_right(king_square(WHITE), flip(pos.castle_rook_square(BLACK_OO))); + set_castle_right(WHITE, ~pos.castle_rook_square(BLACK_OO)); if (pos.can_castle(BLACK_OOO)) - set_castle_right(king_square(WHITE), flip(pos.castle_rook_square(BLACK_OOO))); + set_castle_right(WHITE, ~pos.castle_rook_square(BLACK_OOO)); // En passant square if (pos.st->epSquare != SQ_NONE) - st->epSquare = flip(pos.st->epSquare); + st->epSquare = ~pos.st->epSquare; // Checkers - st->checkersBB = attackers_to(king_square(sideToMove)) & pieces(flip(sideToMove)); + st->checkersBB = attackers_to(king_square(sideToMove)) & pieces(~sideToMove); // Hash keys st->key = compute_key(); @@ -1651,16 +1643,16 @@ bool Position::pos_is_ok(int* failedStep) const { if (failedStep) *failedStep = 1; // Side to move OK? - if (side_to_move() != WHITE && side_to_move() != BLACK) + if (sideToMove != WHITE && sideToMove != BLACK) return false; // Are the king squares in the position correct? if (failedStep) (*failedStep)++; - if (piece_on(king_square(WHITE)) != WK) + if (piece_on(king_square(WHITE)) != W_KING) return false; if (failedStep) (*failedStep)++; - if (piece_on(king_square(BLACK)) != BK) + if (piece_on(king_square(BLACK)) != B_KING) return false; // Do both sides have exactly one king? @@ -1680,8 +1672,8 @@ bool Position::pos_is_ok(int* failedStep) const { if (failedStep) (*failedStep)++; if (debugKingCapture) { - Color us = side_to_move(); - Color them = flip(us); + Color us = sideToMove; + Color them = ~us; Square ksq = king_square(them); if (attackers_to(ksq) & pieces(us)) return false; @@ -1689,7 +1681,7 @@ bool Position::pos_is_ok(int* failedStep) const { // Is there more than 2 checkers? if (failedStep) (*failedStep)++; - if (debugCheckerCount && count_1s(st->checkersBB) > 2) + if (debugCheckerCount && popcount(st->checkersBB) > 2) return false; // Bitboards OK? @@ -1697,7 +1689,7 @@ bool Position::pos_is_ok(int* failedStep) const { if (debugBitboards) { // The intersection of the white and black pieces must be empty - if ((pieces(WHITE) & pieces(BLACK)) != EmptyBoardBB) + if (!(pieces(WHITE) & pieces(BLACK))) return false; // The union of the white and black pieces must be equal to all @@ -1718,7 +1710,7 @@ bool Position::pos_is_ok(int* failedStep) const { { // The en passant square must be on rank 6, from the point of view of the // side to move. - if (relative_rank(side_to_move(), ep_square()) != RANK_6) + if (relative_rank(sideToMove, ep_square()) != RANK_6) return false; } @@ -1758,7 +1750,7 @@ bool Position::pos_is_ok(int* failedStep) const { if (debugPieceCounts) for (Color c = WHITE; c <= BLACK; c++) for (PieceType pt = PAWN; pt <= KING; pt++) - if (pieceCount[c][pt] != count_1s(pieces(pt, c))) + if (pieceCount[c][pt] != popcount(pieces(pt, c))) return false; if (failedStep) (*failedStep)++; @@ -1781,7 +1773,7 @@ bool Position::pos_is_ok(int* failedStep) const { if (!can_castle(f)) continue; - Piece rook = (f & (WHITE_OO | WHITE_OOO) ? WR : BR); + Piece rook = (f & (WHITE_OO | WHITE_OOO) ? W_ROOK : B_ROOK); if ( castleRightsMask[castleRookSquare[f]] != (ALL_CASTLES ^ f) || piece_on(castleRookSquare[f]) != rook)