X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fsearch.cpp;h=2c91d7789c4bb5bef69a61b44ff94b6af6c2d432;hp=121575f554525c6a2b13b52140a7d4d6fa2f86b6;hb=9ecdfd24018722dc70fb0a448c1c9d731d6e30a2;hpb=5d6b2f214408d688e1614c7a301c6431ec48caf7 diff --git a/src/search.cpp b/src/search.cpp index 121575f5..2c91d778 100644 --- a/src/search.cpp +++ b/src/search.cpp @@ -263,7 +263,6 @@ namespace { // Multi-threads related variables Depth MinimumSplitDepth; int MaxThreadsPerSplitPoint; - bool UseSleepingMaster; ThreadsManager ThreadsMgr; // Node counters, used only by thread[0] but try to keep in different cache @@ -456,7 +455,6 @@ bool think(Position& pos, bool infinite, bool ponder, int time[], int increment[ MaxThreadsPerSplitPoint = Options["Maximum Number of Threads per Split Point"].value(); MultiPV = Options["MultiPV"].value(); UseLogFile = Options["Use Search Log"].value(); - UseSleepingMaster = Options["Use Sleeping Master"].value(); if (UseLogFile) LogFile.open(Options["Search Log Filename"].value().c_str(), std::ios::out | std::ios::app); @@ -2184,9 +2182,6 @@ split_point_start: // At split points actual search starts from here assert(threadID >= 0 && threadID < MAX_THREADS); - int i; - bool allFinished = false; - while (true) { // Slave threads can exit as soon as AllThreadsShouldExit raises, @@ -2202,23 +2197,23 @@ split_point_start: // At split points actual search starts from here // instead of wasting CPU time polling for work. while ( threadID >= ActiveThreads || threads[threadID].state == THREAD_INITIALIZING - || (threads[threadID].state == THREAD_AVAILABLE && (!sp || UseSleepingMaster))) + || (!sp && threads[threadID].state == THREAD_AVAILABLE)) { - lock_grab(&MPLock); + assert(!sp); + assert(threadID != 0); + + if (AllThreadsShouldExit) + break; - // Test with lock held to avoid races with wake_sleeping_thread() - for (i = 0; sp && i < ActiveThreads && !sp->slaves[i]; i++) {} - allFinished = (i == ActiveThreads); + lock_grab(&MPLock); - // Retest sleep conditions under lock protection - if ( AllThreadsShouldExit - || allFinished - || !( threadID >= ActiveThreads - || threads[threadID].state == THREAD_INITIALIZING - || (threads[threadID].state == THREAD_AVAILABLE && (!sp || UseSleepingMaster)))) + // Retest condition under lock protection + if (!( threadID >= ActiveThreads + || threads[threadID].state == THREAD_INITIALIZING + || (!sp && threads[threadID].state == THREAD_AVAILABLE))) { lock_release(&MPLock); - break; + continue; } // Put thread to sleep @@ -2248,19 +2243,14 @@ split_point_start: // At split points actual search starts from here assert(threads[threadID].state == THREAD_SEARCHING); threads[threadID].state = THREAD_AVAILABLE; - - // Wake up master thread so to allow it to return from the idle loop in - // case we are the last slave of the split point. - if (UseSleepingMaster && threadID != tsp->master && threads[tsp->master].state == THREAD_AVAILABLE) - wake_sleeping_thread(tsp->master); } // If this thread is the master of a split point and all slaves have // finished their work at this split point, return from the idle loop. - for (i = 0; sp && i < ActiveThreads && !sp->slaves[i]; i++) {} - allFinished = (i == ActiveThreads); + int i = 0; + for ( ; sp && i < ActiveThreads && !sp->slaves[i]; i++) {} - if (allFinished) + if (i == ActiveThreads) { // Because sp->slaves[] is reset under lock protection, // be sure sp->lock has been released before to return. @@ -2468,7 +2458,6 @@ split_point_start: // At split points actual search starts from here // Initialize the split point object splitPoint.parent = masterThread.splitPoint; - splitPoint.master = master; splitPoint.stopRequest = false; splitPoint.ply = ply; splitPoint.depth = depth;