X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fsearch.cpp;h=ddcc851eb8cfa1d014fe5ecd06d21075507500b4;hp=1110faaae2fcb355343e54809eae49601064c55c;hb=b7c36d078b2a11252f0b66e703e134673997fd29;hpb=da7d872eda42d2df9b80af7e46f047b0328cc90e diff --git a/src/search.cpp b/src/search.cpp index 1110faaa..ddcc851e 100644 --- a/src/search.cpp +++ b/src/search.cpp @@ -133,6 +133,9 @@ namespace { // evaluation of the position is more than NullMoveMargin below beta. const Value NullMoveMargin = Value(0x300); + // Use null capture pruning? + const bool UseNullCapturePruning = false; + // Pruning criterions. See the code and comments in ok_to_prune() to // understand their precise meaning. const bool PruneEscapeMoves = false; @@ -188,7 +191,7 @@ namespace { // Time managment variables int SearchStartTime; int MaxNodes, MaxDepth; - int MaxSearchTime, AbsoluteMaxSearchTime, ExtraSearchTime, TimeAdvantage; + int MaxSearchTime, AbsoluteMaxSearchTime, ExtraSearchTime; Move BestRootMove, PonderMove, EasyMove; int RootMoveNumber; bool InfiniteSearch; @@ -245,7 +248,7 @@ namespace { void sp_update_pv(SearchStack *pss, SearchStack ss[], int ply); bool connected_moves(const Position &pos, Move m1, Move m2); bool move_is_killer(Move m, const SearchStack& ss); - Depth extension(const Position &pos, Move m, bool pvNode, bool check, bool singleReply, bool mateThreat); + Depth extension(const Position &pos, Move m, bool pvNode, bool check, bool singleReply, bool mateThreat, bool* dangerous); bool ok_to_do_nullmove(const Position &pos); bool ok_to_prune(const Position &pos, Move m, Move threat, Depth d); bool ok_to_use_TT(const TTEntry* tte, Depth depth, Value beta, int ply); @@ -427,16 +430,14 @@ void think(const Position &pos, bool infinite, bool ponder, int side_to_move, int myIncrement = increment[side_to_move]; int oppTime = time[1 - side_to_move]; - TimeAdvantage = myTime - oppTime; - if (!movesToGo) // Sudden death time control { - if (increment) + if (myIncrement) { MaxSearchTime = myTime / 30 + myIncrement; AbsoluteMaxSearchTime = Max(myTime / 4, myIncrement - 100); } else { // Blitz game without increment - MaxSearchTime = myTime / 40; + MaxSearchTime = myTime / 30; AbsoluteMaxSearchTime = myTime / 8; } } @@ -680,10 +681,6 @@ namespace { ExtraSearchTime = BestMoveChangesByIteration[Iteration] * (MaxSearchTime / 2) + BestMoveChangesByIteration[Iteration-1] * (MaxSearchTime / 3); - // If we need some more and we are in time advantage take it - if (ExtraSearchTime > 0 && TimeAdvantage > 2 * MaxSearchTime) - ExtraSearchTime += MaxSearchTime / 2; - // Try to guess if the current iteration is the last one or the last two LastIterations = (current_search_time() > ((MaxSearchTime + ExtraSearchTime)*58) / 128); @@ -778,7 +775,8 @@ namespace { << " currmovenumber " << i + 1 << std::endl; // Decide search depth for this move - ext = extension(pos, move, true, pos.move_is_check(move), false, false); + bool dangerous; + ext = extension(pos, move, true, pos.move_is_check(move), false, false, &dangerous); newDepth = (Iteration - 2) * OnePly + ext + InitialDepth; // Make the move, and search it @@ -952,8 +950,7 @@ namespace { Value value, bestValue = -VALUE_INFINITE; Bitboard dcCandidates = mp.discovered_check_candidates(); bool isCheck = pos.is_check(); - bool mateThreat = MateThreatExtension[1] > Depth(0) - && pos.has_mate_threat(opposite_color(pos.side_to_move())); + bool mateThreat = pos.has_mate_threat(opposite_color(pos.side_to_move())); // Loop through all legal moves until no moves remain or a beta cutoff // occurs. @@ -966,7 +963,6 @@ namespace { bool singleReply = (isCheck && mp.number_of_moves() == 1); bool moveIsCheck = pos.move_is_check(move, dcCandidates); bool moveIsCapture = pos.move_is_capture(move); - bool moveIsPassedPawnPush = pos.move_is_passed_pawn_push(move); movesSearched[moveCount++] = ss[ply].currentMove = move; @@ -978,7 +974,8 @@ namespace { ss[ply].currentMoveCaptureValue = Value(0); // Decide the new search depth - Depth ext = extension(pos, move, true, moveIsCheck, singleReply, mateThreat); + bool dangerous; + Depth ext = extension(pos, move, true, moveIsCheck, singleReply, mateThreat, &dangerous); Depth newDepth = depth - OnePly + ext; // Make and search the move @@ -992,11 +989,10 @@ namespace { // Try to reduce non-pv search depth by one ply if move seems not problematic, // if the move fails high will be re-searched at full depth. if ( depth >= 2*OnePly - && ext == Depth(0) && moveCount >= LMRPVMoves + && !dangerous && !moveIsCapture && !move_promotion(move) - && !moveIsPassedPawnPush && !move_is_castle(move) && !move_is_killer(move, ss[ply])) { @@ -1137,6 +1133,7 @@ namespace { Value approximateEval = quick_evaluate(pos); bool mateThreat = false; + bool nullCapturePruning = false; bool isCheck = pos.is_check(); // Null move search @@ -1150,7 +1147,20 @@ namespace { UndoInfo u; pos.do_null_move(u); int R = (depth > 7 ? 4 : 3); + Value nullValue = -search(pos, ss, -(beta-1), depth-R*OnePly, ply+1, false, threadID); + + // Check for a null capture artifact, if the value without the null capture + // is above beta then mark the node as a suspicious failed low. We will verify + // later if we are really under threat. + if ( UseNullCapturePruning + && nullValue < beta + && depth < 5 * OnePly + && ss[ply + 1].currentMove != MOVE_NONE + && pos.move_is_capture(ss[ply + 1].currentMove) + && pos.see(ss[ply + 1].currentMove) * PawnValueMidgame + nullValue > beta) + nullCapturePruning = true; + pos.undo_null_move(u); if (nullValue >= beta) @@ -1177,6 +1187,26 @@ namespace { && ss[ply - 1].reduction && connected_moves(pos, ss[ply - 1].currentMove, ss[ply].threatMove)) return beta - 1; + + if (nullCapturePruning && !mateThreat) + { + // The null move failed low due to a suspicious capture. Verify if + // position is really dangerous or we are facing a null capture + // artifact due to the side to move change. So search this + // position with a reduced depth and see if we still fail low. + Move tm = ss[ply].threatMove; + + assert(tm != MOVE_NONE); + + Value v = search(pos, ss, beta, depth-3*OnePly, ply, false, threadID); + if (v >= beta) + return beta; + + // Restore stack and update ttMove if was empty + ss[ply].threatMove = tm; + if (ttMove == MOVE_NONE) + ttMove = ss[ply].pv[ply]; + } } } // Null move search not allowed, try razoring @@ -1220,19 +1250,18 @@ namespace { bool singleReply = (isCheck && mp.number_of_moves() == 1); bool moveIsCheck = pos.move_is_check(move, dcCandidates); bool moveIsCapture = pos.move_is_capture(move); - bool moveIsPassedPawnPush = pos.move_is_passed_pawn_push(move); movesSearched[moveCount++] = ss[ply].currentMove = move; // Decide the new search depth - Depth ext = extension(pos, move, false, moveIsCheck, singleReply, mateThreat); + bool dangerous; + Depth ext = extension(pos, move, false, moveIsCheck, singleReply, mateThreat, &dangerous); Depth newDepth = depth - OnePly + ext; // Futility pruning if ( useFutilityPruning - && ext == Depth(0) + && !dangerous && !moveIsCapture - && !moveIsPassedPawnPush && !move_promotion(move)) { if ( moveCount >= 2 + int(depth) @@ -1260,12 +1289,11 @@ namespace { // Try to reduce non-pv search depth by one ply if move seems not problematic, // if the move fails high will be re-searched at full depth. - if ( depth >= 2*OnePly - && ext == Depth(0) - && moveCount >= LMRNonPVMoves + if ( depth >= 2*OnePly + && moveCount >= LMRNonPVMoves + && !dangerous && !moveIsCapture && !move_promotion(move) - && !moveIsPassedPawnPush && !move_is_castle(move) && !move_is_killer(move, ss[ply])) { @@ -1398,20 +1426,17 @@ namespace { { assert(move_is_ok(move)); - bool moveIsCheck = pos.move_is_check(move, dcCandidates); - bool moveIsPassedPawnPush = pos.move_is_passed_pawn_push(move); - moveCount++; ss[ply].currentMove = move; // Futility pruning if ( UseQSearchFutilityPruning + && enoughMaterial && !isCheck - && !moveIsCheck - && !move_promotion(move) - && !moveIsPassedPawnPush && !pvNode - && enoughMaterial) + && !move_promotion(move) + && !pos.move_is_check(move, dcCandidates) + && !pos.move_is_passed_pawn_push(move)) { Value futilityValue = staticValue + Max(pos.midgame_value_of_piece_on(move_to(move)), @@ -1430,7 +1455,6 @@ namespace { // Don't search captures and checks with negative SEE values if ( !isCheck && !move_promotion(move) - && !pvNode && (pos.midgame_value_of_piece_on(move_from(move)) > pos.midgame_value_of_piece_on(move_to(move))) && pos.see(move) < 0) @@ -1507,7 +1531,6 @@ namespace { bool moveIsCheck = pos.move_is_check(move, sp->dcCandidates); bool moveIsCapture = pos.move_is_capture(move); - bool moveIsPassedPawnPush = pos.move_is_passed_pawn_push(move); lock_grab(&(sp->lock)); int moveCount = ++sp->moves; @@ -1516,14 +1539,14 @@ namespace { ss[sp->ply].currentMove = move; // Decide the new search depth. - Depth ext = extension(pos, move, false, moveIsCheck, false, false); + bool dangerous; + Depth ext = extension(pos, move, false, moveIsCheck, false, false, &dangerous); Depth newDepth = sp->depth - OnePly + ext; // Prune? if ( useFutilityPruning - && ext == Depth(0) + && !dangerous && !moveIsCapture - && !moveIsPassedPawnPush && !move_promotion(move) && moveCount >= 2 + int(sp->depth) && ok_to_prune(pos, move, ss[sp->ply].threatMove, sp->depth)) @@ -1535,10 +1558,9 @@ namespace { // Try to reduce non-pv search depth by one ply if move seems not problematic, // if the move fails high will be re-searched at full depth. - if ( ext == Depth(0) + if ( !dangerous && moveCount >= LMRNonPVMoves && !moveIsCapture - && !moveIsPassedPawnPush && !move_promotion(move) && !move_is_castle(move) && !move_is_killer(move, ss[sp->ply])) @@ -1619,7 +1641,6 @@ namespace { { bool moveIsCheck = pos.move_is_check(move, sp->dcCandidates); bool moveIsCapture = pos.move_is_capture(move); - bool moveIsPassedPawnPush = pos.move_is_passed_pawn_push(move); assert(move_is_ok(move)); @@ -1633,7 +1654,8 @@ namespace { ss[sp->ply].currentMove = move; // Decide the new search depth. - Depth ext = extension(pos, move, true, moveIsCheck, false, false); + bool dangerous; + Depth ext = extension(pos, move, true, moveIsCheck, false, false, &dangerous); Depth newDepth = sp->depth - OnePly + ext; // Make and search the move. @@ -1642,10 +1664,9 @@ namespace { // Try to reduce non-pv search depth by one ply if move seems not problematic, // if the move fails high will be re-searched at full depth. - if ( ext == Depth(0) + if ( !dangerous && moveCount >= LMRPVMoves && !moveIsCapture - && !moveIsPassedPawnPush && !move_promotion(move) && !move_is_castle(move) && !move_is_killer(move, ss[sp->ply])) @@ -1924,7 +1945,6 @@ namespace { NodesSincePoll = 0; } } - ss[ply].pv[ply] = ss[ply].pv[ply+1] = ss[ply].currentMove = MOVE_NONE; ss[ply+2].mateKiller = MOVE_NONE; ss[ply].threatMove = MOVE_NONE; @@ -2050,12 +2070,16 @@ namespace { // extension() decides whether a move should be searched with normal depth, // or with extended depth. Certain classes of moves (checking moves, in - // particular) are searched with bigger depth than ordinary moves. + // particular) are searched with bigger depth than ordinary moves and in + // any case are marked as 'dangerous'. Note that also if a move is not + // extended, as example because the corresponding UCI option is set to zero, + // the move is marked as 'dangerous' so, at least, we avoid to prune it. - Depth extension(const Position &pos, Move m, bool pvNode, - bool check, bool singleReply, bool mateThreat) { + Depth extension(const Position &pos, Move m, bool pvNode, bool check, + bool singleReply, bool mateThreat, bool* dangerous) { Depth result = Depth(0); + *dangerous = check || singleReply || mateThreat; if (check) result += CheckExtension[pvNode]; @@ -2063,26 +2087,37 @@ namespace { if (singleReply) result += SingleReplyExtension[pvNode]; + if (mateThreat) + result += MateThreatExtension[pvNode]; + if (pos.move_is_pawn_push_to_7th(m)) + { result += PawnPushTo7thExtension[pvNode]; - + *dangerous = true; + } if (pos.move_is_passed_pawn_push(m)) + { result += PassedPawnExtension[pvNode]; - - if (mateThreat) - result += MateThreatExtension[pvNode]; + *dangerous = true; + } if ( pos.midgame_value_of_piece_on(move_to(m)) >= RookValueMidgame && ( pos.non_pawn_material(WHITE) + pos.non_pawn_material(BLACK) - pos.midgame_value_of_piece_on(move_to(m)) == Value(0)) && !move_promotion(m)) + { result += PawnEndgameExtension[pvNode]; + *dangerous = true; + } if ( pvNode && pos.move_is_capture(m) && pos.type_of_piece_on(move_to(m)) != PAWN && pos.see(m) >= 0) + { result += OnePly/2; + *dangerous = true; + } return Min(result, OnePly); }