X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fsearch.cpp;h=eaba6c6d83b96fee4797696a6c606c3648bddfe6;hp=371144086898bf417e16af7d17a261e8b5849870;hb=bed4075580e87dd85c8c80dbd7c828268af2e324;hpb=5a2d525048ca5eec1d5d0effc8868cb2fdc701bb diff --git a/src/search.cpp b/src/search.cpp index 37114408..eaba6c6d 100644 --- a/src/search.cpp +++ b/src/search.cpp @@ -1826,7 +1826,6 @@ void Thread::idle_loop(SplitPoint* sp_master) { Stack ss[MAX_PLY_PLUS_2]; Position pos(*sp->pos); - Thread* master = sp->master; memcpy(ss, sp->ss - 1, 4 * sizeof(Stack)); (ss+1)->sp = sp; @@ -1848,17 +1847,18 @@ void Thread::idle_loop(SplitPoint* sp_master) { sp->slavesMask &= ~(1ULL << idx); sp->nodes += pos.nodes_searched(); - // After releasing the lock we cannot access anymore any SplitPoint - // related data in a reliably way becuase it could have been released - // under our feet by the sp master. - lock_release(sp->lock); - // Wake up master thread so to allow it to return from the idle loop in // case we are the last slave of the split point. if ( Threads.use_sleeping_threads() - && this != master - && !master->is_searching) - master->wake_up(); + && this != sp->master + && !sp->master->is_searching) + sp->master->wake_up(); + + // After releasing the lock we cannot access anymore any SplitPoint + // related data in a safe way becuase it could have been released under + // our feet by the sp master. Also accessing other Thread objects is + // unsafe because if we are exiting there is a chance are already freed. + lock_release(sp->lock); } } }