X-Git-Url: https://git.sesse.net/?p=stockfish;a=blobdiff_plain;f=src%2Fthread.cpp;h=ff52576b062785c49f8eae6bfa360b0380dbae71;hp=279d9cfe2cdede4a254a126346530ab3c6925357;hb=cb2111f0b62afec5fd977e1dd4ca5843bd006956;hpb=40548c9153ea89c0b27b198efb443c5bb9b9c490 diff --git a/src/thread.cpp b/src/thread.cpp index 279d9cfe..ff52576b 100644 --- a/src/thread.cpp +++ b/src/thread.cpp @@ -102,14 +102,13 @@ bool Thread::cutoff_occurred() const { } -// Thread::available_to() checks whether the thread is available to help the -// thread 'master' at a split point. An obvious requirement is that thread must -// be idle. With more than two threads, this is not sufficient: If the thread is -// the master of some split point, it is only available as a slave to the slaves -// which are busy searching the split point at the top of slave's split point -// stack (the "helpful master concept" in YBWC terminology). +// Thread::can_join() checks whether the thread is available to join the split +// point 'sp'. An obvious requirement is that thread must be idle. With more than +// two threads, this is not sufficient: If the thread is the master of some split +// point, it is only available as a slave for the split points below his active +// one (the "helpful master" concept in YBWC terminology). -bool Thread::available_to(const Thread* master) const { +bool Thread::can_join(const SplitPoint* sp) const { if (searching) return false; @@ -120,7 +119,7 @@ bool Thread::available_to(const Thread* master) const { // No split points means that the thread is available as a slave for any // other thread otherwise apply the "helpful master" concept if possible. - return !size || splitPoints[size - 1].slavesMask.test(master->idx); + return !size || splitPoints[size - 1].slavesMask.test(sp->master->idx); } @@ -145,7 +144,7 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes // Pick and init the next available split point SplitPoint& sp = splitPoints[splitPointsSize]; - sp.masterThread = this; + sp.master = this; sp.parentSplitPoint = activeSplitPoint; sp.slavesMask = 0, sp.slavesMask.set(idx); sp.depth = depth; @@ -165,8 +164,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes // Try to allocate available threads and ask them to start searching setting // 'searching' flag. This must be done under lock protection to avoid concurrent // allocation of the same slave by another master. - Threads.mutex.lock(); - sp.mutex.lock(); + Threads.spinlock.acquire(); + sp.spinlock.acquire(); sp.allSlavesSearching = true; // Must be set under lock protection ++splitPointsSize; @@ -176,10 +175,10 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes Thread* slave; while ( sp.slavesMask.count() < MAX_SLAVES_PER_SPLITPOINT - && (slave = Threads.available_slave(this)) != nullptr) + && (slave = Threads.available_slave(activeSplitPoint)) != nullptr) { sp.slavesMask.set(slave->idx); - slave->activeSplitPoint = &sp; + slave->activeSplitPoint = activeSplitPoint; slave->searching = true; // Slave leaves idle_loop() slave->notify_one(); // Could be sleeping } @@ -188,8 +187,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes // it will instantly launch a search, because its 'searching' flag is set. // The thread will return from the idle loop when all slaves have finished // their work at this split point. - sp.mutex.unlock(); - Threads.mutex.unlock(); + sp.spinlock.release(); + Threads.spinlock.release(); Thread::idle_loop(); // Force a call to base class idle_loop() @@ -202,8 +201,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes // We have returned from the idle loop, which means that all threads are // finished. Note that setting 'searching' and decreasing splitPointsSize must // be done under lock protection to avoid a race with Thread::available_to(). - Threads.mutex.lock(); - sp.mutex.lock(); + Threads.spinlock.acquire(); + sp.spinlock.acquire(); searching = true; --splitPointsSize; @@ -213,8 +212,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes *bestMove = sp.bestMove; *bestValue = sp.bestValue; - sp.mutex.unlock(); - Threads.mutex.unlock(); + sp.spinlock.release(); + Threads.spinlock.release(); } @@ -325,12 +324,12 @@ void ThreadPool::read_uci_options() { // ThreadPool::available_slave() tries to find an idle thread which is available -// as a slave for the thread 'master'. +// to join SplitPoint 'sp'. -Thread* ThreadPool::available_slave(const Thread* master) const { +Thread* ThreadPool::available_slave(const SplitPoint* sp) const { for (Thread* th : *this) - if (th->available_to(master)) + if (th->can_join(sp)) return th; return nullptr; @@ -353,7 +352,7 @@ void ThreadPool::start_thinking(const Position& pos, const LimitsType& limits, StateStackPtr& states) { wait_for_think_finished(); - SearchTime = Time::now(); // As early as possible + SearchTime = now(); // As early as possible Signals.stopOnPonderhit = Signals.firstRootMove = false; Signals.stop = Signals.failedLowAtRoot = false;