]> git.sesse.net Git - stockfish/commitdiff
Sync with master
authorMarco Costalba <mcostalba@gmail.com>
Sat, 28 Feb 2015 19:21:38 +0000 (20:21 +0100)
committerMarco Costalba <mcostalba@gmail.com>
Sat, 28 Feb 2015 19:22:28 +0000 (20:22 +0100)
bench: 8285241

1  2 
src/evaluate.cpp
src/pawns.cpp

diff --combined src/evaluate.cpp
index 25449771ed8388609737d23b4e511faed1d13fcf,c880b7c7845f3c881ba2d7600a662c393e6a9436..30e4c59a040ea1761ebbfa9d6526f5e7f4ee94bc
  
  namespace {
  
 +  namespace Tracing {
 +
 +    enum Term { // First 8 entries are for PieceType
 +      MATERIAL = 8, IMBALANCE, MOBILITY, THREAT, PASSED, SPACE, TOTAL, TERM_NB
 +    };
 +
 +    Score scores[COLOR_NB][TERM_NB];
 +
 +    std::ostream& operator<<(std::ostream& os, Term idx);
 +
 +    double to_cp(Value v);
 +    void write(int idx, Color c, Score s);
 +    void write(int idx, Score w, Score b = SCORE_ZERO);
 +    std::string do_trace(const Position& pos);
 +  }
 +
 +
    // Struct EvalInfo contains various information computed and collected
    // by the evaluation functions.
    struct EvalInfo {
      Bitboard pinnedPieces[COLOR_NB];
    };
  
 -  namespace Tracing {
 -
 -    enum Terms { // First 8 entries are for PieceType
 -      MATERIAL = 8, IMBALANCE, MOBILITY, THREAT, PASSED, SPACE, TOTAL, TERMS_NB
 -    };
 -
 -    Score scores[COLOR_NB][TERMS_NB];
 -    EvalInfo ei;
 -    ScaleFactor sf;
 -
 -    double to_cp(Value v);
 -    void write(int idx, Color c, Score s);
 -    void write(int idx, Score w, Score b = SCORE_ZERO);
 -    void print(std::stringstream& ss, const char* name, int idx);
 -    std::string do_trace(const Position& pos);
 -  }
  
 -  // Evaluation weights, indexed by evaluation term
 +  // Evaluation weights, indexed by the corresponding evaluation term
    enum { Mobility, PawnStructure, PassedPawns, Space, KingSafety };
 +
    const struct Weight { int mg, eg; } Weights[] = {
      {289, 344}, {233, 201}, {221, 273}, {46, 0}, {322, 0}
    };
  
 +  Score operator*(Score s, const Weight& w) {
 +    return make_score(mg_value(s) * w.mg / 256, eg_value(s) * w.eg / 256);
 +  }
 +
 +
    #define V(v) Value(v)
    #define S(mg, eg) make_score(mg, eg)
  
        S( 25, 41), S( 25, 41), S(25, 41), S(25, 41) }
    };
  
 -  // Outpost[PieceType][Square] contains bonuses for knights and bishops outposts,
 -  // indexed by piece type and square (from white's point of view).
 +  // Outpost[Bishop/Knight][Square] contains bonuses for knights and bishops
 +  // outposts, indexed by piece type and square (from white's point of view).
    const Value Outpost[][SQUARE_NB] = {
    {// A     B     C     D     E     F     G     H
      V(0), V(0), V(0), V(0), V(0), V(0), V(0), V(0), // Knights
  
    // ThreatenedByPawn[PieceType] contains a penalty according to which piece
    // type is attacked by an enemy pawn.
 -  const Score ThreatenedByPawn[] = {
 +  const Score ThreatenedByPawn[PIECE_TYPE_NB] = {
-     S(0, 0), S(0, 0), S(87, 118), S(84, 122), S(114, 203), S(121, 217)
+     S(0, 0), S(0, 0), S(107, 138), S(84, 122), S(114, 203), S(121, 217)
    };
  
    // Assorted bonuses and penalties used by evaluation
    // by the space evaluation. In the middlegame, each side is given a bonus
    // based on how many squares inside this area are safe and available for
    // friendly minor pieces.
 -  const Bitboard SpaceMask[] = {
 +  const Bitboard SpaceMask[COLOR_NB] = {
      (FileCBB | FileDBB | FileEBB | FileFBB) & (Rank2BB | Rank3BB | Rank4BB),
      (FileCBB | FileDBB | FileEBB | FileFBB) & (Rank7BB | Rank6BB | Rank5BB)
    };
    // in KingDanger[]. Various little "meta-bonuses" measuring the strength
    // of the enemy attack are added up into an integer, which is used as an
    // index to KingDanger[].
 -  //
 +  Score KingDanger[512];
 +
    // KingAttackWeights[PieceType] contains king attack weights by piece type
 -  const int KingAttackWeights[] = { 0, 0, 7, 5, 4, 1 };
 +  const int KingAttackWeights[PIECE_TYPE_NB] = { 0, 0, 7, 5, 4, 1 };
  
 -  // Bonuses for enemy's safe checks
 +  // Penalties for enemy's safe checks
    const int QueenContactCheck = 89;
    const int RookContactCheck  = 71;
    const int QueenCheck        = 50;
    const int BishopCheck       = 6;
    const int KnightCheck       = 14;
  
 -  // KingDanger[attackUnits] contains the actual king danger weighted
 -  // scores, indexed by a calculated integer number.
 -  Score KingDanger[512];
 -
 -  // apply_weight() weighs score 's' by weight 'w' trying to prevent overflow
 -  Score apply_weight(Score s, const Weight& w) {
 -    return make_score(mg_value(s) * w.mg / 256, eg_value(s) * w.eg / 256);
 -  }
 -
  
    // init_eval_info() initializes king bitboards for given color adding
    // pawn attacks. To be done at the beginning of the evaluation.
    template<Color Us>
    void init_eval_info(const Position& pos, EvalInfo& ei) {
  
 -    const Color  Them = (Us == WHITE ? BLACK : WHITE);
 +    const Color  Them = (Us == WHITE ? BLACK   : WHITE);
      const Square Down = (Us == WHITE ? DELTA_S : DELTA_N);
  
      ei.pinnedPieces[Us] = pos.pinned_pieces(Us);
 -
 -    Bitboard b = ei.attackedBy[Them][KING] = pos.attacks_from<KING>(pos.king_square(Them));
      ei.attackedBy[Us][ALL_PIECES] = ei.attackedBy[Us][PAWN] = ei.pi->pawn_attacks(Us);
 +    Bitboard b = ei.attackedBy[Them][KING] = pos.attacks_from<KING>(pos.king_square(Them));
  
      // Init king safety tables only if we are going to use them
      if (pos.non_pawn_material(Us) >= QueenValueMg)
                     | ei.attackedBy[Them][BISHOP]
                     | ei.attackedBy[Them][ROOK]);
  
 -        int mob = Pt != QUEEN ? popcount<Max15>(b & mobilityArea[Us])
 -                              : popcount<Full >(b & mobilityArea[Us]);
 +        int mob = popcount<Pt == QUEEN ? Full : Max15>(b & mobilityArea[Us]);
  
          mobility[Us] += MobilityBonus[Pt][mob];
  
      Score score = SCORE_ZERO;
  
      // Non-pawn enemies defended by a pawn
 -    defended =  (pos.pieces(Them) ^ pos.pieces(Them, PAWN))
 -              &  ei.attackedBy[Them][PAWN];
 +    defended = (pos.pieces(Them) ^ pos.pieces(Them, PAWN)) & ei.attackedBy[Them][PAWN];
  
      // Add a bonus according to the kind of attacking pieces
      if (defended)
      }
  
      if (Trace)
 -        Tracing::write(Tracing::PASSED, Us, apply_weight(score, Weights[PassedPawns]));
 +        Tracing::write(Tracing::PASSED, Us, score * Weights[PassedPawns]);
  
      // Add the scores to the middlegame and endgame eval
 -    return apply_weight(score, Weights[PassedPawns]);
 +    return score * Weights[PassedPawns];
    }
  
  
  
      // Probe the pawn hash table
      ei.pi = Pawns::probe(pos);
 -    score += apply_weight(ei.pi->pawns_score(), Weights[PawnStructure]);
 +    score += ei.pi->pawns_score() * Weights[PawnStructure];
  
      // Initialize attack and king safety bitboards
      init_eval_info<WHITE>(pos, ei);
  
      // Evaluate pieces and mobility
      score += evaluate_pieces<KNIGHT, WHITE, Trace>(pos, ei, mobility, mobilityArea);
 -    score += apply_weight(mobility[WHITE] - mobility[BLACK], Weights[Mobility]);
 +    score += (mobility[WHITE] - mobility[BLACK]) * Weights[Mobility];
  
      // Evaluate kings after all other pieces because we need complete attack
      // information when computing the king safety evaluation.
      }
  
      // Evaluate space for both sides, only during opening
 -    if (pos.non_pawn_material(WHITE) + pos.non_pawn_material(BLACK) >= 2 * QueenValueMg + 4 * RookValueMg + 2 * KnightValueMg)
 -    {
 -        Score s = evaluate_space<WHITE>(pos, ei) - evaluate_space<BLACK>(pos, ei);
 -        score += apply_weight(s, Weights[Space]);
 -    }
 +    if (pos.non_pawn_material(WHITE) + pos.non_pawn_material(BLACK) >= 11756)
 +        score += (evaluate_space<WHITE>(pos, ei) - evaluate_space<BLACK>(pos, ei)) * Weights[Space];
  
      // Scale winning side if position is more drawish than it appears
      Color strongSide = eg_value(score) > VALUE_DRAW ? WHITE : BLACK;
  
      v /= int(PHASE_MIDGAME);
  
 -    // In case of tracing add all single evaluation contributions for both white and black
 +    // In case of tracing add all single evaluation terms for both white and black
      if (Trace)
      {
          Tracing::write(Tracing::MATERIAL, pos.psq_score());
          Tracing::write(Tracing::IMBALANCE, ei.mi->imbalance());
          Tracing::write(PAWN, ei.pi->pawns_score());
 -        Tracing::write(Tracing::MOBILITY, apply_weight(mobility[WHITE], Weights[Mobility])
 -                                        , apply_weight(mobility[BLACK], Weights[Mobility]));
 -        Tracing::write(Tracing::SPACE, apply_weight(evaluate_space<WHITE>(pos, ei), Weights[Space])
 -                                     , apply_weight(evaluate_space<BLACK>(pos, ei), Weights[Space]));
 +        Tracing::write(Tracing::MOBILITY, mobility[WHITE] * Weights[Mobility]
 +                                        , mobility[BLACK] * Weights[Mobility]);
 +        Tracing::write(Tracing::SPACE, evaluate_space<WHITE>(pos, ei) * Weights[Space]
 +                                     , evaluate_space<BLACK>(pos, ei) * Weights[Space]);
          Tracing::write(Tracing::TOTAL, score);
 -        Tracing::ei = ei;
 -        Tracing::sf = sf;
      }
  
 -    return (pos.side_to_move() == WHITE ? v : -v) + Eval::Tempo;
 +    return (pos.side_to_move() == WHITE ? v : -v) + Eval::Tempo; // Side to move point of view
    }
  
  
 -  // Tracing function definitions
 +  // Tracing functions
  
    double Tracing::to_cp(Value v) { return double(v) / PawnValueEg; }
  
    void Tracing::write(int idx, Color c, Score s) { scores[c][idx] = s; }
  
    void Tracing::write(int idx, Score w, Score b) {
 -
 -    write(idx, WHITE, w);
 -    write(idx, BLACK, b);
 +    scores[WHITE][idx] = w, scores[BLACK][idx] = b;
    }
  
 -  void Tracing::print(std::stringstream& ss, const char* name, int idx) {
 -
 -    Score wScore = scores[WHITE][idx];
 -    Score bScore = scores[BLACK][idx];
 -
 -    switch (idx) {
 -    case MATERIAL: case IMBALANCE: case PAWN: case TOTAL:
 -        ss << std::setw(15) << name << " |   ---   --- |   ---   --- | "
 -           << std::setw(5)  << to_cp(mg_value(wScore - bScore)) << " "
 -           << std::setw(5)  << to_cp(eg_value(wScore - bScore)) << " \n";
 -        break;
 -    default:
 -        ss << std::setw(15) << name << " | " << std::noshowpos
 -           << std::setw(5)  << to_cp(mg_value(wScore)) << " "
 -           << std::setw(5)  << to_cp(eg_value(wScore)) << " | "
 -           << std::setw(5)  << to_cp(mg_value(bScore)) << " "
 -           << std::setw(5)  << to_cp(eg_value(bScore)) << " | "
 -           << std::setw(5)  << to_cp(mg_value(wScore - bScore)) << " "
 -           << std::setw(5)  << to_cp(eg_value(wScore - bScore)) << " \n";
 -    }
 +  std::ostream& Tracing::operator<<(std::ostream& os, Term t) {
 +
 +    double wScore[] = { to_cp(mg_value(scores[WHITE][t])), to_cp(eg_value(scores[WHITE][t])) };
 +    double bScore[] = { to_cp(mg_value(scores[BLACK][t])), to_cp(eg_value(scores[BLACK][t])) };
 +
 +    if (t == MATERIAL || t == IMBALANCE || t == Term(PAWN) || t == TOTAL)
 +        os << "  ---   --- |   ---   --- | ";
 +    else
 +        os << std::setw(5) << wScore[MG] << " " << std::setw(5) << wScore[EG] << " | "
 +           << std::setw(5) << bScore[MG] << " " << std::setw(5) << bScore[EG] << " | ";
 +
 +    os << std::setw(5) << wScore[MG] - bScore[MG] << " "
 +       << std::setw(5) << wScore[EG] - bScore[EG] << " \n";
 +
 +    return os;
    }
  
    std::string Tracing::do_trace(const Position& pos) {
      ss << std::showpoint << std::noshowpos << std::fixed << std::setprecision(2)
         << "      Eval term |    White    |    Black    |    Total    \n"
         << "                |   MG    EG  |   MG    EG  |   MG    EG  \n"
 -       << "----------------+-------------+-------------+-------------\n";
 -
 -    print(ss, "Material", MATERIAL);
 -    print(ss, "Imbalance", IMBALANCE);
 -    print(ss, "Pawns", PAWN);
 -    print(ss, "Knights", KNIGHT);
 -    print(ss, "Bishops", BISHOP);
 -    print(ss, "Rooks", ROOK);
 -    print(ss, "Queens", QUEEN);
 -    print(ss, "Mobility", MOBILITY);
 -    print(ss, "King safety", KING);
 -    print(ss, "Threats", THREAT);
 -    print(ss, "Passed pawns", PASSED);
 -    print(ss, "Space", SPACE);
 -
 -    ss << "----------------+-------------+-------------+-------------\n";
 -    print(ss, "Total", TOTAL);
 +       << "----------------+-------------+-------------+-------------\n"
 +       << "       Material | " << Term(MATERIAL)
 +       << "      Imbalance | " << Term(IMBALANCE)
 +       << "          Pawns | " << Term(PAWN)
 +       << "        Knights | " << Term(KNIGHT)
 +       << "         Bishop | " << Term(BISHOP)
 +       << "          Rooks | " << Term(ROOK)
 +       << "         Queens | " << Term(QUEEN)
 +       << "       Mobility | " << Term(MOBILITY)
 +       << "    King safety | " << Term(KING)
 +       << "        Threats | " << Term(THREAT)
 +       << "   Passed pawns | " << Term(PASSED)
 +       << "          Space | " << Term(SPACE)
 +       << "----------------+-------------+-------------+-------------\n"
 +       << "          Total | " << Term(TOTAL);
  
      ss << "\nTotal Evaluation: " << to_cp(v) << " (white side)\n";
  
@@@ -906,7 -924,7 +906,7 @@@ namespace Eval 
      for (int i = 0; i < 400; ++i)
      {
          t = std::min(Peak, std::min(i * i * 27, t + MaxSlope));
 -        KingDanger[i] = apply_weight(make_score(t / 1000, 0), Weights[KingSafety]);
 +        KingDanger[i] = make_score(t / 1000, 0) * Weights[KingSafety];
      }
    }
  
diff --combined src/pawns.cpp
index 1ae1b17fb1554d110b345c92633c7d6f87edf3b4,c5f1b22c270e2bd40bb7fb2537720a12fa5dcad4..0b5c59d3fae0df6048f7852f872557af5274f16b
@@@ -110,9 -110,9 +110,9 @@@ namespace 
      const Square Right = (Us == WHITE ? DELTA_NE : DELTA_SW);
      const Square Left  = (Us == WHITE ? DELTA_NW : DELTA_SE);
  
-     Bitboard b, p, doubled, connected, supported;
+     Bitboard b, neighbours, doubled, connected, supported, phalanx;
      Square s;
-     bool passed, isolated, opposed, phalanx, backward, lever;
+     bool passed, isolated, opposed, backward, lever;
      Score score = SCORE_ZERO;
      const Square* pl = pos.list<PAWN>(Us);
      const Bitboard* pawnAttacksBB = StepAttacksBB[make_piece(Us, PAWN)];
          // This file cannot be semi-open
          e->semiopenFiles[Us] &= ~(1 << f);
  
-         // Previous rank
-         p = rank_bb(s - Up);
          // Flag the pawn
-         connected   =   ourPawns   & adjacent_files_bb(f) & (rank_bb(s) | p);
-         phalanx     =   connected  & rank_bb(s);
-         supported   =   connected  & p;
-         isolated    = !(ourPawns   & adjacent_files_bb(f));
+         neighbours  =   ourPawns   & adjacent_files_bb(f);
          doubled     =   ourPawns   & forward_bb(Us, s);
          opposed     =   theirPawns & forward_bb(Us, s);
          passed      = !(theirPawns & passed_pawn_mask(Us, s));
          lever       =   theirPawns & pawnAttacksBB[s];
+         phalanx     =   neighbours & rank_bb(s);
+         supported   =   neighbours & rank_bb(s - Up);
+         connected   =   supported | phalanx;
+         isolated    =  !neighbours;
  
          // Test for backward pawn.
 -        // If the pawn is passed, isolated, connected or a lever it cannot be
 +        // If the pawn is passed, isolated, lever or connected it cannot be
          // backward. If there are friendly pawns behind on adjacent files
          // it cannot be backward either.
          if (   (passed | isolated | lever | connected)
              score -= Backward[opposed][f];
  
          if (connected)
-             score += Connected[opposed][phalanx][more_than_one(supported)][relative_rank(Us, s)];
+             score += Connected[opposed][!!phalanx][more_than_one(supported)][relative_rank(Us, s)];
  
          if (lever)
              score += Lever[relative_rank(Us, s)];