Remove strange use of the ternary operator

Note that we read shared data without lock
protection, so code is theoretically prone to
torn reads. But, first splitPoint pointer
never changes, and alpha is of integer type so
it is read in a single DWORD access.

No functional change.

diff --git a/src/search.cpp b/src/search.cpp
index b235a1e6384d98b56d86be13148334b43d43acb2..1214cbdcbd2b02f32d7b132ef02cd5ce4f400264 100644 (file)
--- a/src/search.cpp
+++ b/src/search.cpp
@@ -927,7 +927,8 @@ split_point_start: // At split points actual search starts from here
       {
           ss->reduction = reduction<PvNode>(depth, moveCount);
           Depth d = std::max(newDepth - ss->reduction, ONE_PLY);
       {
           ss->reduction = reduction<PvNode>(depth, moveCount);
           Depth d = std::max(newDepth - ss->reduction, ONE_PLY);

-          alpha = SpNode ? sp->alpha : alpha;
+          if (SpNode)
+              alpha = sp->alpha;

 
           value = -search<NonPV>(pos, ss+1, -(alpha+1), -alpha, d);
 
 
           value = -search<NonPV>(pos, ss+1, -(alpha+1), -alpha, d);
 


@@ -940,7 +941,9 @@ split_point_start: // At split points actual search starts from here
       // Step 16. Full depth search, when LMR is skipped or fails high
       if (doFullDepthSearch)
       {
       // Step 16. Full depth search, when LMR is skipped or fails high
       if (doFullDepthSearch)
       {

-          alpha = SpNode ? sp->alpha : alpha;
+          if (SpNode)
+              alpha = sp->alpha;
+

           value = newDepth < ONE_PLY ?
                           givesCheck ? -qsearch<NonPV,  true>(pos, ss+1, -(alpha+1), -alpha, DEPTH_ZERO)
                                      : -qsearch<NonPV, false>(pos, ss+1, -(alpha+1), -alpha, DEPTH_ZERO)
           value = newDepth < ONE_PLY ?
                           givesCheck ? -qsearch<NonPV,  true>(pos, ss+1, -(alpha+1), -alpha, DEPTH_ZERO)
                                      : -qsearch<NonPV, false>(pos, ss+1, -(alpha+1), -alpha, DEPTH_ZERO)