Instead of a pointer. This should fix the issue of
remaining with a stale pointer when for instance calling
IID, but also null search verification, singular search
and razoring where we call search with the same ss
pointer. In this case ss->ei is overwritten in the
search() call and upon returning remains stale.
This patch could have a performance hit because Eval::Info
is big (176 bytes) and during splitting we copy 4 ss entries.
On the good side, this patch is a clean solution.
Proposed by Gary.
No functional change.
Move movesSearched[64];
StateInfo st;
Move movesSearched[64];
StateInfo st;
const TTEntry *tte;
SplitPoint* splitPoint;
Key posKey;
const TTEntry *tte;
SplitPoint* splitPoint;
Key posKey;
bestValue = -VALUE_INFINITE;
ss->currentMove = threatMove = (ss+1)->excludedMove = bestMove = MOVE_NONE;
ss->ply = (ss-1)->ply + 1;
bestValue = -VALUE_INFINITE;
ss->currentMove = threatMove = (ss+1)->excludedMove = bestMove = MOVE_NONE;
ss->ply = (ss-1)->ply + 1;
(ss+1)->skipNullMove = false; (ss+1)->reduction = DEPTH_ZERO;
(ss+2)->killers[0] = (ss+2)->killers[1] = MOVE_NONE;
(ss+1)->skipNullMove = false; (ss+1)->reduction = DEPTH_ZERO;
(ss+2)->killers[0] = (ss+2)->killers[1] = MOVE_NONE;
// Never assume anything on values stored in TT
if ( (ss->staticEval = eval = tte->eval_value()) == VALUE_NONE
||(ss->evalMargin = tte->eval_margin()) == VALUE_NONE)
// Never assume anything on values stored in TT
if ( (ss->staticEval = eval = tte->eval_value()) == VALUE_NONE
||(ss->evalMargin = tte->eval_margin()) == VALUE_NONE)
- eval = ss->staticEval = evaluate(pos, ss->evalMargin, &ei);
+ eval = ss->staticEval = evaluate(pos, ss->evalMargin, &ss->ei);
// Can ttValue be used as a better position evaluation?
if (ttValue != VALUE_NONE)
// Can ttValue be used as a better position evaluation?
if (ttValue != VALUE_NONE)
- eval = ss->staticEval = evaluate(pos, ss->evalMargin, &ei);
+ eval = ss->staticEval = evaluate(pos, ss->evalMargin, &ss->ei);
TT.store(posKey, VALUE_NONE, BOUND_NONE, DEPTH_NONE, MOVE_NONE,
ss->staticEval, ss->evalMargin);
}
TT.store(posKey, VALUE_NONE, BOUND_NONE, DEPTH_NONE, MOVE_NONE,
ss->staticEval, ss->evalMargin);
}
assert(depth <= DEPTH_ZERO);
StateInfo st;
assert(depth <= DEPTH_ZERO);
StateInfo st;
const TTEntry* tte;
Key posKey;
Move ttMove, move, bestMove;
const TTEntry* tte;
Key posKey;
Move ttMove, move, bestMove;
// Never assume anything on values stored in TT
if ( (ss->staticEval = bestValue = tte->eval_value()) == VALUE_NONE
||(ss->evalMargin = tte->eval_margin()) == VALUE_NONE)
// Never assume anything on values stored in TT
if ( (ss->staticEval = bestValue = tte->eval_value()) == VALUE_NONE
||(ss->evalMargin = tte->eval_margin()) == VALUE_NONE)
- ss->staticEval = bestValue = evaluate(pos, ss->evalMargin, &ei);
+ ss->staticEval = bestValue = evaluate(pos, ss->evalMargin, &ss->ei);
- ss->staticEval = bestValue = evaluate(pos, ss->evalMargin, &ei);
+ ss->staticEval = bestValue = evaluate(pos, ss->evalMargin, &ss->ei);
// Stand pat. Return immediately if static value is at least beta
if (bestValue >= beta)
// Stand pat. Return immediately if static value is at least beta
if (bestValue >= beta)
Value evalMargin;
int skipNullMove;
int futilityMoveCount;
Value evalMargin;
int skipNullMove;
int futilityMoveCount;