Revert small pop_1st_bit() optimization

We cannot cast a pointer type to an unrelated pointer type.
This is a violation of the strict aliasing rules.

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>

diff --git a/src/bitboard.cpp b/src/bitboard.cpp
index 7d86884d12ee51caab40e70e1b14eac56b3f019c..ca6c2003412082f4e935b9aca345216eec109373 100644 (file)
--- a/src/bitboard.cpp
+++ b/src/bitboard.cpp
@@ -348,19 +348,21 @@ union b_union {
 
 Square pop_1st_bit(Bitboard* bb) {
 
 
 Square pop_1st_bit(Bitboard* bb) {
 

-   b_union* u;
+   b_union u;

    Square ret;
 
    Square ret;
 

-   u = (b_union*)bb;
+   u.b = *bb;

 
 

-   if (u->dw.l)
+   if (u.dw.l)

    {
    {

-       ret = Square(BitTable[((u->dw.l ^ (u->dw.l - 1)) * 0x783a9b23) >> 26]);
-       u->dw.l &= (u->dw.l - 1);
+       ret = Square(BitTable[((u.dw.l ^ (u.dw.l - 1)) * 0x783a9b23) >> 26]);
+       u.dw.l &= (u.dw.l - 1);
+       *bb = u.b;

        return ret;
    }
        return ret;
    }

-   ret = Square(BitTable[((~(u->dw.h ^ (u->dw.h - 1))) * 0x783a9b23) >> 26]);
-   u->dw.h &= (u->dw.h - 1);
+   ret = Square(BitTable[((~(u.dw.h ^ (u.dw.h - 1))) * 0x783a9b23) >> 26]);
+   u.dw.h &= (u.dw.h - 1);
+   *bb = u.b;

    return ret;
 }
 
    return ret;
 }