max_piece_type cleanup, and slight speed increase.

No functional change.

Resolves #81

diff --git a/src/evaluate.cpp b/src/evaluate.cpp
index e4ade31..c915fbf 100644 (file)
--- a/src/evaluate.cpp
+++ b/src/evaluate.cpp
@@ -499,12 +499,11 @@ namespace {
 
     assert(target & (pos.pieces(C) ^ pos.pieces(C, KING)));
 
-    PieceType pt;
-    for (pt = QUEEN; pt > PAWN; --pt)
+    for (PieceType pt = QUEEN; pt > PAWN; --pt)
         if (target & pos.pieces(C, pt))
             return pt;
 
-    return pt;
+    return PAWN;
   }