Use VALUE_ZERO instead of 0 when comparing with Value

This is the correct practice.

No functional change

Resolves #208

diff --git a/src/movepick.cpp b/src/movepick.cpp
index 7a7e13fc8d7603af33081836c617975dfa06131e..edee8179e2d7d3795446b628df14316925a72ae8 100644 (file)
--- a/src/movepick.cpp
+++ b/src/movepick.cpp
@@ -51,7 +51,7 @@ namespace {
 
   // Unary predicate used by std::partition to split positive values from remaining
   // ones so as to sort the two sets separately, with the second sort delayed.
 
   // Unary predicate used by std::partition to split positive values from remaining
   // ones so as to sort the two sets separately, with the second sort delayed.

-  inline bool has_positive_value(const ExtMove& move) { return move.value > 0; }
+  inline bool has_positive_value(const ExtMove& move) { return move.value > VALUE_ZERO; }

 
   // Picks the best move in the range (begin, end) and moves it to the front.
   // It's faster than sorting all the moves in advance when there are few
 
   // Picks the best move in the range (begin, end) and moves it to the front.
   // It's faster than sorting all the moves in advance when there are few

diff --git a/src/search.cpp b/src/search.cpp
index 1f77e0aab3a3c94e114246d085bcbde10f741a85..092a4915d8beeff94641946744f1aea7c7621cd7 100644 (file)
--- a/src/search.cpp
+++ b/src/search.cpp
@@ -906,7 +906,7 @@ moves_loop: // When in check and at SpNode search starts from here
           ss->reduction = reduction<PvNode>(improving, depth, moveCount);
 
           if (   (!PvNode && cutNode)
           ss->reduction = reduction<PvNode>(improving, depth, moveCount);
 
           if (   (!PvNode && cutNode)

-              ||  History[pos.piece_on(to_sq(move))][to_sq(move)] < 0)
+              ||  History[pos.piece_on(to_sq(move))][to_sq(move)] < VALUE_ZERO)

               ss->reduction += ONE_PLY;
 
           if (move == countermoves[0] || move == countermoves[1])
               ss->reduction += ONE_PLY;
 
           if (move == countermoves[0] || move == countermoves[1])


@@ -916,7 +916,7 @@ moves_loop: // When in check and at SpNode search starts from here
           if (   ss->reduction
               && type_of(move) == NORMAL
               && type_of(pos.piece_on(to_sq(move))) != PAWN
           if (   ss->reduction
               && type_of(move) == NORMAL
               && type_of(pos.piece_on(to_sq(move))) != PAWN

-              && pos.see(make_move(to_sq(move), from_sq(move))) < 0)
+              && pos.see(make_move(to_sq(move), from_sq(move))) < VALUE_ZERO)

               ss->reduction = std::max(DEPTH_ZERO, ss->reduction - ONE_PLY);
 
           Depth d = std::max(newDepth - ss->reduction, ONE_PLY);
               ss->reduction = std::max(DEPTH_ZERO, ss->reduction - ONE_PLY);
 
           Depth d = std::max(newDepth - ss->reduction, ONE_PLY);