Allow Position::init() to be called more than once

Currently Zobrist::castling[] are not properly zeroed
and rely on the compiler to do this at startup, but this
makes Position::init() to set different values every time
it is called!

This is a bit odd, and although not impacting normal usage,
can yield to subtle misbehaviour, very difficult to track
down, in case we happen to call it more than once for some
reason. I found this while developing tuning support and
it took me a while to track it down.

So properly init Zobrist::castling[]

No functional change.

Resolves #329

diff --git a/src/position.cpp b/src/position.cpp
index 15ccb4835dbea166a6ae267d30e27056893734ac..5a98821d493dde10d9fe2bd020ba17467c1d7ea5 100644 (file)
--- a/src/position.cpp
+++ b/src/position.cpp
@@ -149,6 +149,7 @@ void Position::init() {
 
   for (int cr = NO_CASTLING; cr <= ANY_CASTLING; ++cr)
   {
+      Zobrist::castling[cr] = 0;
       Bitboard b = cr;
       while (b)
       {

diff --git a/src/ucioption.cpp b/src/ucioption.cpp
index 35c907ae52fb7b368a0feeea36108619adab598e..fd6c46d2f35489beee9b4360c0c37422d3fe3131 100644 (file)
--- a/src/ucioption.cpp
+++ b/src/ucioption.cpp
@@ -19,7 +19,7 @@
 
 #include <algorithm>
 #include <cassert>
-#include <sstream>
+#include <ostream>
 
 #include "misc.h"
 #include "thread.h"