Reduce variable scope in swap_byte

Added a specialization to remove the 'if' condition

No functional change.

diff --git a/src/syzygy/tbprobe.cpp b/src/syzygy/tbprobe.cpp
index b553ac9fd4946a3b620aee9557deced93bf4a3c7..d13e90183508b5b28f06a8c7cd75b3b78d6735b9 100644 (file)
--- a/src/syzygy/tbprobe.cpp
+++ b/src/syzygy/tbprobe.cpp
@@ -228,10 +228,10 @@ template<typename T, int Half = sizeof(T) / 2, int End = sizeof(T) - 1>
 inline void swap_byte(T& x)
 {
     char tmp, *c = (char*)&x;
 inline void swap_byte(T& x)
 {
     char tmp, *c = (char*)&x;

-    if (Half) // Fix a MSVC 2015 warning
-        for (int i = 0; i < Half; ++i)
-            tmp = c[i], c[i] = c[End - i], c[End - i] = tmp;
+    for (int i = 0; i < Half; ++i)
+        tmp = c[i], c[i] = c[End - i], c[End - i] = tmp;

 }
 }

+template<> inline void swap_byte<uint8_t, 0, 0>(uint8_t&) {}

 
 template<typename T, int LE> T number(void* addr)
 {
 
 template<typename T, int LE> T number(void* addr)
 {