Introduce assert for stats update

Make sure updates to the stats are done in a stable way.

No functional change

Closes #1038
Closes #1037

diff --git a/src/movepick.h b/src/movepick.h
index c19141820e3397804580a06fbc8b02df12e5e7a0..ee7cf4a445dd257cc39160fd135a53f85e1ac23e 100644 (file)
--- a/src/movepick.h
+++ b/src/movepick.h
@@ -42,7 +42,11 @@ struct HistoryStats {
     Square from = from_sq(m);
     Square to = to_sq(m);
 
-    table[c][from][to] -= table[c][from][to] * abs(int(v)) / 324;
+    const int denom = 324;
+
+    assert(abs(int(v)) <= denom); // Needed for stability.
+
+    table[c][from][to] -= table[c][from][to] * abs(int(v)) / denom;
     table[c][from][to] += int(v) * 32;
   }
 
@@ -65,7 +69,11 @@ struct Stats {
   void update(Piece pc, Square to, Move m) { table[pc][to] = m; }
   void update(Piece pc, Square to, Value v) {
 
-    table[pc][to] -= table[pc][to] * abs(int(v)) / 936;
+    const int denom = 936;
+
+    assert(abs(int(v)) <= denom); // Needed for stability.
+
+    table[pc][to] -= table[pc][to] * abs(int(v)) / denom;
     table[pc][to] += int(v) * 32;
   }
 

diff --git a/tests/instrumented.sh b/tests/instrumented.sh
index a6950e164b53a46878a74fdfeec5ab1978aa3298..4c6881510d915d7e0462cb719f1bcd1ac2f5486e 100755 (executable)
--- a/tests/instrumented.sh
+++ b/tests/instrumented.sh
@@ -61,6 +61,10 @@ cat << EOF > game.exp
  send "go nodes 1000\n"
  expect "bestmove"
 
+ send "position fen 5rk1/1K4p1/8/8/3B4/8/8/8 b - - 0 1\n"
+ send "go depth 30\n"
+ expect "bestmove"
+
  send "quit\n"
  expect eof