It seems it yields to missing wake-up events with the
result of SF loosing on time as reported by many people.
So revert the patch and use a more robust approach: assume
there can be spurious wake ups events and make the code to
work also in those cases.
While debugging I found that WaitForSingleObject() had wrong
parameter 0 instead of INFINITE yielding to a crash while
exiting under Windows, strangely unnoticed til now.
No functional change.
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
# define cond_init(x) { *x = CreateEvent(0, FALSE, FALSE, 0); }
# define cond_destroy(x) CloseHandle(*x)
# define cond_signal(x) SetEvent(*x)
# define cond_init(x) { *x = CreateEvent(0, FALSE, FALSE, 0); }
# define cond_destroy(x) CloseHandle(*x)
# define cond_signal(x) SetEvent(*x)
-# define cond_wait(x,y) { ResetEvent(*x); lock_release(y); WaitForSingleObject(*x, INFINITE); lock_grab(y); }
-# define cond_timedwait(x,y,z) { ResetEvent(*x); lock_release(y); WaitForSingleObject(*x,z); lock_grab(y); }
+# define cond_wait(x,y) { lock_release(y); WaitForSingleObject(*x, INFINITE); lock_grab(y); }
+# define cond_timedwait(x,y,z) { lock_release(y); WaitForSingleObject(*x,z); lock_grab(y); }
// Wait for thread termination
#if defined(_MSC_VER)
// Wait for thread termination
#if defined(_MSC_VER)
- WaitForSingleObject(threads[i].handle, 0);
+ WaitForSingleObject(threads[i].handle, INFINITE);
CloseHandle(threads[i].handle);
#else
pthread_join(threads[i].handle, NULL);
CloseHandle(threads[i].handle);
#else
pthread_join(threads[i].handle, NULL);
cond_signal(&main.sleepCond); // Wake up main thread and start searching
if (!asyncMode)
cond_signal(&main.sleepCond); // Wake up main thread and start searching
if (!asyncMode)
- cond_wait(&sleepCond, &main.sleepLock);
+ while (!main.do_sleep)
+ cond_wait(&sleepCond, &main.sleepLock);
lock_release(&main.sleepLock);
}
lock_release(&main.sleepLock);
}