Merge remote-tracking branch 'upstream/master'
authorGary Linscott <glinscott@gmail.com>
Sun, 25 Mar 2012 14:18:29 +0000 (10:18 -0400)
committerGary Linscott <glinscott@gmail.com>
Sun, 25 Mar 2012 14:18:29 +0000 (10:18 -0400)
src/evaluate.cpp

index 2903c4b375da81736478ee3fb6439e6f2f749c08..c03aa99f51940f0f0ec96fcbc7dce8b5ec9b4e69 100644 (file)
@@ -167,8 +167,8 @@ namespace {
   // happen in Chess960 games.
   const Score TrappedBishopA1H1Penalty = make_score(100, 100);
 
-  // Penalty for a minor piece that is not defended by anything
-  const Score UndefendedMinorPenalty = make_score(25, 10);
+  // Penalty for BNR that is not defended by anything
+  const Score UndefendedPiecePenalty = make_score(25, 10);
 
   // The SpaceMask[Color] contains the area of the board which is considered
   // by the space evaluation. In the middle game, each side is given a bonus
@@ -682,13 +682,15 @@ Value do_evaluate(const Position& pos, Value& margin) {
     Bitboard b;
     Score score = SCORE_ZERO;
 
-    // Undefended minors get penalized even if not under attack
-    Bitboard undefended =  pos.pieces(Them)
-                         & (pos.pieces(BISHOP) | pos.pieces(KNIGHT))
-                         & ~ei.attackedBy[Them][0];
-    if (undefended)
-        score += single_bit(undefended) ? UndefendedMinorPenalty
-                                        : UndefendedMinorPenalty * 2;
+    // Undefended pieces get penalized even if not under attack
+    Bitboard undefended = pos.pieces(Them) & ~ei.attackedBy[Them][0];
+    const Bitboard undefendedMinors = undefended & (pos.pieces(BISHOP) | pos.pieces(KNIGHT));
+    
+    if (undefendedMinors)
+        score += single_bit(undefendedMinors) ? UndefendedPiecePenalty
+                                              : UndefendedPiecePenalty * 2;
+    if (undefended & pos.pieces(ROOK))
+        score += UndefendedPiecePenalty;
 
     // Enemy pieces not defended by a pawn and under our attack
     Bitboard weakEnemies =  pos.pieces(Them)