Allow Position::init() to be called multiple times.

For the rationale to allow this, see commit
a66c73deef420104e74b6645ee60e20b37fd8549

This was broken when cuckoo hashing was added, and
subtly broke (for example) lichess' Android application,
thus illustrating the original judgement was sound.

No functional change.

diff --git a/src/position.cpp b/src/position.cpp
index 29a2b314741f8f5db6ebc920d8c76c2881cf8a37..84c7ae8f1c65539101650b68492fe4a902de8f7d 100644 (file)
--- a/src/position.cpp
+++ b/src/position.cpp
@@ -168,6 +168,8 @@ void Position::init() {
   Zobrist::noPawns = rng.rand<Key>();
 
   // Prepare the cuckoo tables
   Zobrist::noPawns = rng.rand<Key>();
 
   // Prepare the cuckoo tables

+  std::memset(cuckoo, 0, sizeof(cuckoo));
+  std::memset(cuckooMove, 0, sizeof(cuckooMove));

   int count = 0;
   for (Piece pc : Pieces)
       for (Square s1 = SQ_A1; s1 <= SQ_H8; ++s1)
   int count = 0;
   for (Piece pc : Pieces)
       for (Square s1 = SQ_A1; s1 <= SQ_H8; ++s1)