From: protonspring <mike@whiteley.org>
Date: Fri, 2 Nov 2018 16:49:51 +0000 (-0600)
Subject: Code style in search.cpp
X-Git-Url: https://git.sesse.net/?p=stockfish;a=commitdiff_plain;h=0e508f30bb2129f87b41ab3d721fd0400631f6fc;ds=sidebyside

Code style in search.cpp

It does not appear to be not necessary or advantageous to
conditionally initialize kingRing[Us] or kingAttackersCount[Them],
so the 'else' can be removed.

STC
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 22873 W: 4923 L: 4804 D: 13146
http://tests.stockfishchess.org/tests/view/5be9a8270ebc595e0ae33c7e

No functional change
---

diff --git a/src/evaluate.cpp b/src/evaluate.cpp
index 613f8926..297d8c65 100644
--- a/src/evaluate.cpp
+++ b/src/evaluate.cpp
@@ -257,6 +257,7 @@ namespace {
     attackedBy[Us][PAWN] = pe->pawn_attacks(Us);
     attackedBy[Us][ALL_PIECES] = attackedBy[Us][KING] | attackedBy[Us][PAWN];
     attackedBy2[Us]            = attackedBy[Us][KING] & attackedBy[Us][PAWN];
+    kingRing[Us] = kingAttackersCount[Them] = 0;
 
     // Init our king safety tables only if we are going to use them
     if (pos.non_pawn_material(Them) >= RookValueMg + KnightValueMg)
@@ -274,8 +275,6 @@ namespace {
         kingAttackersCount[Them] = popcount(kingRing[Us] & pe->pawn_attacks(Them));
         kingAttacksCount[Them] = kingAttackersWeight[Them] = 0;
     }
-    else
-        kingRing[Us] = kingAttackersCount[Them] = 0;
   }